I should add that all of the mentioned standard roots are handled
automatically by CS_CHECK_LIB_WITH(), which is why it makes sense to
write the test in a way that allows CS_CHECK_LIB_WITH() to work properly
rather than employing it incorrectly and tacking a single case on top of
it, which works for only one possible configuration.
-- ES
Eric Sunshine wrote:
> It is a special case because it assumes a root of /usr/local/include. It
> does not take into account any of the other standard roots, such as
> /usr/include, /opt/include, /opt/local/include, /sw/include,
> /sw/local/include, etc.
>
> -- ES
>
> Mike Gist wrote:
>> From what I can gather this changes nothing except *adding* a extra
>> directory to look in.
>> That dir is also how bullet installs itself, so I don't see how it's a
>> special case.
>>
>> 2008/9/18 Eric Sunshine <sunshine@...
>> <mailto:sunshine@...>>
>>
>> If that is the case, then the configure test should have worked
>> without any change. The change to which I objected actually assumes
>> that headers are in a "bullet" subdirectory.
>>
>> If the real issue is that the headers are "randomly" installed
>> sometimes in a "bullet" subdirectory and sometimes not, then that is a
>> more difficult issue to solve, but the committed patch is still a bad
>> special-purpose hack. A more generalized solution is warranted.
>>
>> -- ES
>>
>> On Thu, Sep 18, 2008 at 7:26 AM, Jorrit Tyberghein
>> <jorrit.tyberghein@... <mailto:jorrit.tyberghein@...>>
>> wrote:
>> > I don't believe that's possible as in some situations the bullet
>> > includes are not installed
>> > in a directory relative to 'bullet'. i.e. it is not always
>> 'bullet/bla.h'
>> >
>> > Greetings,
>> >
>> > On Thu, Sep 18, 2008 at 1:24 PM, Eric Sunshine
>> <sunshine@... <mailto:sunshine@...>> wrote:
>> >> This is the incorrect approach. It is essentially a special-case
>> hack
>> >> which will work for only one configuration. Please revert. To
>> fix this
>> >> properly, the "bullet" prefix should be mentioned in the #include
>> >> statements (also, it is more proper to use #include <...> rather
>> than
>> >> #include "..."). Finally, source code in CS itself should also
>> use the
>> >> "bullet" prefix in #include <...> statements.
>> >>
>> >> -- ES
>> >>
>> >>
>> >> mgist@... <mailto:mgist@...>
>> wrote:
>> >>> Revision: 31196
>> >>>
>> http://crystal.svn.sourceforge.net/crystal/?rev=31196&view=rev
>> <http://crystal.svn.sourceforge.net/crystal/?rev=31196&view=rev>
>> >>> Author: mgist
>> >>> Date: 2008-09-18 09:27:24 +0000 (Thu, 18 Sep 2008)
>> >>>
>> >>> Log Message:
>> >>> -----------
>> >>> - Added an extra search path for libbullet.
>> >>>
>> >>> Modified Paths:
>> >>> --------------
>> >>> CS/trunk/configure
>> >>> CS/trunk/configure.ac <http://configure.ac>
>> >>>
>> >>> Modified: CS/trunk/configure
>> >>> ===================================================================
>> >>> --- CS/trunk/configure 2008-09-18 08:12:22 UTC (rev 31195)
>> >>> +++ CS/trunk/configure 2008-09-18 09:27:24 UTC (rev 31196)
>> >>> @@ -53037,7 +53037,7 @@
>> >>> cs_check_lib_paths="| /usr/local/include|/usr/local/lib \
>> >>> /sw/include|/sw/lib \
>> >>> /opt/local/include|/opt/local/lib \
>> >>> - /opt/include|/opt/lib "
>> >>> + /opt/include|/opt/lib /usr/local/include/bullet/"
>> >>> fi
>> >>>
>> >>> for cs_lib_item in $cs_check_lib_paths
>> >>>
>> >>> Modified: CS/trunk/configure.ac <http://configure.ac>
>> >>> ===================================================================
>> >>> --- CS/trunk/configure.ac <http://configure.ac> 2008-09-18
>> 08:12:22 UTC (rev 31195)
>> >>> +++ CS/trunk/configure.ac <http://configure.ac> 2008-09-18
>> 09:27:24 UTC (rev 31196)
>> >>> @@ -1347,7 +1347,7 @@
>> >>> btSequentialImpulseConstraintSolver* s;
>> >>> btDefaultCollisionConfiguration* c;
>> >>> btDynamicsWorld* world = new btDiscreteDynamicsWorld (d,
>> b, s, c)])],
>> >>> - [], [C++], [], [],
>> >>> + [/usr/local/include/bullet/], [C++], [], [],
>> >>> [], [], [-lbulletdynamics -lbulletcollision -lbulletmath],
>> >>> [bulletdynamics])
>> >>
>> >>
>> -------------------------------------------------------------------------
>> >> This SF.Net email is sponsored by the Moblin Your Move
>> Developer's challenge
>> >> Build the coolest Linux based applications with Moblin SDK & win
>> great prizes
>> >> Grand prize is a trip for two to an Open Source event anywhere
>> in the world
>> >> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> <http://moblin-contest.org/redirect.php?banner_id=100&url=/>
>> >> _______________________________________________
>> >> Crystal-develop mailing list
>> >> Crystal-develop@...
>> <mailto:Crystal-develop@...>
>> >> https://lists.sourceforge.net/lists/listinfo/crystal-develop
>> >>
>> >
>> >
>> >
>> > --
>> > Project Manager of Crystal Space (http://www.crystalspace3d.org)
>> > and CEL (http://cel.crystalspace3d.org)
>> > Support Crystal Space. Donate at
>> > https://sourceforge.net/donate/index.php?group_id=649
>> > Visit my town at http://waldir.myminicity.com/
>> >
>> >
>> -------------------------------------------------------------------------
>> > This SF.Net email is sponsored by the Moblin Your Move
>> Developer's challenge
>> > Build the coolest Linux based applications with Moblin SDK & win
>> great prizes
>> > Grand prize is a trip for two to an Open Source event anywhere in
>> the world
>> > http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> <http://moblin-contest.org/redirect.php?banner_id=100&url=/>
>> > _______________________________________________
>> > Crystal-develop mailing list
>> > Crystal-develop@...
>> <mailto:Crystal-develop@...>
>> > https://lists.sourceforge.net/lists/listinfo/crystal-develop
>> >
>>
>> -------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Moblin Your Move Developer's
>> challenge
>> Build the coolest Linux based applications with Moblin SDK & win
>> great prizes
>> Grand prize is a trip for two to an Open Source event anywhere in
>> the world
>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> <http://moblin-contest.org/redirect.php?banner_id=100&url=/>
>> _______________________________________________
>> Crystal-develop mailing list
>> Crystal-develop@...
>> <mailto:Crystal-develop@...>
>> https://lists.sourceforge.net/lists/listinfo/crystal-develop
>>
>>
>>
>>
>> --
>> -Mike
>>
>>
>> ------------------------------------------------------------------------
>>
>> -------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
>> Build the coolest Linux based applications with Moblin SDK & win great prizes
>> Grand prize is a trip for two to an Open Source event anywhere in the world
>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Crystal-develop mailing list
>> Crystal-develop@...
>> https://lists.sourceforge.net/lists/listinfo/crystal-develop
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Crystal-develop mailing list
> Crystal-develop@...
> https://lists.sourceforge.net/lists/listinfo/crystal-develop
>
|