On 10/16/2010 01:21 PM, David Engster wrote:
> Eric M. Ludlam writes:
>> On 10/04/2010 01:50 PM, David Engster wrote:
>> > +(define-mode-local-override semantic--tag-similar-types-p c-mode
>> (tag1 tag2)
>> > + "For c-mode, if only one of the types is fully qualfied, we
>> > +split its name and compare the last element."
>>
>> In this case my mail says there is a qualified typo.
>
> :-)
>
>> But aside from that, after splitting the names, should it compare the
>> last N strings, where N is min( num_tag1_strs, num_tag2_strs ) instead?
>> That way if you have:
>>
>> foo::bar::someclass myfcn();
>>
>> noodle::poodle::someclass myfcn() { }
>>
>> it won't get confused?
>
> The code did only compare types in case one of them is a string, i.e.,
> not qualified at all. But you are right that comparing the last N
> strings is better, since one of the types could just be 'shorter' (half
> qualified? whatever...), meaning it wouldn't detect that those two
>
> namespace foo {
> bar::someclass myfcn();
> }
>
> foo::bar::someclass myfcn();
>
> are in fact the same.
>
> I've rewritten the similar-type function to do what you've suggested,
> and I've finally merged that branch into trunk (use 'bzr log -n0' to see
> the single commits).
>
Great!
Thanks for your help on this, and many other things this past week or so.
Only 2 weeks left until my big Punkin Chunkin contest! I learned that
my machine will be one of the featured catapults on the Science Channel
this year, and the Mythbuster guys will be the hosts of the show. How
cool will that be?
Yea, I thought so. :)
Eric
|