Sambit Gaan provided me with a number of patches via a zip file. I
have made most of them available on my GitHub account:
Sambit, I left out the two commits that reintroduced a junit4.5.jar
that no longer applied to master, and we'll discuss that in more
I have not commented on any of them, and will not have time for that
until tomorrow earliest... so, all, please comment. If you approve of
a patch, please sign it off, and send it to one of the gatekeepers
(Rajarshi, John, or me)...
On Wed, May 1, 2013 at 8:33 PM, Sambit Gaan <sambit.gaan@...> wrote:
> Hi Egon,
> Thanks for the advice. As per your suggestion I tried to create a private
> GIT repo and tried to give access to public so that you can see the change
> list. But I was unsuccessful in that.
> Also as I was busy with some of my personal and professional commitments
> hence there was a delay in sending you the patches.
> Please review the attached patches and commit those if they are through the
> Sambit Gaan
> On Sun, Apr 21, 2013 at 11:08 PM, Egon Willighagen
> <egon.willighagen@...> wrote:
>> Hi Sambit,
>> On Sun, Apr 21, 2013 at 7:25 PM, Sambit Gaan <sambit.gaan@...>
>> > Please note that the following list is my commit list till now.
>> > 7d133ecdf4f53c2b8de242185def6a623b355218
>> > 45e555394b863a00099e56dfdb3720e2a7be408b
>> > 400b4bb5a864b3f4625d370e6e7bf6eee442ea0e
>> > 7291aaf7fa01766f76cdaaece2bbce306d15cfc6
>> > c0e49823c4088c4854e21f949d87ffc5f4f68c90
>> > ccdb2e90239cd6eff87677cf64c6acddefe10916
>> > 5dda9c4709c57731a9784d776c8edcb283dd60ca
>> > 6593668d28fd990a11e831207079a576088695b3
>> > dacfc91832e53d886b24d53cab45ae6b219b3c11
>> > a5c7b2a25e28411b13e5a8efd12e4220fe7658e8
>> > cf2eac816fff315eac0995cfdc1f0113a43f456b
>> > f2fad6a8909bfec60a96f9aae1abbde2a7d27a61
>> I can confirm that these patches are not part of any of the
>> repositories I have copies of. Where can I find your git repository
>> online, so that I can copy these patches?
>> > Requesting you to review the changes and push it to the master branch as
>> > appropriate.
>> Patches will be reviewed by other developers and need to be accepted
>> before they get applied to the main master branch.
>> But first we need to see the patches. You can use GitHub for that, or
>> any other git hosting services (Bitbucket or Gitorious do fine too).
>> Or, you can email the patches (google for "git format-patch") or
>> upload them to the patch tracker:
>> https://sourceforge.net/p/cdk/patches/ (You can add multiple commits
>> to one "patch" in this tracker).
>> I hope this helps,
>> with kind regards,
>> Dr E.L. Willighagen
>> Postdoctoral Researcher
>> Department of Bioinformatics - BiGCaT
>> Maastricht University (http://www.bigcat.unimaas.nl/)
>> Homepage: http://egonw.github.com/
>> LinkedIn: http://se.linkedin.com/in/egonw
>> Blog: http://chem-bla-ics.blogspot.com/
>> PubList: http://www.citeulike.org/user/egonw/tag/papers
Dr E.L. Willighagen
Department of Bioinformatics - BiGCaT
Maastricht University (http://www.bigcat.unimaas.nl/)