Some of this work has broken the build for MSVC for me. I haven't been
following it too closely, but maybe it's related to Richard's question
about Cygwin, which I think is what Martyn's using (?). For example,
these files try to include a "config.h" and don't find it:
Is AM_MAINTAINER_MODE just a compiler flag that needs to be set. Where?
Or is this a matter of fixing the include paths? libmad has a "config.h"
in the project...
Dominic Mazzoni wrote:
> On Sep 13, 2005, at 3:56 PM, MartynShaw@... wrote:
>> I did as you suggested and it worked fine.
>> Is configwin32.h supposed to be there?
> Nope, thanks for catching that. I removed that from CVS too.
> - Dominic
>> In a message dated 13/09/2005 08:06:33 GMT Standard Time,
>> dominic@... writes:
>> Thanks for testing it.
>> configwin.h is deprecated, I forgot to remove it from CVS but just
>> did now. I also removed config.h, it wasn't supposed to be checked
>> in. Please change back layer3.c and decoder.c, and instead put the
>> new msvc++ directory into the include path.
>> Now, on any Unix system (including Cygwin), config.h is automatically
>> generated from config.h.in with the proper settings.
>> On Windows, msvc++ will be in the include path, so it uses a
>> pregenerated config.h designed for Windows. Any Windows-specific
>> changes should go there.
>> - Dominic
>> On Sep 12, 2005, at 3:50 PM, MartynShaw@... wrote:
>> > Dominic
>> > For what it's worth, I did an update on HEAD and libmad would not
>> > compile. A diff on layer3.c with a previous version had (amongst
>> > other things)
>> > 23,27c23
>> > < # ifdef WIN32
>> > < # include "configwin32.h"
>> > < # else
>> > < # include "config.h"
>> > < # endif
>> > ---
>> > > # include "config.h"
>> > so I put it back how it was and that seemed to work. I had to do
>> > the same in decoder.c in order not to #define HAVE_SYS_WAIT_H 1,
>> > which is in config.h. The library now compiles for me but I don't
>> > know if this was an accidental omission or something more subtle.
>> > HTH
>> > Martyn
>> > In a message dated 12/09/2005 08:37:19 GMT Standard Time,
>> > dominic@... writes:
>> > I spend some time with both branches of Audacity today, and
>> checked in
>> > some changes, most to help it compile "out of the box". A couple
>> > minor changes related to wx 2.6 incompatibility; the major change was
>> > that the following four libraries now have AM_MAINTAINER_MODE in
>> > configuration scripts:
>> > soundtouch
>> > libsndfile
>> > libmad
>> > libid3tag
>> > I had tried to do this before but had trouble, but I finally
>> > figured out
>> > how to make this work. What this means is that unless you explicitly
>> > tell it to, running "make" will NEVER trigger re-running configure,
>> > and
>> > running configure or make will NEVER trigger running aclocal,
>> > automake,
>> > or any other autotools. Those all tend to cause problems for users
>> > who
>> > don't have the right versions of autotools installed, and they're
>> > triggered way too often when checking out Audacity over CVS.
>> > I also upgraded libmad from 0.14.2b to 0.15.1 (both branches), and I
>> > addressed (in CVS HEAD only) the recent bug in Bugzilla that not all
>> > encoding formats are supported by "Import Raw" (now the ones not
>> > supported are no longer displayed).
>> > - Dominic