TODO 1: Fix speed/cancel when sending from SB
TODO 2: Bring back "save file under user dir" option
TODO 3: Decipher that new SLP that WLM sends when upnp-ing (ask lfrb?)
TODO 4: P2Pv2
wrt #1 :
23:28 <@vivia> right now... when we receive an ack, the
switchboard.tcl says "okay i can send the next chunk"
23:29 <@vivia> maybe if there are more than 5 unacked, instead of
queueing, i should return "cannot send"
23:29 <@vivia> and the send queue elsewhere (which says "read next
data, chunk it and send it")
23:29 <@KaKaRoTo> vivia, how does it fill up the queue
23:29 <@KaKaRoTo> does it just read, loop, and 'send' ?
23:29 <@vivia> KaKaRoTo: yes
23:29 <@KaKaRoTo> or does it do it on a timer or something ?
23:29 <@vivia> so instead of read, loop, send
23:30 <@vivia> it should read, loop, wait until transport is ready, sent
23:30 <@KaKaRoTo> it should only call that 'send_one_more_blob' when
the socket is writable
23:30 <@vivia> yes
23:30 <@vivia> direct ready == socket writable
23:30 <@vivia> sb ready == less than 5 unacked
23:30 <@vivia> so wait until it's ready then read next part to send
On Mon, Feb 14, 2011 at 23:01, Vivia Nikolaidou <vivia@...> wrote:
> Thanks Alex! VGJ!
> You had forgotten one small modification on gui.tcl so
> sending/receiving files didn't work - I fixed that. I also examined
> the current diff between the trunk and the branch, with all brainpower
> I had left, didn't look like it had anything wrong.
> However, everyone please keep in mind that we might have problems in
> the near future :)
> I also didn't extensively examine msncam.tcl since it worked, it had
> many modifications where I removed legacy objoptions and replaced them
> with 'good' snit.
> On Mon, Feb 14, 2011 at 00:36, Vivia Nikolaidou <vivia@...> wrote:
>>> On Sun, Feb 13, 2011 at 04:13, Alexander Nestorov
>>> <alexandernst@...> wrote:
>>>> Ok, done merging again :)
>>>> This time the patch is ~75kb, I'm sure that everything went fine, but again,
>>>> some testing is needed.
>> Thanks!!! GJ! ☺
>> On Mon, Feb 14, 2011 at 00:25, Boris 'billiob' Faure <billiob@...> wrote:
>>> @vivia: what about those #@@@@@@@@@@ comments?
>> Notes to self. Most of them are places to be modified for p2pv2.
>> They're easy to see and easy to grep, so that's why I use them ☺
>>> It's running fine for me ftm.
>> Thanks for testing! I'll still have to review it myself though, found
>> no time for it today.