On Thu, Nov 25, 2010 at 12:07 PM, Bart Van Assche <bvanassche@acm.org> wrote:

On Thu, Nov 25, 2010 at 8:36 AM, Bart Van Assche <bvanassche@acm.org> wrote:
Results differ from 24 hours ago
[ ... ]
= kernel 2.6.36.1 =
[ ... ]
Compiling the patched kernel ...
-0 errors / 0 warnings.
+2 errors / 0 warnings.
+ 1 drivers/scst/fcst/ft_cmd.c:182: error: 'struct libfc_function_template' has no member named 'seq_release'
+ 1 drivers/scst/fcst/ft_scst.c:82: error: implicit declaration of function 'fc_lport_iterate'
[ ... ]

Hello Joe,

Can you have a look at this ?

Hello Joe,

I had a closer look at r2804/r2823, and noticed the following:

- fcst/linux-patches/22-lport-notify seems like a forward port of fcst/linux-patches/06-lport-notify. However, the latter adds a declaration of fc_lport_iterate() to include/scsi/libfc.h while the former does not. Sparse fails for kernel 2.6.36 on fcst because of that missing declaration.

- Code that was added in ft_cmd.c refers to a function pointer member seq_release. Where has that member been defined ? I have not been able to find a definition in the upstream libfc nor in one of the patches in the fcst directory.

#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 36)

struct fc_lport *lport;

lport = fr_dev(fp);

if (fr_seq(fp))

lport->tt.seq_release(fr_seq(fp));

#endif

Bart.