Changeset 3052

Timestamp:

01/28/10 19:51:24 (3 years ago)

Author:

chrfranke

Message:

Linux: Fix spin-up of SATA drive if '-n standby' is used (ticket #37).

Location:

trunk/smartmontools

Files:

• CHANGELOG (modified) (1 diff)
• NEWS (modified) (1 diff)
• os_linux.cpp (modified) (1 diff)

trunk/smartmontools/CHANGELOG

@@ -43 +43 @@
 <DEVELOPERS: ADDITIONS TO THE CHANGE LOG GO JUST BELOW HERE, PLEASE>
 
+  [CF] Linux: Fix spin-up of SATA drive if '-n standby' is used
+       (ticket #37).  For some reason, this happens if the SCSI/SAT
+       device is opened with O_RDWR instead of O_RDONLY.
+
   [CF] Windows: Fix parsing of 'tw_cli' output for 3ware 9.5.x release
-       (ticket #43.)
+       (ticket #43).
 
   [CF] Add USB IDs of Seagate FreeAgent Go, Seagate Expansion Portable

trunk/smartmontools/NEWS

@@ -16 +16 @@
 - Fix regression in smartd directive '-l selftest'.
 - Linux: Allow smartd 'DEVICESCAN -d sat'.
+- Linux: Fix spin-up of SATA drive if '-n standby' is used.
 - Windows: Fix parsing of 3ware 'tw_cli' output.
 

trunk/smartmontools/os_linux.cpp

@@ -846 +846 @@
   const char * dev_name, const char * req_type, bool scanning /*= false*/)
 : smart_device(intf, dev_name, "scsi", req_type),
-  linux_smart_device(O_RDWR | O_NONBLOCK, O_RDONLY | O_NONBLOCK),
+  // If opened with O_RDWR, a SATA disk in standby mode
+  // may spin-up after device close().
+  linux_smart_device(O_RDONLY | O_NONBLOCK),
   m_scanning(scanning)
 {