Changeset 5734

Timestamp:

01/18/12 07:12:49 (16 months ago)

Author:

yuichironaito

Message:

use GFARM_CALLOC insted of memset(buf,0,size).
add error check.

Files:

• gfarm_v2/trunk/bench/gfperf/gfperf-lib/create_file.c (modified) (2 diffs)

gfarm_v2/trunk/bench/gfperf/gfperf-lib/create_file.c

@@ -35 +35 @@
         filename = url;
 
-        GFARM_MALLOC_ARRAY(buf, COPY_BUF_SIZE);
+        GFARM_CALLOC_ARRAY(buf, COPY_BUF_SIZE);
         if (buf == NULL) {
                 fprintf(stderr, "can not allocate memory.\n");
                 return (GFARM_ERR_NO_MEMORY);
         }
-        memset(buf, 0, COPY_BUF_SIZE);
 
         e = gfs_stat(filename, &sb);
         if (e != GFARM_ERR_NO_SUCH_FILE_OR_DIRECTORY) {
                 fprintf(stderr, "file exists: %s\n", filename);
-                gfs_stat_free(&sb);
+                if (e == GFARM_ERR_NO_ERROR)
+                        gfs_stat_free(&sb);
                 free(buf);
                 return (GFARM_ERR_ALREADY_EXISTS);
@@ -103 +103 @@
         int fp;
 
-        GFARM_MALLOC_ARRAY(buf, COPY_BUF_SIZE);
+        GFARM_CALLOC_ARRAY(buf, COPY_BUF_SIZE);
         if (buf == NULL) {
                 fprintf(stderr, "can not allocate memory.\n");
                 return (GFARM_ERR_NO_MEMORY);
         }
-        memset(buf, 0, COPY_BUF_SIZE);
 
         fp = open(filename, O_WRONLY|O_CREAT|O_EXCL, 0644);