Timeline
01/25/11:
- 04:34 Ticket #1624 (Use of undefined constant AUTO_CHECK_INTERVAL) created by
-
Auto check code is broken. We should fix this ASAP.
http://gallery.menalto.com/gallery_3.0.1_feedback#comment-366614
01/23/11:
- 20:15 Ticket #1623 (Permissions notice for non-Apache server) created by
-
G3 should attempt to place the .htaccess to set permissions and should that fail, it should notify users with an error message about an unsupported server. This is because Apache is not the only server that can handle mod_rewrite or equivalents of that module for other http servers.
- 14:53 Ticket #1622 (autohide pager when less than 1 page to display) created by
-
LS,
In modules/kohana23_compat/config and modules/kohana23_compat/libraries there are files called pagination.php. In these files there is the auto_hide option which can be set to TRUE. As I understand, this should hide the pager if there are less than 1 pages to display.
This should be default behavior in my opinion, as the pager is useless if there are no pages to scroll to.
Unfortunately setting the option to TRUE does not produce the desired effect. The pager still shows up, even if there is only 1 page to display.
- 09:10 Ticket #1621 (Allow browsing with multiple tags + add to API) created by
-
Currently, G3 allows you to browse photos by one tag at a time. With this feature request, multiple tags are allowed to be put in as the "search criteria". For example, to search for photos containing the tags "dog" and "cat" would be "/tag/dog/tag/cat" or maybe "/tag/dog/cat". Also, this should be put into the REST API as well, so that it can be taken advantage of outside of the web app. Flickr has something like this in their API and hopefully, it's not too big of a change!
Here's an excerpt from the Flickr "flickr.photos.search" API:
tags (Optional)
A comma-delimited list of tags. Photos with one or more of the tags listed will be returned. You can exclude results that match a term by prepending it with a - character.
tag_mode (Optional)
Either 'any' for an OR combination of tags, or 'all' for an AND combination. Defaults to 'any' if not specified.
- 05:16 Milestone 3.0.1 completed
01/22/11:
- 07:09 Ticket #1620 (Copyright is out of date) closed by
- fixed: master/3.0.x: 423daa52d55a5298b461384baedc995eee09a0d1
- 07:08 Ticket #1620 (Copyright is out of date) created by
-
The copyright is still set to 2010.
01/21/11:
- 17:33 Ticket #1619 (Photos get added as albums in case only some photos are selected via ...) closed by
- fixed: master/3.0.x: 6b4ccc56ceabd5721c7ff996e01be719880564f9
- 14:38 Ticket #1619 (Photos get added as albums in case only some photos are selected via ...) created by
-
Based on report of CJ00TA:
[14:00:23] <CJ00TA> bharat: kind'a confirming this morning.. server upload is broken for me in the latest git pull... I can add via browser upload fine
[14:02:57] <+Joe7> CJ00TA: any errors logged/shown?
[14:03:13] <CJ00TA> no errors.. just shows up as a folder
[14:03:19] <CJ00TA> http://www.2000transam.com/gallery3/index.php/MyFamily/Christmas-2010?page=5
[14:03:22] <CJ00TA> last 2 items
- 13:16 Ticket #1618 (Watermark fails to upload PNG) created by
-
I'm trying to upload a small PNG as a test watermark (file attached), but get the following error:
"The watermark must be a JPG, GIF or PNG"
The file has the proper extension, and reads as PNG everywhere else. This is in the released version of 3.0.
- 08:08 Ticket #1615 (making it easier for modules to inject data into theme) closed by
- fixed
01/20/11:
- 09:15 Ticket #1617 (error: File not found: file_proxy/xxx (Cooliris Slideshow)) created by
-
Another issue with cooliris slideshow.
The problem is, if you use any special characters in the album-name
(like &) the path to the pictures can't be accessed.
I'm using latest devel release from git pulled today (build 60).
01/19/11:
- 21:46 Ticket #1616 (usability / navigation on standard theme) created by
-
on "gallery wind" the location of the navigation-buttons is inconsistent - which makes the whole a bit awkward to use.
on pages with thumbnails the buttons and pagination are on the bottom of the thumbs, whereas on pages with a single image it's above. besides the inconsistency it's also making the UI "jumping", as on pages with portrait thumbnails and/or longer titles it's farther below than on pages with landscapes only - so ideally all navigation should be placed on top of images/thumbs.
- 18:46 Ticket #1615 (making it easier for modules to inject data into theme) created by
-
<begin braindump>
as per my original post on the thread for the greydragon theme (http://gallery.menalto.com/node/91519?page=23#comment-365785), i implemented some changes to put meta:og tags into the page for facebook (and any other opengraph compatible sites). it was then suggested that this could be somehow incorporated into the theme handler, so that the theme itself could call a function, as discussed from here (http://gallery.menalto.com/node/91519?page=23#comment-365836). a module could, if needed, "inject" meta tags into the theme with, say, $theme->addmeta($property, $content), the theme could simply call $theme->meta() to compile the html output, and the module could also be able to go $theme->addns($ns, $url), and the theme could call $theme->namespaces() in the <html> tag. this could open up the power for modules to be able to manipulate the template a lot more, and also would provide g3 the ability to sanitise the content. and in the case of meta tags, enforce the addition of a namespace before you can add meta tags using that namespace. for example,
$theme->addmeta("og:title", "Gallery") could throw an exception because the module hasn't done a $theme->addns("og", "http://ogp.me/ns'") first. you could also, maybe, in some circumstances, package the namespace builder with some standard ones as well (opg, for instance, and fb's doesn't change either i don't think). and you could implement logic to only spit out html for namespaces that are actually used (i.e; modules have called addmeta() for. this could be "overridden" with a 3rd parameter of something like $force = true incase the module needs to add a namespace but it won't be used in meta tags (js, html, for example).
these sorts of things could be expanded on as g3 develops, but i think this might be a good starting point.
</braindump>
- 15:32 Ticket #1614 (Slideshow doesn't work with comma in directory name) created by
-
If there is comma in the directory name for an album then slidshow does not load the images (does not load the thumbnails either, just blank...)
Here is an example:
Works:
Directory Name: Milan Italy - Oct-2010
Doesn't work:
Directory Name: Milan, Italy - Oct-2010
Cheers,
B.
- 14:29 Ticket #1613 (can't 'server add' single files) created by
-
directories do work, if i import one an album gets created and containing files get put into it.
but if i select (a) single file(s) the module starts scanning and counts up "Scanned xx directories" infinitely even though there is not a single directory in that folder, see screenshot:
http://xchange.photing.com/data/screens/shot00537.png
01/17/11:
- 07:19 Ticket #1605 (Notify admins when there's a new version of Gallery 3 available) closed by
- fixed: Automated checking is now in. master/3.0.x: 66bb496b6c2ad9c5341644b2e303e694078374d1
- 05:48 Ticket #1612 (site_status messages are limited to 255 chars) closed by
- fixed: master/3.0.x: 84d576606d709dcccef2549fdb926d47494a876c Change the value column of the messages table from a varchar(255) to a text. Fixes #1612.
- 05:46 Ticket #1612 (site_status messages are limited to 255 chars) created by
-
This will cause problems if we use long strings (which we're going to for the gallery version check code) or if the localizations run long. Change it from a varchar(255) to a text column.
01/16/11:
- 22:27 Ticket #1610 (Random sort order breaks next/prev navigation) closed by
- fixed: master / 3.0.x: 375e3b1fa4616c77fd37764c3812f6e03b20b95d
01/15/11:
- 21:20 Ticket #1611 (All head() and admin_head() theme callbacks should return the result of ...) closed by
- fixed
- 21:18 Ticket #1611 (All head() and admin_head() theme callbacks should return the result of ...) created by
-
In 3.0 we had a pervasive bad pattern in the head() and admin_head() theme callbacks where we did not do anything with the return value from the $theme->css() and $theme->script() calls. In 3.0 this was ok because those functions never returned anything but in 3.0.1 we're giving a little more control to theme developers around combining (see #1600). This means that if we're not combining, those functions can return a <script> or <link> element that we should embed into the page.
Starting as of 5ac49d497f51a3828c1254b5024a4aa898f86530 we need to handle this return value and deal with it. All core and contrib modules should be updated for this.
- 20:35 Ticket #1557 (user manager needs pagination) closed by
- fixed: master/3.0.x: 89737c09d572efe35014e668cdd06407c2c19d62 97fc535411478f939b303c75a067b7dad9123112 00b520fffd867389b5a030ddefee9f468cad044c df802de6ae3cc0c294a1a3dc76db29ff21949b9f d511fc77adfa628b04968d153e397425e3a93358
01/14/11:
- 22:02 Ticket #1610 (Random sort order breaks next/prev navigation) created by
-
Steps to repro:
1) Add a few photos to an album
2) Choose "random" sort column (asc or desc, doesn't matter)
3) Click into first photo
--> Photo is "0 of 0". Next/prev don't work
- 21:36 Ticket #1609 (Random in JS Organize not random) created by
-
When sorting via the JS organize module the 'random' sort order is not random. Also if that option is chosen the order dropdown should be disabled.
I don't see a way to have ascending and descending randomness.
01/13/11:
- 00:21 Ticket #1608 (Provide designers/developers an easy way to turn off css/js combining ...) created by
-
Handy when you use firebug/other tool to check which rules affect a layout/style of an item and see directly in which files those rules/functions are.
01/12/11:
- 05:42 Ticket #1603 (Consider shipping a php.ini file with similar defaults to .htaccess) closed by
- fixed: master / 3.0.x: e4a43c99e421c830e569eaae6294286ed51e0ad8
- 05:23 Ticket #1490 (Full-size image does not display on screen due to auto-resize flaw) closed by
- fixed: Looks like from 228962f0e836c303174d0be6d0ff246628ea85d9 that the intent there was to do Math.round but I used Number() instead. I'll switch to Math.round() here and in $.gallery_show_full_size(). Thanks nkinkade! master/3.0.x: 7eabf6c1c27c2c0e98895f663bb2853d72976e01
- 04:50 Ticket #1597 (Provide themers with greater control over js/css combining) closed by
- duplicate: Dupe of #1600
- 02:00 Ticket #1607 (Add "Options +FollowSymLinks" to access::update_htaccess_files()) created by
-
We test for it in access::htaccess_works() but then we don't actually use it, so that causes problems:
However, some hosts don't allow FollowSymlinks? and modify it to SymlinksIfOwnersMatch?:
We should either switch entirely over to SymlinksIfOwnersMatch? or use FollowSymlinks? consistently in the generated .htaccess files.
- 01:52 Ticket #1518 (File Proxy cannot locate files if the directory name contains periods) closed by
- fixed: master/3.0.x: 9364f0d931883bb5f17f22c4003ee59256f9efb6 7f6d87166df138073d85dd5201de8b9d19bc6cd2 a5ec593c4f1468f8aa52de8bfd00c2c94cf5913f 8d5376f22ac3e7207c5f791cb0d9c2d4c6261e06
- 01:09 Ticket #1606 (Admin > Languages tables don't line up) created by
-
See screenshot:
http://awesomescreenshot.com/0df5slo16
- 01:01 Ticket #1504 (Localization code should differentiate between invalid API key and failed ...) closed by
- fixed: master/3.0.x: 049f2af1c982bb12fee6e5512e4830f63d06d343 ee53744aa73b06f262122b6236014618fe6d742c
01/11/11:
- 23:37 Ticket #1605 (Notify admins when there's a new version of Gallery 3 available) created by
-
We should have done this for the 3.0 release - sigh. Better late than never, though.
Two approaches:
1) Make a server side request to GMC to get the data.
pros: simple
cons: server might not allow outbound requests, if GMC is slow the server response might be really slow
2) Make a JS request, store the answer in a cookie.
pros: reliable.
cons: more complicated
- 23:29 Ticket #1604 (Item_Model::get_position() should call viewable() internally) closed by
- fixed: Implemented by BigMadWolf?: https://github.com/gallery/gallery3/pull/5 https://github.com/gallery/gallery3/pull/23 master/3.0.x: 0d7e951aa5f7329edb25e821de95051668789bcd 24c0b69847d4144c29e557fa654c30247e628a9c 92db7f42181f6582763e7b5c56b18b989b061e21
- 23:28 Ticket #1604 (Item_Model::get_position() should call viewable() internally) created by
-
Item_Model::get_position() does not call viewable() internally because theoretically it doesn't need to. It's a series of calls, not a single one so it's not chainable, so outside code can't easily add the viewable() restriction. That's a problem for modules like the "hide" module that wishes to override viewable() and have it come into play for get_position() calls.
Solution: refactor Item_Model::get_position() -> item::get_position() and have it call viewable() in all cases.
- 23:09 Ticket #1603 (Consider shipping a php.ini file with similar defaults to .htaccess) created by
-
See http://gallery.menalto.com/node/100175 for users who can't use .htaccess but can use php.ini
- 09:04 Ticket #1602 (Don't resize the image if it's the same size) closed by
- fixed: master / 3.0.x: 84e08a62838b0299a5daa7c9cac4be3eca6d0cb1
- 09:03 Ticket #1602 (Don't resize the image if it's the same size) created by
-
We have anti-upscaling code in gallery_graphics, but it shouldn't resize if the image is the same size as the target size, either.
- 06:26 Ticket #1601 (Minify JS/CSS as part of Gallery_View::get_combined) created by
-
It's a one-time cost for most sites.
- 06:21 Ticket #1600 (Add theme APIs for combining CSS and JS) closed by
- fixed: master/3.0.x: 5ac49d497f51a3828c1254b5024a4aa898f86530
- 05:29 Ticket #1600 (Add theme APIs for combining CSS and JS) created by
-
new API here: http://gallery.menalto.com/node/99837#comment-365212
- 03:24 Ticket #1599 (Server add: new albums should take the sort order from their parent) closed by
- fixed: master/3.0.x: 9dfb733ad7d5e7e5aa002833d52d1b8642609161
- 03:23 Ticket #1599 (Server add: new albums should take the sort order from their parent) created by
- 03:06 Ticket #1598 (Fix task should rebuild resize/thumb hierarchy if necessary) created by
- 01:50 Ticket #1597 (Provide themers with greater control over js/css combining) created by
- 01:42 Ticket #1462 (Which command not supported on Hosts) closed by
- duplicate
01/10/11:
- 23:50 Ticket #1555 (Try using "whereis" instead of "which" for broader compatibility) closed by
- fixed
- 22:55 Ticket #1596 (Detect available system locales in Admin > Settings > Languages) created by
-
If the user installs a locale that's not available, they'll get right strings but likely they'll get the wrong collation.
Related to #1566
- 22:51 Ticket #1594 (Protected image path returns with a broken login page) closed by
- fixed: doh. scratch that, the fix is in: master/3.0.x: d557b2a63e2ea424965fb53be9f6b76ad3f18015
- 22:37 Ticket #1541 (Use CSS not JS to show the overlay for the full size image) closed by
- fixed
- 22:07 Ticket #1595 (Refactor graphics::detect_toolkits() to loop over ImageMagick, ...) closed by
- fixed: master/3.0.x: 3ec0ba956dced01a97f2ee7bd943d326c42350e3 bd6bd029a7c2e0247d4da931c49f3731498cd303
- 22:06 Ticket #1595 (Refactor graphics::detect_toolkits() to loop over ImageMagick, ...) created by
-
The code there is very similar, loop over it to tighten it up a bit.
- 06:30 Ticket #1547 (Server add hangs when adding a large volume of pictures) closed by
- fixed
- 02:50 Ticket #1593 (Setting invalid paging value for tag browser ends up in Fatal error) closed by
- fixed: master / 3.0.x: fca6d1254a2aeb95bee15fea4c503e4588fc9f1b
- 02:38 Ticket #1460 (Serveradd module doesn't add subdirectories) closed by
- fixed: master/3.0.x: b7ffb0501e09878b7d95f46a2b678678e0e60fa6
01/09/11:
- 22:59 Ticket #1594 (Protected image path returns with a broken login page) created by
-
An image that is protected by permissions -eg accessible by logged in users only- will return a login page if accessed without a valid session.
The login page on the other hand is broken: the login redirects to 404 (and pages i broken designwise as well. Seems to be a path issue).
- 11:56 Ticket #1593 (Setting invalid paging value for tag browser ends up in Fatal error) created by
-
Fatal error: Call to a member function abs_url() on a non-object in..
A leftover from some copypaste code
- 10:21 Ticket #1592 (Organize delete button should not be active when nothing is selected) closed by
- fixed: master / 3.0.x: de5b06ae7442db2c7a8999c0c806997248ddb151
- 10:21 Ticket #1592 (Organize delete button should not be active when nothing is selected) created by
-
Subject says it all.
- 08:17 Ticket #1588 (Add delete support to the new Organize module) closed by
- fixed: master/3.0.x: b78a1319ae10841ff6be00d041b3d8d6967ca7a3 fc2733a2d1aa06cda3415b624aeb28e62deabb95
- 03:29 Ticket #1591 (Organize: Albums with missing thumbnails are rendered poorly) closed by
- fixed: master / 3.0.x: 4c80ed53d2a3fa3392d2da61c730b6d30de9f2be
- 03:28 Ticket #1591 (Organize: Albums with missing thumbnails are rendered poorly) created by
-
In the new organize, albums with missing thumbnails are rendered with a missing image icon which floats out of the box, and the icon is in the wrong place.
- 02:11 Ticket #1590 (Installing Gallery3 inside a directory called application, modules, themes ...) closed by
- fixed: master/3.0.x: 713bd4eb6a9bc91a244680828ce881ee8ea5f836
- 02:02 Ticket #1590 (Installing Gallery3 inside a directory called application, modules, themes ...) created by
-
gallery::find_file() improperly reads the path resulting in bad CSS and JS files.
- 01:21 Ticket #1583 (eCard style fixes) closed by
- fixed: Fixed in 7904946b54b9444e4107338f3e746d8daef9f968
- 01:09 Ticket #1577 (Photo/Album pages are not getting validated due to broken <div> tag in tag ...) closed by
- fixed: master / 3.0.x: 5e8d92552b1384d99d5fef56333deb7eb67a8f92
- 01:01 Ticket #1316 (session.use_trans_sid puts the g3sid cookie in the url) closed by
- fixed: @albataur: That's a better solution than putting it in the .htaccess -- good idea. master / 3.0.x: 92f66058d30a04681a01b886bdc652a70652cbfa 7d07190af1bda3ae1ec0e899a9997c659532ed29 That should fix it. thanks!
- 00:51 Ticket #1589 (module::install() on modules with no installer always results in version 1) closed by
- fixed: master / 3.0.x: e1e1e860cd1b19ebef491f0c0f82a3cd18e63721
- 00:51 Ticket #1589 (module::install() on modules with no installer always results in version 1) created by
-
Steps to reproduce:
1) Create a new module *without* an installer
2) In its module.info set its version to 3
3) Install it
--> Database will have version 1
01/08/11:
- 23:52 Ticket #1588 (Add delete support to the new Organize module) created by
-
The old organize supported delete, the new one should too.
- 21:01 Ticket #1587 (Organize module no longer requires REST module) closed by
- fixed: master / 3.0.x: 4fc5d50eb83f29c0a28ce16b9ff22179fd3f2c98
- 21:01 Ticket #1587 (Organize module no longer requires REST module) created by
-
Since the Organize was rewritten in JS not to use the REST module, we can do away with all the code that checks this dependency.
- 08:20 Ticket #1445 (reCAPTCHA and HTTPS) closed by
- fixed: master / 3.0.x: 7b382b363dfd3002cb1f10089c7a1e9e82eb804a
- 07:38 Ticket #1586 (Tag counts aren't updated when tags are deleted) closed by
- fixed: master / 3.0.x: 966dee8628293f78fbf9431281709ceba011d3c2
- 07:37 Ticket #1586 (Tag counts aren't updated when tags are deleted) created by
-
This is because tag count management isn't being properly handled by the model.
- 05:53 Ticket #1154 (Full screen aspect ratio on movies) closed by
- fixed
- 04:42 Ticket #1585 (Don't enable the REST module by default) closed by
- fixed: master/3.0.x: a09c9d55861420d694e174f0ea7998053f23da49
- 04:41 Ticket #1585 (Don't enable the REST module by default) created by
-
Now that the Organize module no longer uses it as of #1584, we don't need it enabled by default.
- 04:37 Ticket #1584 (Rewrite the Organize module in pure Javascript) closed by
- fixed: master/3.0.x: 8e21dda195015a3c9420553f874c10d3ebfa5dfa Complete rewrite of the organize module in Javascript using the Sencha JavaScript? library. It's got all the functionality from the Flash version except it doesn't support creating new albums or uploading photos. 90852b192970173042ac34191b12be725021897a whitespace fix. 0cd1ccfdc27b082b1f792f8d65f47f35fa5ce678 missing image 3928058ba5897eb2c6a2f3fb76664012db014a89 Fix a few small visual issues: - Let the thumb data view scroll on drag/drop - Switch the album panel to be a FitLayout? and use a title and bbar instead of nested panels. - Set the tree_panel width to be 200px to start. 79f27ea1ecefd6e0fdf725f218cc66c18b568fb4 Remove a bunch of trailing commas from arrays to make IE happy. 51d66df1924b9fb835ed741042beddce4f6e899f Switch to using Ext.Element.mask for a custom busy message that looks a little cleaner. caf454f32650e654ddf77592f4e083352a576415 Add missing images b692d55ad47842371c38c61f3c16af36d06dca3a Convert "\w-" in regexes to "\w\-" for compatibility with some versions of Chrome 10.x. 31652eae44bdd93b45d965a8288a3069e37d1934 Drag/drop improvements: - Restrict drag and drop to albums where the user has edit permissions. - Use the existing TreeDropZone? instead of making a new DropZone? to take advantage of TreeDropZone? features. - Properly use dropConfig in TreePanel?. bd5e71ba6a84b4cda484bb4e4a8a77889bb0a02d More drag/drop tweaks. - Fix a bug in the prior commit where we could no longer drag/drop in the thumb_data_view. - Change the CSS class when dropping items in the tree panel to be a check box, not a plus symbol. 3a11e0d825d1f7d2698bd5c7b6b812236c7626a3 This was left out of 31652eae44bdd93b45d965a8288a3069e37d1934. c590f881ebbb005390f6e4f8a37a6252a5796f51 single -> double quotes. 372905bd1310fc446db795661e1eb013674e5a75 Support moving an item before or after the target. 28760daaefebf802dbe28ac171ea16aef3007418 Improve IE grid compatibility by forcing a regular width/height for thumbnails and using float: left. b8124efbd8f068758e70e53cc94fb1ea6c2b9ffb Refactor generic error handling code. It still shows a pretty lame error message. Add a comment explaining the TreeLoader? preload hack. e2b0f92007eb9ef2fad994c9f8957df0bfcbeccf Keep Item_Model::scale_dimensions from upscaling. Fixes #1579. ce70669b8f09a9154723df80992ab6afe02c1d5c Visual tweaks for IE8 compatibility. 986374300191892ae5672ea545977831d7a0b807 Only refresh the tree when we move albums around. e6b3886f8f6a3a526876a80470420501bdb25612 Functional improvements: - Add support for dragging a selection box. aebcd445135648603590e2ab99f40b72ee8ed097 Swap organize_frame and organize_dialog since they were semantically reversed. organize_dialog contains the stuff that pops up in the dialog, organize_frame contains the stuff that's in the embedded iframe. 2167168f5112fe9337c544578baa51cc5aed7652 Get rid of the expando caret in front of empty folders b424cac5c5b05d2238082e986d78dfff7b18fe89 Double clicking on an album switches to that album, selects it in the tree and expands it if it's not already expanded. 33b8ec7a6264f91db2639944bc10005c2709f0e3 Add a label for the sort order 9e6e2138dfd507dbd0ce8835072b7d950855b3d4 Only mask the data view on changes, it's a little less jarring. edf2a46b0276ca86e13fcbc66ff1b4aa1edf64fb horizontally center thumbnails 84f287865e5382d7c01c11d1b518c97e8d2bd97b Don't allow moving an item into its own hierarchy. Just silently skip those sources for now. 514d5affa62f5646ecc7843a39b36d4fad3abbd5 When generating the tree, don't mark nodes with no children as a leaf because that confuses the TreeDropZone? JS into thinking that it can't ever have children. 7600e224338943dbe61372020701d87b7e503ab9 Whitespace fix. 0abd77c9e5dd0b7a5d265932490b694238323093 Fix typo. 9682b7ea6e2486c2e5dc43799ca215c51dda0baf Remove unnecessary fc6907dcfe35f2341528620ccedf2db02a30d065 Switch back to setting nodes as leaves, but fix the drop zone code to allow dropping on leaves. 600e04b58cb19c53871e60abfe4a4d9deab6dc1e Lock the drag zone if the album is not editable so that users don't start illegal drags. 0c9dbc96631a95938abfd77586de017549ee2901 Adjust CSS for IE compatibility while keeping the grid tight on non-IE. 8ece1e3a1906685055e17175a25050397dba8423 Create a custom bundle of ExtJS for organize. It's 18% smaller, but still pretty large. 24b8e9b060c77523cf557f7a8ffc94f72a7e0b42 Make the sort column combobox wider. 89597e7e703dddef8a2379f822772f9fd205d03b Add a spinner to the dialog when loading the iframe so that it's not just a blank dialog. Create separate CSS for dialog vs. frame. Don't show the Loading message for the first load.
- 04:26 Ticket #1331 (Organize Module: Refactor to update ui then update server.) closed by
- wontfix: This will be resolved with #1584. Marking as a wontfix.
- 04:26 Ticket #1532 (Gallery3 organize not working) closed by
- duplicate: This will be resolved with #1584. Marking as a duplicate.
- 04:26 Ticket #1584 (Rewrite the Organize module in pure Javascript) created by
-
The organize module uses Flash and REST, resulting in:
1) It's slow to load and render data
2) Doesn't fit with the rest of our dev model, is hard to hack on
3) The REST code tends to barf on very large requests to items_rest, and that's been a pain to fix
Rewrite it using one of the JS toolkits (like ExtJS) and see if that results in a lighter, faster, more hackable solution.
- 04:24 Ticket #1070 (Organize module uses ID for main menu link) closed by
- fixed: master / 3.0.x: edcb3b665690acc85067bc43e1900390be228a4e
- 04:18 Ticket #1579 (Item_Model::scale_dimensions shouldn't upscale) closed by
- fixed: master/3.0.x: 85ae3202886d2bd132f6cd327cc2d9f0650ca911
- 04:13 Ticket #662 (Refactor info module block so that other modules may add metadata info) closed by
- fixed: master/3.0.x: f7f6cbf04ff2b19535b0d3b9dbd5f4ab41395bfc 798c876ba1cb5b83f6cd6616b90321e9e527b864 dbff45cc91ac44f18ef02b8abdd220a2864f050f e921c3c5b5b8f963f121601d346c50a24bc0cf15 1d2e583c3177aa498abd70dde442d767efc4e99e 2e5d4a59b119fecce4f647eaa49565b024678cf9 a1e3b1ed17177cf7e0ef6b443afdea6a676f65b2 740a6531fc2ea04afa09d652dc0058698c6cfbc8 a897a9d53f7df79f55888141444a22f38665dce6 06d94065ce0919f34151da05b32642a95397044f 4756db435c1b934137f0ca2f169f74ab509ab72f
- 03:53 Ticket #1554 (G2 Import: importing 2450 users blows the task serialization code) closed by
- fixed: master / 3.0.x: c338d3138e2c93bfb219a8d32ba9110138fcf9c2 5bfb7fb96a5dc2e0bc511c998a7c055b83b2915a e86e8b8bd1d828d81080c63f9a063254145115e4
- 03:53 Ticket #1581 (G2 import fails if Gallery2 instance has no other albums but root) closed by
- fixed: master/3.0.x: f2477703faa7cd05ff1aa16da3ecef7b666bef40
01/07/11:
- 16:20 Ticket #1583 (eCard style fixes) created by
-
Fix eCard styles as discussed in http://gallery.menalto.com/node/97194?page=2#comment-364784
01/06/11:
- 11:31 Ticket #1582 (G3 Flashuploader looks like it is case-sensitive) created by
-
I'm running both Windows (XP and 7) and Linux (Debian and Ubuntu) on my computers. When using Windows, i have no problems uploading photo's to my album. When using Linux, only the photo's with a lowercase-extension could be seen in the "select items"-box.
photo.jpg -> no problem
Photo.jpg -> no problem
photo.JPG -> problem
photo.Jpg -> problem
- 07:56 Ticket #1581 (G2 import fails if Gallery2 instance has no other albums but root) created by
-
Fixed in https://github.com/Joe7/gallery3/commit/0d36b97aca3b5ed53ea3ea398ce28b0f6198e577 (sorry, not a dedicated commit)
- 05:27 Ticket #1580 (Let themes have their own tasks) created by
-
Improve task::get_definitions() to look in the theme, too.
ref: http://gallery.menalto.com/node/100079
- 05:23 Ticket #1575 (Multiple users shall not be added with the same email address) closed by
- wontfix: Tbh initially thought of self-registering users..but that might not be the case with more than a handful of G3 installs. Think I won't hesitate too much to close as wontfix.. ;)
- 05:05 Ticket #1579 (Item_Model::scale_dimensions shouldn't upscale) created by
-
Upscaling results in the browser stretching the image. Don't do this.
- 04:54 Ticket #1578 (no autodetect for reCaptcha to use HTTPS) closed by
- duplicate: Duplicate of #1445
- 04:05 Ticket #1578 (no autodetect for reCaptcha to use HTTPS) created by
-
just wondering if the reCaptcha module could autodetect to use http://api.recaptcha.net or https://api-secure.recaptcha.net without hardcoding it into /gallery3/modules/recaptcha/views/form_recaptcha.html.php
thank you!
01/05/11:
- 23:13 Ticket #1577 (Photo/Album pages are not getting validated due to broken <div> tag in tag ...) created by
-
Proposed fix in https://github.com/Joe7/gallery3/commit/ed243059fe4c297b41e62c2bcfec14a37d2d422c
- 20:57 Ticket #1576 (Inform user that password reset emails might not be sent) created by
-
Password reset form returns with a bulk "Password reset email sent" message regardless if user exists, which is good for security/antispam, but not when a real user tries to guess his username and fails w/o getting a clue about it
- 20:53 Ticket #1575 (Multiple users shall not be added with the same email address) created by
-
There is no check to ensure that a single email address can only belong to a single user.
- 12:25 Ticket #1574 ("Forget Password" options is not available to registered but not logged in ...) created by
-
The Registration works but the problem of "Forgot Password" is still there.
When user gets to the initial log in screen, there is no option to "click here if forgot password"
If i click login button or enter incorrent login info, then the link appears.
However, clicking it just opens another login screen within the first screen.
I looked around PHP pages but don't know what has to be changed.
I am thinking, (1)something has to be added to gallery3/modules/gallery/controllers/login.php page to get the "Forgot Password" link to be visible right away.
and (2), possibly some change in login_ajax.html.php page to actually ask for user ID or email to have password reset?
Now, if the permissions are set so that anyone can view albums (don't have to be a 'registered user'), then clicking on Login link will present a login box with "forgot your password" link displayed, and clicking on it will get you to a "username" form with Reset button.
01/04/11:
- 17:11 Ticket #1573 (Add port and ssl/tls protocols configuration entries to phpmailer module) created by
-
phpmailer allows the gallery 3 administrator to send emails w/o configuring an MTA. To be really useful we need to be able to specify servers using ssl and tls protocols, and systems with non-standard ports (for the former, smtp.gmail.com is one example). The module could default the port (25) and security protocol (none - that is don't set). This is supported in the phpmailer class via: $Port and $SMTPSecure properties.
- 16:49 Ticket #1572 (phpmailer corrupts eCard message) created by
-
The eCard module does not supply the initial Content-Type/boundary field to the phpmailer module; phpmailer defaults to Content-Type: text/html; charset="iso-8859-1" and html/inline encoding appears as message text (no image seen in web client; only fields, tags and code).
The correct Content-Type should be multipart/related (or multipart/alternative if text portion sent) when embedding inline images. Current encoding causes problems both for web-based email clients (such as GMail) and standalone clients (such as Thunderbird). Note: mime.php does not assign the initial Content-Type/boundary in the current coding for eCard (mime.php does not override unless you specifically tell it to), so this may need to be locked down even if phpmailer is not used.
See gallery3/troubleshooting forum post for original report (includes php-newbie's workaround also attached here):
http://gallery.menalto.com/node/99985
The workaround was tested for the password reset and eCard emails; notification has not been tested.
* Host name: dummy
* Operating system: Linux 2.6.32-27-generic
* Apache: Apache/2.2.14 (Ubuntu)
* PHP: 5.3.2-1ubuntu4.5
* MySQL: 5.1.41-3ubuntu12.8
* Server load: 0.49 0.38 0.23
* Graphics toolkit: imagemagick
* Version: 3.0 (Santa Fe)
* Albums: 31
* Photos: 588
ecard version 4, phpmailer version 1
Doug.
- 00:31 Ticket #1571 (Stabilize rebuilding thumbnails) created by
01/03/11:
- 22:14 Ticket #1570 (Status Message for comment submit) created by
-
Many users expect a success message when posting a comment. There is no message, and they send the same comment many times.
We need a Status Message after the submit.
- 19:42 Ticket #1569 (View:set_global() should take an array parameter) closed by
- fixed: Fixed by Joe7 here: https://github.com/Joe7/gallery3/commit/8295201adf948ea35f21f75801b7a8bf36c27569 https://github.com/Joe7/gallery3/commit/64f9be5fc716772ca71f4509576f2be0a3d224eb Cherrypicked into master/3.0.x: cfaa62370ecbdb3badf4ab68bbefa7cfedaea154 f364e8a96b47f0e4f674c8b36317fc80184b219a Indentation fixes in master/3.0.x: 4a882108259f9542a6c8f2ffe95c9ee0e1c102cd
- 19:37 Ticket #1569 (View:set_global() should take an array parameter) created by
-
This will help us cut down on many calls to $template->set_global() in our main viewing controllers.
- 19:15 Ticket #1568 (Description column is too short resulting in import truncation among other ...) closed by
- fixed: installer update in master/3.0.x: 8263cb023fb4fe0b6fdc9fc61b35518dcf09946e
- 19:11 Ticket #1568 (Description column is too short resulting in import truncation among other ...) created by
-
Problem:
Input validation validates description up to length of 65535 chars, but DB trimmed data over 2048 chars.
Solution:
Convert column into TEXT type. Note: The effective maximum length of a VARCHAR in MySQL 5.0.3 and later is subject to the maximum row size (65,535 bytes, which is shared among all columns) and the character set used. In contrast to CHAR, VARCHAR values are stored as a one-byte or two-byte length prefix plus data. The length prefix indicates the number of bytes in the value. A column uses one length byte if values require no more than 255 bytes, two length bytes if values may require more than 255 bytes.
- 19:01 Ticket #1567 (Increment view count is inconsistent and not centralized) closed by
- fixed: Fixed by Joe7 here: https://github.com/Joe7/gallery3/commit/1f04ac6c484d9db8aa76773f4b2116e5a8ef6799 https://github.com/Joe7/gallery3/commit/4d25744a85cde73f43c12e2105ea1f3144f72f8d Cherry-picked into master/3.0.x: 336632fea0a955d74099cd169b3178c01f250ff5 7ce902d373ac67d2267a886c18238eb53dd98093
- 18:50 Ticket #1567 (Increment view count is inconsistent and not centralized) created by
-
The albums, photos and movies controllers do it differently. They should all be doing it the way that the albums controller does, and it should be centralized in the model.
01/01/11:
- 06:50 Ticket #1485 (inconsistent "No active sidebar blocks. Add blocks" notice) closed by
- fixed: master/3.0.x: e760200eeec2f003f95072118a6cc52971c76dad
- 06:29 Ticket #1559 (Optimize Cache_Database_Driver::set() to be a single query) closed by
- fixed: master/3.0.x: 17700b805fad7a74e871366159b4fe1ae4c2d883 869bba5e132ceb960b72744fc3ebad5e6af14439 440597356d8719bdc6733d2d86aaef5f86d05a1e 66fd8c7518ab71466aca72d20fb7bcd5f374af26 fda92507964b9521b632a97c9e343b4639a657f7 affbc28876901058810d9fd26a8f7795084f2efd
- 00:06 Ticket #1566 (Missing locales cause image toolkits to fail to process special chars (eg: ...) created by
-
G3 decides what locale you should have in Gallery_I18n and then uses that locale where possible. But if you don't have that locale installed, then functions like escapeshellcmd don't know how to process special multibyte characters so it strips them.
Steps to reproduce:
1) install de_AT locale
2) use German as your default language
3) Crete an album called "Park-Güell"
4) Try to add a photo inside this album
--> see an error in the logs like "error: chmod() [<a href='function.chmod'>function.chmod</a>]: No such file or directory"
references:
http://bugs.php.net/bug.php?id=45132
http://gallery.menalto.com/node/99460
Workaround:
- install the locale that Gallery wants
12/31/10:
- 22:55 Ticket #1565 (Album Passwords) created by
-
It would be nice to show albums but not enter them. So you could have an album called "clients' and everyone could see the list of albums/thumbnails, but you cannot enter the individual albums unless you have a password for one of them.
It's just like G2 passwords--you can assign passwords to individual albums. The client hits the album and logs in.
Needing people to create an account is too cumbersome. My clients just want to log into their album, not have a full G3 experience by creating an account.
As it is now, we're stuck using htaccess files.
- 22:42 Ticket #1564 (Meta Data Option: "image number") created by
-
It would really be nice to have a Meta Data option like this:
*Display only image number in albums only:
This is the meta data: "Images: 63"
Or some combination, but always with the option to turn everything off except the number of images in an album.
- 22:37 Ticket #1563 (Wrong Post--please delete) closed by
- invalid
- 22:32 Ticket #1563 (Wrong Post--please delete) created by
-
I've been active beta testing and writing instructions for greydragon theme in the greydragon forum, and this topic has come up several times:
A module to open the main image in overlay--like shadowbox does--but directly from the thumbnail page. We have decided that having this option would greatly simplify clicks and navigation. The module would work like this:
(1) Only works when clicking on thumbnails in an album, not albums--duh.
(2) When in an album, clicking on a thumbnail image will open the main image in overlay mode. Click the image again, and it would close.
(3) Why does this make navigation easier? Because when you are in the thumbnails page, you can see all of the thumbnails and click any thumbnail for the original image in overlay mode. Click it again, and it goes away--without going to new pages, thus negating back buttons and inner album navigation menus.
More explanation:
(1) Shadowbox opens the overlay after the secondary image. That is, it will not open the original image, or any image, when you click on the thumbnail.
---
Put another way, it's function is the last downstream: 1. Click the thumbnail 2. Get your preview image (not the original); 3.click on the preview image and shadowbox opens the overlay.
To return to the thumbnail: 1. Close the shadowbox overlay; 2. Now you are at the preview image; 3. Navigate back to thumbnail using navigation toolbar or browser back button.
---
(2) We would like the overlay to open at the image thumbnail level. That is, once you are at the thumbnails, clicking a thumbnail will open the actual image in overlay mode. This takes one unnecessary step out of the equation.
(3) In the case people need an intermediary image before the full sized image, shadowbox and the current operations will work fine.
Here is a link to a screen capture showing exactly how it would work:
http://www.dwdallam.com/shared/G3overlay/
Thanks you and I really hope someone can do this.
- 22:20 Ticket #1562 (Upload: Multiple Folder) created by
-
The upload aspect of G3 is rather nice. However, it is lacking in that you can only do one folder at a time, then you must wait for each file to upload, wash and repeat. That means if you have 50 photos in 50 different directories, you must upload each one individually--instead of selecting multiple files, and then after all of the selections are made, choose to upload.
Request: Allow multiple files from multiple directories, then allow upload of all files.
12/29/10:
- 20:02 Ticket #1351 (admin login dialog stays up after login) closed by
- fixed: master / 3.0.x: dd6da5e2333023895a4a76786910f4bdf7e395c8
- 19:33 Ticket #1561 (Stray comma in JS breaks IE) closed by
- fixed: IE can't handle the stray comma. master / 3.0.x: 3e117fc2b46f1fc1cb8388486e156312d9f7fde5
- 19:26 Ticket #1561 (Stray comma in JS breaks IE) created by
-
$("#g-add-tag-form input:text").autocomplete( url, { max: 30, multiple: true, multipleSeparator: ',', cacheLength: 1, selectFirst: false, } ); - 07:11 Ticket #1560 (Use db::expr instead of "New Database_Expression") closed by
- fixed: master / 3.0.x: b42fcb9cda4dafdb9db86770f54965b3fb2fc7ab
- 05:57 Ticket #1560 (Use db::expr instead of "New Database_Expression") created by
-
It looks cleaner.
12/28/10:
- 20:06 Ticket #1559 (Optimize Cache_Database_Driver::set() to be a single query) created by
-
Right now we do two queries, one to see if the row exists and a second one to insert the row. Instead, let's take advantage of MySQL's "ON DUPLICATE UPDATE" feature to update the row if it already exists.
12/27/10:
- 07:35 Ticket #1531 (IE6 is missing JSON) closed by
- duplicate: Dupe of #1351
- 07:09 Ticket #1506 (Title of random block) closed by
- fixed: master / 3.0.x: 2d4d6133188b3b0052cce803d7f96b63b78af91f d0e78fc5cf5671d69bd815dd1aff9041616be3f2
- 06:23 Ticket #1558 (My gallery is really sloooooooooooow for some reason now) created by
-
I have no other signicant DB(s) on mysql.
My gallery was running pretty quickly, but now it is slow as molasses. I have 18,000 pictures and it was much faster, now mysql is using a bunch of CPU.
I ran a mysqltuner and had to increase the following to make it happy.
query_cache_limit = 180M
query_cache_size = 30M
tmp_table_size = 320M
max_heap_table_size = 320M
thread_cache_size = 4
key_buffer_size = 140M
Thing picked up slightly but it is still bad
These warnings remain:
Temporary table size is already large - reduce result set size
Reduce your SELECT DISTINCT queries without LIMIT clauses
My entire gallery database is only 65MB.
of which caches.MYD is 31M, caches.MYI is 9, and exif_records is 9M
phpmyadmin has the following complaints
Innodb_buffer_pool_reads 2,169 The number of logical reads that InnoDB could not satisfy from buffer pool and had to do a single-page read.
Handler_read_rnd 2,524
The number of requests to read a row based on a fixed position. This is high if you are doing a lot of queries that require sorting of the result. You probably have a lot of queries that require MySQL to scan whole tables or you have joins that don't use keys properly.
Handler_read_rnd_next 214 M
The number of requests to read the next row in the data file. This is high if you are doing a lot of table scans. Generally this suggests that your tables are not properly indexed or that your queries are not written to take advantage of the indexes you have.
Created_tmp_disk_tables 2,222
The number of temporary tables on disk created automatically by the server while executing statements. If Created_tmp_disk_tables is big, you may want to increase the tmp_table_size value to cause temporary tables to be memory-based instead of disk-based.
Opened_tables 822
The number of tables that have been opened. If opened tables is big, your table cache value is probably too small.
Table_locks_waited 158
The number of times that a table lock could not be acquired immediately and a wait was needed. If this is high, and you have performance problems, you should first optimize your queries, and then either split your table or tables or use replication.
The runtime is: 0 days, 1 hours, 25 minutes and 29 seconds
The gallery in question is at http://www.ecybernard.com/gallery3
822 temp tables in less than 1.5 hours, are the temp tables not being erased??
Also the tuning perl scripts says I have 2k temp tables on disk and 4k tables total. (4,000 tables What The Heck.)
12/26/10:
- 09:35 Ticket #1557 (user manager needs pagination) created by
-
user manager needs pagination, because in some cases are thousands of users
- 09:32 Ticket #1556 (expire inactive users) created by
-
a feature to automatically delete inactive users for a year or so
