Timeline


and .

09/09/10:

12:40 Ticket #1354 (rotating the last photo of an album page (any page) hides the "next/last" ...) created by kangbooboo

as the title says (and no i'm not going to go solve it in forums if u close it "because i reported 2 other bugs" ;p)

it's very easy to reproduce just find an album with a picture that is horizontal and click option=>rotate 90 (any direction), the image will cover next and last buttons.

reloading the page fixes it but it's rather annoying

ff4b4, webkitkpart 4.5.1 (i suppose most other browsers too)

05:22 Ticket #968 (notification module batch processing) closed by bharat
duplicate: Duplicate of #1190 (fixed for 3.0)
05:19 Ticket #1109 (Could not kept logged in) closed by bharat
worksforme
05:19 Ticket #1030 (Kohana_404_Exception [ Page Not Found ]:) closed by bharat
worksforme: This is a very old bug; I suspect that it's no longer valid with the latest code.
05:18 Ticket #1046 (Email API missing good default for From address) closed by bharat
duplicate: Duplicate of #1216 (fixed for 3.0)
05:17 Ticket #668 (task dialogs should gracefully handle server-side error conditions) closed by bharat
duplicate: Duplicate of #1270 (fixed for 3.0)
05:15 Ticket #1077 (Main menu out of sync with context menu - Photo View) closed by bharat
fixed: We did this at some point in the 3.0 cycle.
05:13 Ticket #944 (Full-sized photo is not rotated until refreshing) closed by bharat
duplicate: Duplicate of #1317 (fixed)
05:11 Ticket #964 (upload progress 0 of N when uploading new pictures) closed by bharat
fixed: Implemented in db769b76ab7b7ed54579225fca836defc7afbd11
05:09 Ticket #1304 (Illegal character in combined javascript) closed by bharat
worksforme: Ok, some theories here: 1) Your files are mangled on disk. The last file in the combined JS bundle is modules/comment/js/comment.js so take a look at it. I don't think this is the case because if it were, it would happen all the time 2) Your combined bundles are mangled in the database. You can look for files with tag "<javascript>" in your caches table. You can check that out with this SQL: […] That's not complete though because there are some gzipped bundles as well. Investigating them is a little harder. Their tags are "<javascript>,<gzip>" and that's tougher to sort out. You'll need to check your headers to see if the bundle is coming back gzipped -- the odds are high that it is. In that case you'll need to extract that column, gzdecode it (http://php.net/manual/en/function.gzdecode.php) and see if the data is intact. I doubt that this is the problem because again if it were, the problem would happen all the time. 3) Your Apache2 has some module that's interfering with us sending back gzipped data. It may be tinkering with the Content-Length header or taking some other action that would result in the server trying to send a few extra bytes of data back. You may be able to detect this by snooping your network traffic to see if at the end of the gzipped block there's a little extra content in plain text, or if the headers are not what you'd expect. 4) You've got some proxy in the way that doesn't deal with gzipped data very well. Very old proxies have issues with gzipped data. I'm leaning towards #3 or #4 here. Now it may be possible that we can work around this in our code, but without knowing what the real problem is I don't see anything that we're doing wrong. I'm going to close this as "worksforme" for now, but if you can answer any of the above questions and/or reliably reproduce this please reopen the ticket.
04:12 Ticket #1352 (g2 gallery import fails with white page) closed by bharat
fixed: Fixed in fe3dd6b55d4a820a2b33de5a883c2f64112cfbd4
04:06 Ticket #1351 (admin login dialog stays up after login) closed by bharat
worksforme: Not enough information here to debug this issue, and I can't reproduce this. I'm going to close this as invalid. Please reopen if you can provide enough info for us to repro this. Since you have had several issues (as I see in #1350 and #1352), I suggest you start in the forums and let us discuss the problem until we find the actual bug.
04:05 Ticket #1350 (after initial install, page display loops and cause firefox to stop ...) closed by bharat
worksforme: Not enough information here to debug this issue, and I can't reproduce this. I'm going to close this as invalid. Please reopen if you can provide enough info for us to repro this. Since you have had several issues (as I see in #1351 and #1352), I suggest you start in the forums and let us discuss the problem until we find the actual bug.
04:00 Ticket #1353 (You can't upgrade modules via admin/modules) closed by bharat
fixed: Fixed in cbb6967405569606de3b67e1f1dcde2ed8d6bb03
03:38 Ticket #1189 (3rd party modules can make the upgrader loop) closed by bharat
fixed
03:33 Ticket #1353 (You can't upgrade modules via admin/modules) created by bharat

Scenario: you download an unofficial module and install it. Then an upgrade comes along and you replace your existing code with the new code. At that point, you have to go to the upgrader and upgrade all your modules at once (probably ok, but might not be what you want). But that's a weird experience that's outside our regular admin theme, and I think that most people will consider it an aspect of upgrading the whole Gallery, not just an individual module.

I don't want to have two wholly separate interfaces for upgrading. However it's not intuitive at all as it stands currently.

I suggest that we put up a site status box saying "Some of your modules need an upgrade!" and provide a list of modules and a link to the upgrader.

02:58 Ticket #1352 (g2 gallery import fails with white page) created by kangbooboo

ensured g2 module and comment modules are loaded
ensured g2 directory is fully readable
specified the embed.php path to the g2 import module
clicked save

loads http://tibere.tzib.net/gallery/index.php/admin/g2_import/save white empty page, no html. php reports no single error.

reloading the page cause a CSRF error

02:34 Ticket #1351 (admin login dialog stays up after login) created by kangbooboo

logging in after install as admin, the admin dialog stays up and i don't appear to get logged in

however reloading the page, i can see i'm actually logged in. somehow the redirection didn't work out. my javascript is enabled, no "noscript" etc. using firefox 4b4

02:33 Ticket #1350 (after initial install, page display loops and cause firefox to stop ...) created by kangbooboo

after install firefox display:
"the page isn't redirecting properly"

clearing the session cookie "gsid3" and reloading fixes the issue (or closing/reopening the browser)

but.. this shouldn't happen rly, check this cookie :p

09/08/10:

08:54 Ticket #1349 ("su" function feature request) created by libove

It would be nice to have a UNIX "su"-like function whereby an administrator, or the owner of any sub-gallery, could "su" temporarily to any other user (if administrator) or to any user to whom the sub-gallery owner had granted permissions (if not administrator), and access the gallery with the permissions of that su'd user, then later "log out" back up to the sub-gallery owner or administrator as whom they had been logged in to originally.

From a privacy perspective, the administrator function is easier, because all administrators can always take over any user account within a gallery.

The sub-gallery owner su function would need to be a bit more limited, allowing the (real) user to access only that subset of content which both he and the su'd other user would be able to access. So this might need to be broken in to two possible enhancements.

This would effect the lost G2 "view as guest" functionality (because the administrator or any sub-gallery owner could always "su" to guest/anonymous), and would provide more granular "What will this look like to <user X>" for those gallery owners who have large user populations and (as G3 enforces) complex Group setups.

Thanks,
Jay

07:54 Ticket #1344 (More clearly explain what happens to deleted users' items) closed by bharat
fixed
07:22 Ticket #1348 (Removing multiple dependent modules results in incorrect dependency ...) created by libove

Stock Gallery3 RC2 installation, go to administer modules, UN-check both RSS and Slide Show, and click Update.
You will get a warning that Slide Show depends on RSS, which is unnecessary because if the operation was treated as atomic then the dependency check would occur on the to-be-new current list of modules, which would no longer include Slide Show.
Fix might be to perform a complete dependency check, once, on a computed list of modules which will be there at the end of the whole operation, instead of for each change occurring.

05:24 Ticket #1347 (REST item resources should show file sizes) closed by bharat
fixed: Fixed in 4ba93b7cfc2889dc7cef6729681dd779451f90bf
05:22 Ticket #1347 (REST item resources should show file sizes) created by bharat

It's convenient for 3rd parties if we say how large in bytes the thumb, resize and full size images are.

05:07 Ticket #1209 (Spurious error message: "Ask your server administrator to enable ...) closed by bharat
worksforme: In every case that I've seen so far, this issue has been caused by one of the following: 1) An Apache2 configuration problem 2) Accessing the site via a different vhost that doesn't have the right settings 3) Missing "Options +FollowSymLinks?" which was added recently. I can't reproduce this. I am going to close this bug (again). Please reopen it if you can reproduce the issue!
04:53 Ticket #1130 (Policy/default permissions for each group) closed by bharat
duplicate: Even though this came first, I'm going to close it as a dupe of #1346 where I've aggregated all the various topics that have shown up so far.
04:51 Ticket #1346 (Redesign permissions to be more flexible/powerful) created by bharat

But don't sacrifice simplicity. Consider using roles instead of groups. Here are some proposals:

Romain LE DISEZ:
http://marc.info/?l=gallery-devel&m=127914512101444&w=1

gillux:
http://gallery.menalto.com/node/91765#comment-341746

butch42:
http://gallery.menalto.com/node/91765#comment-352892

04:47 Ticket #1343 (.htaccess can block robots.txt) closed by bharat
fixed: Fixed in 9c721c4da6cbd57c9b60142215ada984c867f59d
04:31 Ticket #1345 (Add Macedonian) closed by bharat
fixed: Fixed in 00c1100d9d6f717b2c8d16600ae978a13b3798fd
04:30 Ticket #1345 (Add Macedonian) created by bharat

Per: http://gallery.menalto.com/node/97873

04:16 Ticket #1344 (More clearly explain what happens to deleted users' items) created by bharat

When we delete a user, we should scan to see how many items he has and put up a big warning saying "Bob has 50 photos!". We should also show the photo/album count in the Admin > Users list so that it's obvious which users are relevant when it's cleanup time.

After we delete a user who owns photos/albums, we should reparent those items to the admin user (I believe this happens, from an inspection of gallery_event::user_deleted).

04:06 Ticket #1334 (next/previous buttons not working correctly on items imported from g2 to ...) closed by bharat
fixed: Got it! I managed to reproduce this issue with my own G2 import. Turns out that any imported album that has a descending sort order is busted unless you reset the sort order. Fixed in ab880120e69b27bdcfed07d3b0729108326b335d
01:54 Ticket #1332 (Organize module: deleting item which was current before panel open ...) closed by tnalmdal
fixed: Create a setLocation javascript callback which is called everytime with the full url of the current album(non-REST). When the dialog is closed the window location is set to this value and the page gets loaded appropriately. commit: http://github.com/gallery/gallery3/commit/b6fa33faf789749f4de3f4eadf8832748372c980

09/07/10:

12:12 Ticket #1343 (.htaccess can block robots.txt) created by meulie

The .htaccess coming with Gallery3 suggests enabling the under-mentioned code-block. However, if you do so, anyone requesting robots.txt gets a 403 error instead of robots.txt

# Increase security by uncommenting this block. It keeps browsers
# from seeing support files that they shouldn't have access to. We
# comment this out because Apache2 requires some minor configuration
# in order for you to use it. You must specify "AllowOverride? Limit"
# in your Apache2 config file before you uncomment this block or
# you'll get an "Internal Server Error".
#
# <FilesMatch? "(\.(class|fla|inc|sql|txt|gitignore)|(README|LICENSE))$">
# Order allow,deny
# </FilesMatch>

07:53 Ticket #1313 (Titles of pictures containig a ' do not display thumbnail) closed by bharat
worksforme: I can't reproduce this with the latest code, and I'm preeeetty sure I fixed this after RC 2. I'm going to close this as "worksforme" but if anybody can repro this with the latest code please reopen the ticket and give me steps to reproduce it.
07:35 Ticket #1339 (Tag Suggestion Delay causes input errors) closed by bharat
fixed: Fixed in d398651c080c18e4f1bf623548091465dac1d528 -- we no longer force select the first item.
06:18 Ticket #1342 (Redirect the user to the requested admin page, when logging-in) closed by bharat
fixed: I read it very carefully, and I think that I fixed it :-) You were missing something in your report, which was causing you to be unable to reproduce the problem. To reproduce (before my fix): 1) Go to http://example.com/gallery3/index.php/admin/modules 2) Log out. Now you're at http://example.com/gallery3/index.php/gallery3/index.php 3) Fail to notice the url doubling and change your url to: http://example.com/gallery3/index.php/gallery3/index.php/admin/modules 4) Log in as admin 5) Wind up at the root album Since I can't reproduce this problem any other way, and the fix I committed prevent step 2 from happening, I'm marking this as fixed. If you can still reproduce the problem after this fix, please reopen with steps to reproduce. thanks!
05:45 Ticket #1342 (Redirect the user to the requested admin page, when logging-in) reopened by mamouneyya
Ooh, good. Actually, this solves the first issue I wrote about in my comment on this commit: http://github.com/gallery/gallery3/commit/32d18920680ee63dc75c3a2b710ef805b31c127c#comments However, the enhancement I filled here is different. Please read the ticket summery carefully :D
05:14 Ticket #1342 (Redirect the user to the requested admin page, when logging-in) closed by bharat
fixed
04:30 Ticket #1342 (Redirect the user to the requested admin page, when logging-in) created by mamouneyya

After some recent commit, Gallery no more redirects you to the requested admin page after your login. Instead it redirects you to the home page.

Steps to reproduce:
1. Open your Gallery and logout
2. Go directly to http://YourGallery3.com/admin/modules
3. Login using your admin account
--> After successful authentication, Gallery will redirects you to the home page and not the modules admin page

02:28 Ticket #1341 (REST code should provide a web_url) closed by bharat
fixed: Fiexd in 2f810ec12624eefa3eb47ad7174dbbe03936135d
02:28 Ticket #1341 (REST code should provide a web_url) created by bharat

For ease of shifting between web and REST, we should provide a web_url in the item resource with the url to the HTML version of the item.

Ref: http://gallery.menalto.com/node/97865

09/06/10:

23:21 Ticket #1287 (Mails from Notification module use wrong language) closed by bharat
fixed: Fixed in cc399bf4f07fd7060536f442373a1e9c0ea4a5aa
22:12 Ticket #1340 (Options menu bounce!) created by pfreed

It is possible to get into an apparent loop in the display of the options menu. The menu will repeatedly display and collapse, and it is impossible to click on it to make it stop. It appears that this happens when the cursor is moved faster than the menu, and the rising "options" menu line comes to rest under the new cursor location. (It may be that it can also occur under other conditions; for instance, it may be enough for the options line to pass under the cursor.) Given the right conditions, this appears to create an infinite loop. Moving the mouse off of the photo will make it stop, but it can start up again when the mouse is returned to the photo.

Things that make it stop:
- Clicking on the options line of another photo or album.
- Moving the cursor to the top of a photo -- above the highest point reached by the unfurling options menu -- and waiting there till the bouncing stops.

I know this description is a bit squirrelly -- it's hard to describe this without waving my hands about and pointing. :-) Let me know if you need more detail, or perhaps an mpeg.

22:02 Ticket #1339 (Tag Suggestion Delay causes input errors) created by pfreed

If I type in tags by hand, I often "overtype" the suggestions. The result is that I may type in a new tag and hit the comma key while the suggestion is still displaying the previously entered tag.

Unfortunately, hitting the comma causes the suggested tag to replace whatever was just typed. This sometimes results in my having two or three of the same tags on the line before I look up and see what has happened.

Several possible fixes exist. While I wouldn't presume to suggest the proper answer, here are my thoughts (for whatever they may be worth). It may be that some combination of these would be useful to implement.

- Provide and option to turn off tag suggestions. I'd hate to do this, since they are awfully useful. But it's an option.

- Recognize that a tag already exists on the line, and do not suggest it again.

- Before replacing a typed tag, verify that the suggestion is valid. If it does not match the leading characters of the entry, drop the suggestion or try again.

- Clear the old suggestion as soon any character is typed after a comma.

- Use "enter" to accept a suggestion, but _not_ comma.

- Tell users to slow down and wait for the suggestion before hitting comma. (This is what I'm doing now. :-)

There are probably other possibilities as well.

Thanks for an excellent product.

21:17 Ticket #1270 (Add retry logic to the task framework) closed by bharat
fixed
19:41 Ticket #1338 (Race condition on creating the vars cache results in "Duplicate entry" log ...) closed by bharat
fixed: Fixed in b3b6021b0a70979a1084111ae43c1170a7592b37
19:40 Ticket #1338 (Race condition on creating the vars cache results in "Duplicate entry" log ...) created by bharat

In some edge cases when we blow away the vars cache and let it get rebuilt on demand we hit a race condition where two separate requests try to rebuild it at the same time and the 2nd one throws a "Duplicate entry" exception:

Database_Exception [ 44 ]: #1062: Duplicate entry 'gallery-_cache' for key 'module_name' [ INSERT INTO g3vars
(module_name, name, value)

We should trap that and turn it into a log error, but keep going.

18:38 Ticket #1337 (CLI installer fails with PHP Warning: implode(): Invalid arguments) closed by bharat
fixed: Fixed in 4a941829716df412b493d35907e65acc35527583
18:37 Ticket #1337 (CLI installer fails with PHP Warning: implode(): Invalid arguments) created by bharat

http://gallery.menalto.com/gallery_3.0_rc2_feedback?page=3#comment-352757

You can't implode a string. Bug introduced in 86681eebf7ee2bf28b12fd12ee6a5fe70bc36d0a back in 9/2009 -- not many people must use the CLI installer.

16:22 Ticket #1326 ('tags navigation' / 'drilldown filter') closed by tnalmdal
duplicate: Duplicate of #1152
05:00 Ticket #1336 (New language: Setswana) closed by bharat
fixed: The only locales I could find for Setswana were "tn_ZA" which I think is Setswana for South Africa. I went ahead and added this in 46b30ce949d6371bc3d2bcfe42221c599c7a85e3
04:59 Ticket #1336 (New language: Setswana) created by bharat

ref: http://gallery.menalto.com/node/97840

04:30 Ticket #1335 (Gallery3 permissions won't work without the FollowSymLinks Apache2 Option) closed by bharat
fixed: Fixed in ca0c3b3e7f154ffceee944049247e15cf0190e48 by adding "Options +FollowSymLinks?" to both access::htaccess_works() as well as the rewrite template in gallery3/.htaccess
04:29 Ticket #1335 (Gallery3 permissions won't work without the FollowSymLinks Apache2 Option) created by bharat

Steps to repro:
1) Adjust Apache2 config and specify "Options -FollowSymLinks? -SymLinksIfOwnerMatch?" for your gallery3 dir
2) Edit Permissions
--> See the "Oh no! Your server needs a configuration change in order for you to hide photos!" error message

ref: http://gallery.menalto.com/node/97791

09/05/10:

10:40 Ticket #1334 (next/previous buttons not working correctly on items imported from g2 to ...) created by james_mcd

Just imported http://jamesmcdonald.id.au/gallery/ latest G2 version to g3 @ http://jamesmcdonald.id.au/g3/index.php/house_progress/bathroom/IMGP0333

When clicking on previous / next the buttons jump from a low picture number to a high and vice/versa without going to the next photo.

Tried in both Chrome and Firefox under Ubuntu 10.04

I'm hosted on dreamhost.

Host name: mekon
Operating system: Linux 2.6.32.8-grsec-2.1.14-modsign-xeon-64
Apache: Unknown
PHP: 5.2.14
MySQL: 5.1.39-log
Server load: 1.30 1.93 1.98
Version: 3.0 RC2 (Santa Fe)
Albums: 160
Photos: 4711

Grabbed the latest version of Gallery3 from git (http://github.com/gallery/gallery3/zipball/master)

And upgraded from G3.0 RC2 to the above mentioned git version (38)

And same behaviour is evident.

Originally reopened #1091 but was recommended I create a new bug.

05:46 Ticket #1091 (next/previous buttons not working correctly on items imported from g2 to ...) closed by bharat
fixed: @james_mcd: this bug is pretty old; please open a new one if you can reproduce this issue on the latest version of Gallery3 from git (http://github.com/gallery/gallery3/zipball/master). If you can repro it, please file a ticket against the 3.0 milestone.
03:29 Ticket #1091 (next/previous buttons not working correctly on items imported from g2 to ...) reopened by james_mcd
Just imported to http://jamesmcdonald.id.au/gallery/ latest G2 version to g3 http://jamesmcdonald.id.au/g3/index.php/house_progress/bathroom/IMGP0333 Having this same issue as mentioned above. Tried in both Chrome and Firefox under Ubuntu 10.04 I'm hosted on dreamhost. Host name: mekon Operating system: Linux 2.6.32.8-grsec-2.1.14-modsign-xeon-64 Apache: Unknown PHP: 5.2.14 MySQL: 5.1.39-log Server load: 1.30 1.93 1.98 Version: 3.0 RC2 (Santa Fe) Albums: 160 Photos: 4711

09/04/10:

22:56 Ticket #1317 (Full size dimensions not updated properly after rotation) closed by bharat
fixed: Fixed in c51b6ab38d7f16d64127fd3a73df38166a698f0f
21:09 Ticket #1329 (Broken login) closed by bharat
invalid: Your PHP is configured to use session.use_trans_sid which is changing the Gallery 3 urls out from underneath us. That feature is going to break a lot of stuff, and this is just one of them. You'll need to to turn it off in your php configuration. http://www.google.com/search?q=session.use_trans_sid
21:04 Ticket #1319 (No graphics toolkits + open_basedir == put up a warning) closed by bharat
invalid: We do have a warning. Closing as "invalid"
20:41 Ticket #1307 (Suggestion: Add a Gallery "Title" that is always present in RSS feeds, ...) closed by bharat
fixed: Implemented in db75ac642a6ff62e814929af99e7c9af4d492706. We now use the root album's title as the site title.

09/03/10:

01:01 Ticket #778 (Replace the move dialog with Organize) closed by tnalmdal
duplicate: Duplicate of #1204

09/02/10:

23:33 Ticket #1333 (add feature to watermark new movie thumbnails) created by fcfi

Please consider adding an option to create a watermark on new video thumbnails so that the video thumbnails are visibly different from the photo thumbnails. (as can be accomplished in Gallery2 under "FFMPEG Settings" by use of a checkbox entitled "Watermark new movie thumbnails")

Thank you.

18:45 Ticket #1332 (Organize module: deleting item which was current before panel open ...) created by serged7

Organize module: deleting item which was current before panel open produces DANG when organize panel is closed

18:43 Ticket #1331 (Organize Module: Refactor to update ui then update server.) created by serged7

Organize Module: when item is deleted object content is refreshed and loose current position in the hierarchy

18:36 Ticket #1330 (Organize Module: provide option to change form background) created by serged7

Organize Module: provide option to change form/object background to custom (flash and css)

15:27 Ticket #1329 (Broken login) created by jtlb

Whenever i logout and want to log back in as another user, i can't do it without manually go back to the root of my gallery instalation.
The "bug" seems to be related to the presence of "g3sid=" in the url. it can be removed safely but logs re-login.

11:49 Ticket #1328 (Create a set of module categories) created by dmolavi

From http://gallery.menalto.com/node/97735 , creating module categories would make module management, and the display of said modules on gallerymodules.com, much easier for the end user. I propose the following list of categories (essentially lifted from G2):
- Toolkits (IM, GD, etc)
- Authentication
- Commerce
- Display
- Import
- Export
- Extra Data
- Remote Interfaces
- Sidebar Blocks

10:07 Ticket #1327 (Multiple Set-Cookie headers) created by gertschi83

Steps to reproduce
Remove the g3sid Cookie from your browser. Then take a look at the HTTP Response headers (e.g. with Firefox and the addon Live HTTP headers) when you visit your gallery.

What I expected to see
The first HTTP Response should contain one Set-Cookie header with g3sid. After that the browser should attach the g3sid to every HTTP Request. Thus, the server's HTTP Response doesn't have to include the Set-Cookie header anymore. Sending the Set-Cookie header is only necessary when the g3sid changes (after successful login?) or when the browser doesn't send the g3sid within its request.

What I saw instead
The HTTP response always include at least one Set-Cookie header, even though the browser already sent the same g3sid with its request. More disturbingly there are always two (in some cases even four) Set-Cookie headers for g3sid. Of course the browser uses only the last one and ignores all others.

https://gallery.example.com/
GET / HTTP/1.1
Host: gallery.example.com
Cookie: g3sid=d975b267bd26a2be36d7f4939445a5bc73abacef%7Ejujromokad0t8v4dgnes6gdto3
HTTP/1.1 200 OK
Date: Thu, 02 Sep 2010 09:33:49 GMT
Server: Apache/2.2
Set-Cookie: g3sid=jujromokad0t8v4dgnes6gdto3; expires=Thu, 09-Sep-2010 09:33:49 GMT; path=/; secure; HttpOnly
Set-Cookie: g3sid=d975b267bd26a2be36d7f4939445a5bc73abacef%7Ejujromokad0t8v4dgnes6gdto3; expires=Thu, 09-Sep-2010 09:33:49 GMT; path=/; secure; httponly

If you look closely you can see that the g3sid from the first Set-Cookie header is part of the second one. I'm not sure how and why this happens, but it certainly doesn't seem right.

08:40 Ticket #1326 ('tags navigation' / 'drilldown filter') created by markus7701

i would love to see an alternative version of the "popular tags"-box with a bit more functionality..

say i got tags:
- animals
- plants
- fish
- mammals
- monkey
- tree

and click on 'animals' it should only offer me tags that are contained in images which also contain 'animals', so it would be:
- animals
- fish
- mammals
- monkey

clicking on 'mammals' leaving me with:
- animals
- mammals
- monkey

(all of course assuming the tags are correctly set per image..)

07:57 Ticket #1056 (Bare-bones login page) closed by bharat
fixed
05:20 Ticket #1325 (Rename table can fail in upgrade path resulting in unupgradeable G3) closed by bharat
fixed: Fixed in 70c8572ea1b421458241b9b3b1cc85cb6bf35057
05:19 Ticket #1325 (Rename table can fail in upgrade path resulting in unupgradeable G3) created by bharat

The "RENAME TABLE" operation is not idempotent so if a cosmic ray hits an upgrade and it fails exactly between the "RENAME TABLE" operation and the point where we update the module version, then we get into a situation where all subsequent upgrade attempts will fail because we'll keep retrying the rename, but the table is already renamed and so the SQL bombs.

We should make RENAME TABLE operations idempotent in upgrade code.

See: http://gallery.menalto.com/node/97687#new

05:00 Ticket #1324 (After an image upload fails, you can't upload any more) closed by bharat
fixed: Fixed in 80e9fcaf47af6a041db385f18b0be00c15708da7
04:58 Ticket #1324 (After an image upload fails, you can't upload any more) created by bharat

Steps to reproduce:
1) On your desktop, take a text file and rename it to be "foo.jpg"
2) Upload foo.jpg and some other images
3) See that foo.jpg is marked broken, but the rest succeed
4) Click "select files" and try picking some new files from the dialog
--> nothing happens

I think the problem is that we're removing the broken file from the queue the wrong way.

04:23 Ticket #1323 (REST: item resource doesn't support "start" and "num" on GET requests) closed by bharat
invalid: Oops, I wasn't thinking clearly. This ticket was in response to http://gallery.menalto.com/node/97741 and they were talking about the members field, not about a collection resource. We don't want to paginate the members field; it'll cause trouble when we try to do things like reorder the collection.
04:09 Ticket #1323 (REST: item resource doesn't support "start" and "num" on GET requests) created by bharat

We shouldn't just blindly return all the item results, but instead we should force pagination and only return a subset. Following convention in comment_rest and tag_rest, we should default start to 0 and num to 10 unless otherwise specified.

This will probably break the Organize module, so that'll need to paginate.

09/01/10:

04:01 Ticket #1216 (Mail configuration settings (from, reply-to) should be configurable) closed by tnalmdal
fixed: Fixed in commits http://bit.ly/dx10NT & http://bit.ly/ccWauj Move the values that were in the sendmail config file and store them as gallery module variables. Requires a version number bump to 37

08/31/10:

05:20 Ticket #1268 (Simple uploader fails if flash not installed) closed by bharat
fixed
05:06 Ticket #1320 (Organize should use selectedId param and select the item chosen) closed by tnalmdal
fixed: Fixed on commit: 866f8ee
03:50 Ticket #1211 (Avoid spamming the logs with ".album.jpg not found" msgs) closed by bharat
fixed: Fixed in d5ebcb91ad8401df8a393f84ade82150467dbf33

08/30/10:

04:51 Ticket #1182 (Routing is parsed incorrectly for form edit|add urls) closed by bharat
invalid: Closing as "invalid". Reopen if you think we should deal with this.
04:51 Ticket #1322 (G2 Import: wrong urls in G2->G3 redirect maps when G2 isn't using rewrite) closed by bharat
fixed: Fixed in 3707d4e94fc46fb3b92c399111ef6fc7f351aaba
04:50 Ticket #1322 (G2 Import: wrong urls in G2->G3 redirect maps when G2 isn't using rewrite) created by bharat

If you disable the rewrite module in G2, then the URL that G3 suggests in the admin interface for the RewriteBase? (at the bottom of the page) is blank, and the values that we put into the g2_g3_maps table have server relative urls, instead of being trimmed down to just main.php. The redirects won't work right for those folks unless they modify their database to edit the g2_url column to remove all text before "main.php" in the g2_url column.

04:30 Ticket #1282 (G2 import re-copies already imported comments) closed by bharat
fixed
04:16 Ticket #1318 (Wind theme shouldn't show the breadcrumb for the root album) closed by bharat
fixed
04:16 Ticket #1315 (Theme CSS and JS should go after module CSS/JS) closed by bharat
fixed: Fixed in ab598b2931dbff1165e66bc271e6b49166fe0a7e
03:04 Ticket #1284 (A string in Organize module can't be translated.) closed by bharat
fixed: This was a bug in our localization scanner. I've fixed it and about 10 other places where we were doing it wrong in 2c717b18d36f8d4ae6b7b94beeb0fd99a2984c9a
02:56 Ticket #1321 (Localization scanner does not find concatenated strings) closed by bharat
fixed: Fixed in 0879a26e1c5a326c51064c412234b3fa540ed5a5 by having it put a message in the logs when we discover such a string.
02:55 Ticket #1321 (Localization scanner does not find concatenated strings) created by bharat

If you have a string in your code like t("foo" . "bar") the l10n_scanner won't find it.

08/29/10:

23:40 Ticket #1302 (Simple Uploader dialog buttons) closed by bharat
fixed
23:30 Ticket #1204 (Move dialog looks teeeerrrible) closed by bharat
fixed
23:29 Ticket #1320 (Organize should use selectedId param and select the item chosen) created by bharat

For ticket #1204 we replaced the Move dialog with the Organize module. Right now we pass a "selectedId" param into the Flex code to tell it that after opening the dialog we should force the item we want to move to start off in a selected state. I was unable to get that to work though.

23:27 Ticket #1312 (favicon in wrong place) closed by bharat
fixed
22:56 Ticket #1314 (Photo count does not recurse) closed by bharat
invalid: By default, G3 doesn't show counts in the sidebar. This must be either a theme or an unofficial module issue. Closing as "invalid". Please reopen if this bug exists in an official module. PS: for whichever code generates that count, they should use $item->descendant_count() instead of $item->children_count() to get the total number of descendants vs. just the immediate number.
19:57 Ticket #1319 (No graphics toolkits + open_basedir == put up a warning) created by bharat

If we can't detect any graphics toolkits and you have an open_basedir set and it doesn't include some of our basic paths, perhaps we should put an informational message up on admin/graphics to let people know to start looking there?

19:11 Ticket #1174 (Organize flex app sends back full entity for RESTful changes) closed by bharat
fixed: Fixed by regenerating SWF in de93507d1387aa2245801ce9279b6b8985b1a250
18:54 Ticket #1174 (Organize flex app sends back full entity for RESTful changes) reopened by bharat
18:45 Ticket #1318 (Wind theme shouldn't show the breadcrumb for the root album) created by bharat

We have some code in there to check it, but the controller passes in an iterator and when we call empty() on that it always returns false. We should pass in an array instead.

17:37 Ticket #1241 (Missing flash files in Organize) closed by tnalmdal
worksforme: Is this still an issue. I haven't had it happen to me in a while. It might be related to we weren't doing any Adobe Flash version checking, but now that we are, it shouldn't be an issue, except if we don't have the right version numbers in the organize dialog. I'm going to close and someone can reopen if they have problems.
17:33 Ticket #1174 (Organize flex app sends back full entity for RESTful changes) closed by tnalmdal
fixed: Fixed in commits: http://bit.ly/d3DzGY and http://github.com/gallery/gallery3-flex/commit/fa19cdf930a5209264c08aac8fda9e7534d236da Created a GalleryEntity? class to better manage the state of the various properties of the entity returned in a REST request
05:40 Ticket #1317 (Full size dimensions not updated properly after rotation) created by bharat

Steps to reproduce:
1) Upload rectangular picture
2) Click through to resize
3) Rotate it 90 deg.
4) Click on the image to view the full size
5) --> full size has aspect ratio of image from before rotation

See also: http://gallery.menalto.com/node/97635

05:34 Ticket #1316 (session.use_trans_sid puts the g3sid cookie in the url) created by bharat

We should disallow this by putting:

php_flag session.use_trans_sid Off

in php.ini. Deferring to 3.1 since that's a risky change.

04:02 Ticket #1315 (Theme CSS and JS should go after module CSS/JS) created by bharat

If we let the module CSS come last, then themes can't override it. And they should.

see: http://gallery.menalto.com/node/97662

08/26/10:

20:08 Ticket #1314 (Photo count does not recurse) created by dmolavi

When viewing the root of a g3 install, the number of photos as reported in the sidebar only counts the number of albums (and photos, if any) in the root album, not the entire site. Similarly, diving into albums, the photo count does not report the number of photos in all of the subalbums as well.

05:01 Ticket #1187 (Permissions UI does not make it clear that you're editing parent ...) closed by bharat
fixed: Fixed in b1275ab39d5b14c337ad9956e2ac5c5dcded8936
04:46 Ticket #1295 (Double clicking on dialog links causes a 2nd dialog to appear) closed by bharat
fixed: Fixed in 7bee93390d7f3bdbf68ec1632a9f623f70eee2ef
04:41 Ticket #1197 (Adding photos via Organize does nothing) closed by bharat
worksforme: Can no longer reproduce. Closing for now.
02:42 Ticket #1313 (Titles of pictures containig a ' do not display thumbnail) created by jsweatt

Hello,

I'm new to this so please go easy on me. :)

I installed the latest version of Gallery, downloaded yesterday. Thought that everything was working fine, but for some reason 3 of the 12 pictures that I uploaded do not have thumbnails. I have tried deleting the pictures and re-uploading them. That did not work so I re-edited the pictures with a different editor to make sure that there was not a problem with the saved format, I've had that happen before. All with no avail. The last 3 pictures will not show thumbnails. If you click on then you do see the image full size, but no thumbnail.

Here is all the technical info I could find.

* Version: 3.0 RC2 (Santa Fe)
* Albums: 1
* Photos: 12

# Operating system: Linux 2.6.18-8.el5
# Apache: Unknown
# PHP: 5.2.6
# MySQL: 5.0.81-community
# Server load: 0.65 0.77 0.84

Found the problem. The titles of the pictures that did not have thumbnails contained a "'" in the title. Remove the ' and the thumbnail works. Not sure if this is a bug or not.

Someone thought it was a bug, so here it is.

[quote=nivekiam]It also sounds like a bug that was squashed ages ago. First thing to do before reporting any bug is to upgrade to the latest code (RC2 ain't it). Was this a totally fresh install of G3? Did you upgrade from a previous version and were the photos already there? Did you import these from G2 or were they uploaded from the simple uploader or from the server add method?

Get the latest code here:
http://github.com/gallery/gallery3/zipball/master

Upgrade instructions here:
http://codex.gallery2.org/Gallery3:Upgrading

Then see if you can replicate this. If you can, see if using the Rescue module fixes things (it ships with the latest code)
http://codex.gallery2.org/Gallery3:Modules:rescue

Like Gallery? Like the support? [url=http://gallery.sourceforge.net/donate.php?donate_tag=nivekiam]Donate[/url] now!!! See G2 live [url=http://photos.kevinnehls.com]here[/url][/quote]

This was a clean install of code downloaded from the site yesterday morning! One would think that the site would have the latest and greatest version posted, and that users would not be expected to chase down the latest through a maze of sites.

08/25/10:

21:22 Ticket #1312 (favicon in wrong place) created by inposure

Everytime Gallery is updated, so is the favicon, since favicon.ico resides in lib/images rather in the default root directory.

I would like to have my own favicon without having to go through the hassle of reinstating it with every new update of Gallery.

Suggestion: either respect an existing favicon in the root directory, or drop the special lib/images/favicon.ico completely.

18:11 Ticket #339 (G2 Import rotated images have a rotated thumb and an un-rotated original) closed by dmolavi
fixed: I believe that https://sourceforge.net/apps/trac/gallery/ticket/1274 resolves this ticket.
18:10 Ticket #658 (rotation of images during import) closed by dmolavi
duplicate: Closing. Duplicate of https://sourceforge.net/apps/trac/gallery/ticket/1274 which has been closed.
17:20 Ticket #1286 (Mails from Notification module contain useless notifications) closed by bharat
fixed
06:04 Ticket #797 (Cannot upload watermark image) closed by bharat
worksforme: I believe that this was fixed with the fix for #1230. Your code change line numbers indicate that you have the code before that fix went in. I'm going to close this as worksforme, but if you can reproduce it with the latest code please reopen the bug.

08/24/10:

15:40 Ticket #1271 (Comments Editing Doesn't work) closed by bharat
duplicate
15:40 Ticket #1271 (Comments Editing Doesn't work) reopened by bharat
02:32 Ticket #1271 (Comments Editing Doesn't work) closed by ocbroadband
fixed: NM, obviously, the comments table.
02:31 Ticket #1271 (Comments Editing Doesn't work) reopened by ocbroadband

08/23/10:

19:09 Ticket #1311 (creating albums: internet address is superfluous when directory name is ...) created by elf_too

When creating an album, 3 fields are presented to the user: title, directory name, and internet address. The final two are automatically created from the first one.

This is very nice, provided that G3's defaults work for you. But it's a chore if your own conventions are different. If I disagree with G3's defaults even in a very small way, then I have to make all those changes manually, twice.

Or, I make them once and then I have to copy all those changes and paste into the internet address field. :( Imagine having to create dozens of albums like that one day. Also, there's no way I could delegate all this process to someone else - it's onerous enough for me already, another person would simply forget what to do at some point.

I feel having both directory name and internet address offered by default when creating an album is superfluous. Just offer one of them (e.g. directory name), and make the other field (internet address) identical with the one offered. If the user wants to change the internet address for some reason, give that as an option later on, or hide it on the pop-up somehow.

I mean, in 99% of cases, the user would like to specify a directory name, and would just let the "internet address" be the same. How often do you want the directory and the URL different? Not very often. So, if it's something rarely used, don't put it in the foreground - it creates more problems than it solves, as seen in this bug report.

TLDR: When a new album is created, offer just the Title and the Directory Name fields. The Internet Address should be an option on the Edit Album page.

G3 is moving in the right direction, but keep in mind: if you decide to help the user the way you already do (auto-creating the directory name from the title, for example), then it's actually a bad thing to put too many options on the front row. Give only a few options, and hide the rest in the settings somewhere.

18:58 Ticket #1310 (space character replacement in titles should be configurable) created by elf_too

The directory name and internet address are automatically created from the title, the dash character "-" replacing the space. This is nice, but there's no obvious way to change the character. Not everyone uses the dash to replace the spaces - e.g. I use underscore "_".

When I create lots of albums, this gets cumbersome really quick. Imagine having to replace dashes with underscores many times for each album. :(

The character used to replace space should be defined somewhere in the settings, so that users can easily change it.

12:07 Ticket #1309 (Parameterize SMTP settings) created by ranger187

#13 {main}
2010-08-19 00:36:00 -07:00 --- error: @todo notification_event::item_updated() failed
2010-08-19 00:36:00 -07:00 --- error: @todo SEND_MAIL_FAILED
#0 E:\XXXXXX\modules\notification\helpers\notification.php(218): Sendmail_Core->send()
#1 E:\XXXXXX\modules\notification\helpers\notification.php(110): notification::_notify(Array, Object(Item_Model), '<html>? <head>...', Object(SafeString?))
#2 E:\XXXXXX\modules\notification\helpers\notification_event.php(26): notification::send_item_updated(Object(Item_Model), Object(Item_Model))
#3 [internal function]: notification_event_Core::item_updated(Object(Item_Model), Object(Item_Model))
#4 E:\XXXXXX\modules\gallery\helpers\module.php(374): call_user_func_array(Array, Array)

Seems it's either not using PHP Sendmail or something. Because I can send mail out. So I'm saying it's the actual php file sending the notifications. I think it needs to be configurable... As I personally don't see an area to adjust the settings. Once I catch some sleep I'll look into it more....

We need one of the developers to tell us how it's handled and sent and where/what we can mess with. I'll start mucking with some php files. Thank god for VMware. ;)

=================================

After looking at \modules\notification\helpers\notification.php it's not windows compatible to me. Is it calling functions?

In G2, I know if you went to Admin Options > General Settings > Email you could configure it. WITH THIS, you can't.... This is a developer side issue.

By default, even in G2, it can't send mail. IF YOU CAN SPECIFY A SMTP SERVER IT DOES SEND

To
FAKE@…

date Thu, Aug 19, 2010 at 3:52 AM
subject Gallery Email Test
mailed-by qmta04.westchester.pa.mail.comcast.net

hide details 3:52 AM (0 minutes ago)

This is a test email from Gallery2

=================================

It works ONLY if I specify a host for the smtp server.

So it's a bug/feature missing that was IN G2 and NOT G3...

You shouldn't need ANY SMTP MAILSERVER installed at all as your host (comcast) , (hostgator) will provide with with this. Thus NOTHING on the server needs setup. So if we could do what a I asked above...

Allow the end user to:

1. Specify a smtp mailserver.
2. specify a login/password (if needed)
3. Send a test email out

I truly feel this issue would go buh bye......

Let me know. I will guinea pig this. Write me a custom php etc and I'll try them..... Or TELL me how to troubleshoot it specifically if you guys have a special way of doing that...I'm off for the weekend..... So don't expect any support until Monday, unless I get bored. ;)

08:13 Ticket #1271 (Comments Editing Doesn't work) closed by bharat
duplicate: Ah, ok. guest_email is missing. I think you're getting bitten by http://sourceforge.net/apps/trac/gallery/ticket/1161 which we fixed in RC2. But you imported with RC1, so you've got the bug. There are two fixes: 1) Throw out your data and reimport 2) Find any comments in your database with a missing guest_email column and put a value in there. I think this SQL will do it: "UPDATE comments SET guest_email = 'unknown@…' WHERE guest_email IS NULL" Closing as duplicate. Reopen if I'm wrong.
00:45 Ticket #1308 (Enable linking to YouTube video (and any public media storage)) created by peterkr333

My webhost does not allow streaming of videos from their servers. The only way for me to offer viewing of videos in Gallery 3 would be to have a link to videos on public media storage servers like YouTube?.

08/22/10:

20:02 Ticket #1306 (Creating a more flexible interface to the recaptcha module) closed by bharat
fixed
03:57 Ticket #1307 (Suggestion: Add a Gallery "Title" that is always present in RSS feeds, ...) created by mark_headrick

Copy of what I posted here: http://gallery.menalto.com/node/97562

I'm not sure if this is something to be added to the Theme Options page or something within the Admin or Advanced settings or an RSS module settings page.. No where can you specify the "Title" of the complete gallery. The various pages, views, and RSS feeds would then contain this "Title".

For example, the "Recent Updates" RSS feed is just titled "Recent Updates" which is going to be the same as every other Gallery 3 installation. I've gone into the \modules\rss\views\feed.mrss.php file and hard-coded my Gallery's title there.

<title><?= html::clean("My Gallery's Title - ".$feed->title) ?></title>

It's easy enough to add the Gallery's Title to the Theme's code so that it's present when viewing any album or photo (I think this should be a default behavior); however, I don't think the average user should need to modify the RSS module's code in this way.

Thanks,
Mark H.

00:45 Ticket #1306 (Creating a more flexible interface to the recaptcha module) created by dmolavi

As it exists right now, module developers who wish to implement recaptcha in their module are forced to either:
1) Overload recaptcha_event with your own MY_recaptcha_event, or

2) Edit recaptcha_event directly.

Recaptcha needs to be more flexible to enable it's use in -contrib developed modules without the developers having to muck around in core code.

08/21/10:

23:53 Ticket #1305 (Organize shows a blank window (and "FORBIDDEN" in the logs)) closed by bharat
fixed
23:51 Ticket #1305 (Organize shows a blank window (and "FORBIDDEN" in the logs)) created by bharat

In some configurations, the organize feature fails to load any data. Thanks to jrforbes in #gallery, it turns out the problem is that we were accidentally sending our custom headers using underscores instead of hyphens and that breaks some proxies.

23:45 Ticket #1271 (Comments Editing Doesn't work) reopened by ocbroadband
Steps 1) Install fresh copy of G3. 2) Perform import of gallery 2 pictures into Gallery 3 that include comments. 3) Once imported into G3, attempt to manipulate the comments via admin->Content->Comments->Approved. 4) Select either Delete/Spam/Disapprove, and none of the options work. In this case, there are actually multiple displays of the same comment.
23:26 Ticket #1304 (Illegal character in combined javascript) created by inposure

Chrome does not render Gallery 3 pages correctly due to an illegal character in the combined javascript generated by Gallery 3, see attachments.

When copying the character for analysis, it seems to be a strange combination of U+001F UNIT SEPARATOR, U+008B and U+0008 BACKSPACE.

22:11 Ticket #973 (Use reasonable standard size / dimension of videos / movies) closed by bharat
fixed: Fixed in c6a28a93ddfcf692e67342707d2b4a41dcf19fe5 -- don't take movies if we don't have ffmpeg.
22:10 Ticket #1303 (Handle the case if ffmpeg moves or is deleted) closed by bharat
fixed: Fixed in 4a01aaddc9fa443ca9e022666078d8a2d0578d8a
22:10 Ticket #1303 (Handle the case if ffmpeg moves or is deleted) created by bharat

Steps to reproduce:
1) Install ffmpeg
2) Install G3
3) Upload a movie (all works ok)
4) Delete or move ffmpeg
5) Upload a movie
--> fail (haven't verified this so don't know the exact fail case, but we'll try to exec a binary that doesn't exist)

21:14 Ticket #1167 (Large photos bork the gallery display) closed by bharat
duplicate: This is a dupe of https://sourceforge.net/apps/trac/gallery/ticket/1283 What's happening is that the graphics operation is failing, possibly because your server is limiting your CPU or imagemagick is running out of memory. The Kohana graphics toolkit that we rely on does not do great error handling and as a result you wind up with an invalid image and we can't easily detect it. Rebuilding may not work because if the rebuild failed once, it can fail again. The workaround for now is to use the "rebuild items" module: http://codex.gallery2.org/Gallery3:Modules:rebuild_items We'll fix this properly in 3.1 -- marking this as a dupe for now.
21:10 Ticket #1271 (Comments Editing Doesn't work) closed by bharat
worksforme: Can't reproduce; missing details. Closing as "works for me". Please reopen if you can provide steps to reproduce, thanks!
21:07 Ticket #1217 (Insecure cookie over HTTPS) closed by bharat
fixed
03:23 Ticket #1302 (Simple Uploader dialog buttons) created by nivekiam

1) 'Cancel All' should be 'Cancel all' to conform to our capitalization standards

2) Once the upload starts the 'Done' button should be grayed out until the process is actually complete. We have the 'Cancel all' button to cancel uploads. Pressing 'Done' while the uploads are still working closes the dialog and cancels the uploads. But may confuse users who thing they've selected the photos, they start uploading and go to press 'Done' thinking it'll finish in the background.

08/20/10:

14:50 Ticket #1301 (Enhancement request - Amazon S3 support / External storage support) created by bromide-g3

A particular integration with S3 and Gallery2 is discussed here:

http://gallery.menalto.com/node/77816

Additionally, from this wiki page:

http://codex.gallery2.org/Gallery3:About

There is a link to a feature list spreadsheet that shows that Amazon S3 integration was a feature considered for Gallery3.

If you assume that the person deploying the system can set up a virtual filesystem such as s3fs or a mounted NAS drive I think that this could be a fairly easy feature to implement; I believe all it would require is the ability to prepend the correct domain name and path to each image.

Another issue might be ensuring that the tmp folder can be placed at its own path outside of the remote filesystem due to possible latency issues in writing to the remote server. It might also be prudent, if things don't already work this way internally, to save an uploaded image to the tmp folder and queue it up for transfer to the proper storage location for better usability and error handling.

08/19/10:

11:38 Ticket #265 (Rotate images based on EXIF rotation information) closed by dmolavi
fixed: The autorotate module is now in gallery3-contrib on git.
06:58 Ticket #1300 (Fix timezone issues) created by galbit

Gallery interprets the capture date from the Exif header using the server time zone. That is only correct if camera and server happen to use the same time zone, which is not very likely under travel and/or if your server is in a remote place.

It was discussed in http://gallery.menalto.com/node/49336, and more recently in in http://gallery.menalto.com/node/97359, where bharat suggested to file a ticket for G3 as well.

Fixing this might solve #602 as well, depending on how it is done.

04:43 Ticket #1299 (server_add does not work for video files when ffmpeg is not installed) created by rlparadise

In order for the server_add to save a movie item, it goes through a set of logic that will cause an exception to be thrown IFF ffmpeg is not installed.

I would recommend considering a default width/height for video files so that ffmpeg is not required for a server_add of video files. More details on this idea and the context for where code changes could be made can be found at:

http://gallery.menalto.com/node/97453

08/18/10:

05:33 Ticket #1298 (Organize fails with "Remote server error: Contact your gallery ...) closed by bharat
fixed: Fixed in 387d30da764b152a9bb40ac6db7d9ce5282aa7a3
05:30 Ticket #1298 (Organize fails with "Remote server error: Contact your gallery ...) created by bharat

If your web setup is has a series of worker servers behind a single canonical hostname, Organize fails with "Remote server error: Contact your gallery administrator"

Behind the scenes, Flash requires any network requests to go back to the original host. In round robin setups, we stick in the name of the server, not the name of the host in the http headers. Flash asks the canonical host for crossdomain, it doesn't exist, Organize code falls over.

08/16/10:

17:38 Ticket #1297 (Improve Search for partial matches) created by orbisvicis

All my images are named "FileName?_XResxYRes.ext" and titled "FileName? XRes_YRes" (the default), so that might be part of the problem:

Some example searches highlighting the problem

  • "a" -> returns nothing. I expect to see any filename,description,or tag containing an "a"
  • I have an image named "388_1920x1200.jpg" and titled "388 1920x1200".
    • Search for "388" returns nothing.
    • Search for "388_1920x1200" returns the image -> good, full name search returns only the image.
    • Search for "388 1920x1200" returns any 1920x1200 image -> good, boolean "or" search working
    • Search for "1920x1200" returns any 1920x1200 image.
    • Search for "1920" returns nothing.

In general it seems that searching for a portion of a word doesn't work. That could be a problem if I have an image title "CoolTiteAtNight?" and want to search for "night".
I don't know why the search for "388" didn't work.

06:41 Ticket #1296 ([Uploader] Absolute URIs break http -> https proxies) created by orbisvicis

On linux, in order to convince flash to trust my self-signed certificate, I use stunnel as an http->https proxy to gallery. The problem is that some of the absolute URIs returned by gallery3 break the proxy, for example:

$base_url = ((empty($_SERVER['HTTPS']) OR $_SERVER['HTTPS'] ===
'off') ? 'http' : 'https').'://'.$site_domain;

(note: I'm not sure at all that specifically this line actually causes any problems)

Assuming my stunnel configuration is as so:

[https]
accept=127.0.0.1:11111
connect=my.website.net:myport
sslVersion=TLSv1

While browsing at http://127.0.0.1:11111, my browser will be redirected to https://127.0.0.1:11111. It then proceeds to encrypt the data, which is then doubly-encrypted by stunnel, so that my apache logs see:

Invalid method in request \x16\x03\x01    # ... this is a TLS Hello
Sequence

Why does this only happen on certain transfers during the flash upload (Say 5 in every 100 images)? I can say for sure that when browsing a gallery it occurs for each an every image. I'm not sure how firefox manages to recover from these errors, but I notice that browsing over stunnel tends to be 1.5-2x times slower.

Several ideas:

  • Is it really necessary to specify the protocol? Why not just return an absolute URL such as /gallery3/index.php?ImageName?...
  • Maybe use an X_HTTP_ONLY header to disallow SSL chatter?

08/15/10:

09:00 Ticket #1285 (Sendmail uses wrong encoding) closed by bharat
fixed: Fixed in ff1d8aea2f2805f85ce3cc7e4079d04fb9f1bac4
07:53 Ticket #1295 (Double clicking on dialog links causes a 2nd dialog to appear) created by bharat

Steps to reproduce:
1) Log in
2) Find any dialog menu, like Add > Add Photos
3) Double click the menu option
--> See the dialog appear, then scroll down and see another copy of the form pasted in the bottom of the page

Every time we click, it adds a new data <div> but it only binds one of them into the dialog itself. We should prevent double clicks.

07:18 Ticket #1294 ([flash uploader] retry failed transfers) created by orbisvicis

Use case:
Say I'm uploading 200+ images via the flash uploader, and by happenstance say 5 images fail to fully transfer (Get cut off, etc).
Shouldn't the flash uploader try to re-upload these failed images/transfers?
Otherwise its kinda'of a pain to hunt through 200+ entries in that small static flash window looking for failed transfers, then manually retry each.

Details
There probably should be more than one retry for each failed transfer. Say for example:
uploading 500+
50 fail
retry, uploading 50
5 fail
retry, uploading 5
1 fails
etc..

Also, its probably a good idea to inform the user which of the images terminally failed to upload, so the user doesn't have to go hunt through the miniscule flash window result log.

07:01 Ticket #1293 (Organize can't handle the new "data" resource) closed by bharat
fixed: Ah, I figured it out. Fixed in d2c59740b11c0764967410b233f3b01fc3dab85d

08/14/10:

22:50 Ticket #1293 (Organize can't handle the new "data" resource) created by bharat

We now return a data resource implemented by data_rest that points to the thumbnail, resize or full size of a protected image. The organize module needs to request those using the REST protocol and send a X-Gallery-Request-Key param.

Steps to repro:
1) Lock down the view perms on an album with photos in it
2) Organize that album (as admin is fine)
--> broken thumbnails

22:48 Ticket #1292 (REST items resource exposes the ids of members that users can't see) closed by bharat
fixed: Fixed in b562751fdb2ae8aab3a344e84176ea03381ca04c
22:47 Ticket #1292 (REST items resource exposes the ids of members that users can't see) created by bharat

Steps to reproduce:
1) Create root albums A and B, user A in group A.
2) Remove view permissions for album B from group A
3) Log in as user A and to to album A
4) Run Organize Album
--> blank results

The REST call to the root is returning the existence of album B, and then the Organize code is trying to request B and getting a 403, and then crapping out.

21:56 Ticket #1289 (Missing access_cache rows can break a variety of functions) closed by bharat
fixed: Fixed in d9f8c8a295b760bb5b858c96f1658d50c321bd01
13:07 Ticket #797 (Cannot upload watermark image) reopened by vor0nwe
I'm having a similar issue, except that I couldn't upload any type of image for my watermarks. (Running Gallery3 RC2) After a bit of judicious spelunking in the Gallery3 code looking for 'validation' and 'invalid_type', I ended up in gallery3/modules/forge/libraries/Form_Upload.php, near line 139. I haven't looked at it very thoroughly, but it would appear that that upload form accepts or rejects the image based on the MIME-type sent by the browser(!). A very quick and REALLY dirty workaround for me was to change the rule to accept everything by default, upload the new watermark, and revert the code change. So I changed line 139 of gallery3/modules/forge/libraries/Form_Upload.php from // Allow nothing by default $allow = FALSE; to $allow = TRUE; // TODO: Revert this dirty hack!!! Then the transparent PNG was accepted without a hitch. Could someone adjust that test so that it'll accept a file based on it actually being a valid file format? Or, if that's too difficult, by file extension?

08/13/10:

06:18 Ticket #1291 (Create item REST API request results in a HTTP/1.1 500 Internal Server ...) closed by bharat
wontfix: "jhead" is not an official module. Please disable that module and ask the original author in the forums to update it for the latest version of Gallery 3. Looks like it's using the old K2.3 APIs.

08/12/10:

17:45 Ticket #1291 (Create item REST API request results in a HTTP/1.1 500 Internal Server ...) created by xkjq

Item and metadata is created successfully but the result is a HTTP/1.1 500 Internal Server Error.

Log file contains:

2010-08-12 10:36:44 -07:00 --- error: Kohana_PHP_Exception [ 1 ]: Call to undefined method Kohana::log()
/home/gallery3/modules/jhead/helpers/jhead_event.php [ 44 ]
#0 /home/gallery3/system/core/Event.php(208): Kohana_PHP_Exception_Core::shutdown_handler(NULL)
#1 /home/gallery3/system/core/Kohana.php(549): Event_Core::run(Array, Array)
#2 [internal function]: Kohana_Core::shutdown('system.shutdown')
#3 {main}

Error page is attached.

09:22 Ticket #1290 (Allow creation of multiple tags per REST request.) created by xkjq

It would be useful to be able to create/request multiple tags in a single API request.

Forum thread.

05:56 Ticket #1289 (Missing access_cache rows can break a variety of functions) created by bharat

If there's a bug and uploads go wrong, we can wind up without access_cache rows. This is going to be rare, but it's a pain when it happens. We should extend the Fix task to find missing access_cache rows and add them.

04:03 Ticket #974 (G3 Protected Videos do not play the first time the page is visited) closed by bharat
fixed
04:02 Ticket #974 (G3 Protected Videos do not play the first time the page is visited) reopened by bharat

08/11/10:

15:04 Ticket #1288 (Dangling <li> element in admin.html.php) closed by tnalmdal
fixed: Add a containing <ul> element for the footer on the admin page. Also respect the "show credits" variable setting. Commit: c90996341aa309a0c585392427561831890767c7
15:00 Ticket #1288 (Dangling <li> element in admin.html.php) created by tnalmdal

Just noticed that there is no containing <ul> around the credits on the admin.html page.

12:16 Ticket #1287 (Mails from Notification module use wrong language) created by gertschi83

Steps to reproduce

  • Enable the Notification module
  • Add German as an additional language
  • Set your user's default language to English
  • Set Gallery's default language to German
  • Create a new album named Foo
  • Enable notifications for album Foo
  • Upload one image to album Foo

What I expected to see
The received email from the Notification module should be completly in English since the user's default language is English.

What I saw instead
The subject line of the email is in English. However, the email content is in German. My tests show that the content is always in G3's default language.

12:01 Ticket #1286 (Mails from Notification module contain useless notifications) created by gertschi83

Steps to reproduce

  • Enable the Notification module
  • Create a new album named Foo
  • Enable notifications for album Foo
  • Upload one image to album Foo

What I expected to see
The received email should contain the following text: Photo "Bar" added to "Foo"

What I saw instead
The email contains the following notifications:

  • Photo "Bar" updated
  • Photo "Bar" updated
  • Photo "Bar" updated
  • Photo "Bar" added to "Foo"

I'm not sure why I get those three notifications about 'Photo "Bar" updated'. However, I don't think that this is an intended behaviour.

11:45 Ticket #1285 (Sendmail uses wrong encoding) created by gertschi83

Steps to reproduce
Change the default language to German and reset your password. You will receive an email where not every character is readable. At least Thunderbird shows "Passwort zurücksetzen anfordern" instead of "Passwort zurücksetzen anfordern".

Cause
The Content-Type is set to ISO-8859-1 instead of UTF-8.

Solution
Change the Content-Type header in the following files:

./modules/notification/helpers/notification.php
./modules/user/controllers/password.php
./modules/gallery/controllers/user_profile.php

The correct way to set the header is:

->header("Content-Type", "text/html; charset=UTF-8")

08/10/10:

04:59 Ticket #1284 (A string in Organize module can't be translated.) created by engineer9

Please see the attached file.

Does it cause by the separate lines (line 54 and 55) in modules/organize/helpers/organize_event.php file?

03:56 Ticket #1283 (Image toolkit errors are ignored) created by bharat

The graphics code is expecting the image processing code to throw an exception when there's a problem, but instead it returns a status code which we ignore.

graphics::generate()

   155      try {
   ...
   171          foreach (self::_get_rules($target) as $rule) {
   172            $args = array($working_file, $output_file, unserialize($rule->args));
   173            call_user_func_array($rule->operation, $args);
   174            $working_file = $output_file;
   175          }
   176        }
   ...
   192      } catch (Exception $e) {
   193        // Something went wrong rebuilding the image.  Leave it dirty and move on.
   194        // @todo we should handle this better.
   195        Kohana_Log::add("error", "Caught exception rebuilding image: {$item->title}\n" .
   196                    $e->getMessage() . "\n" . $e->getTraceAsString());
   197        throw $e;
   198      }

gallery_graphics::resize()

    63        $image = Image::factory($input_file)
    64          ->resize($options["width"], $options["height"], $options["master"])
    65          ->quality(module::get_var("gallery", "image_quality"));
    66        if (graphics::can("sharpen")) {
    67          $image->sharpen(module::get_var("gallery", "image_sharpen"));
    68        }
    69        $image->save($output_file);

Image::save()

   375          public function save($new_image = FALSE, $chmod = 0644, $keep_actions = FALSE, $background = NULL)
   376          {
   ...
   405                  return $status;
   406          }

We need to check the $status and properly handle it in all cases.

Note: See TracTimeline for information about the timeline view.