Timeline


and .

08/22/10:

20:02 Ticket #1306 (Creating a more flexible interface to the recaptcha module) closed by bharat
fixed
03:57 Ticket #1307 (Suggestion: Add a Gallery "Title" that is always present in RSS feeds, ...) created by mark_headrick

Copy of what I posted here: http://gallery.menalto.com/node/97562

I'm not sure if this is something to be added to the Theme Options page or something within the Admin or Advanced settings or an RSS module settings page.. No where can you specify the "Title" of the complete gallery. The various pages, views, and RSS feeds would then contain this "Title".

For example, the "Recent Updates" RSS feed is just titled "Recent Updates" which is going to be the same as every other Gallery 3 installation. I've gone into the \modules\rss\views\feed.mrss.php file and hard-coded my Gallery's title there.

<title><?= html::clean("My Gallery's Title - ".$feed->title) ?></title>

It's easy enough to add the Gallery's Title to the Theme's code so that it's present when viewing any album or photo (I think this should be a default behavior); however, I don't think the average user should need to modify the RSS module's code in this way.

Thanks,
Mark H.

00:45 Ticket #1306 (Creating a more flexible interface to the recaptcha module) created by dmolavi

As it exists right now, module developers who wish to implement recaptcha in their module are forced to either:
1) Overload recaptcha_event with your own MY_recaptcha_event, or

2) Edit recaptcha_event directly.

Recaptcha needs to be more flexible to enable it's use in -contrib developed modules without the developers having to muck around in core code.

08/21/10:

23:53 Ticket #1305 (Organize shows a blank window (and "FORBIDDEN" in the logs)) closed by bharat
fixed
23:51 Ticket #1305 (Organize shows a blank window (and "FORBIDDEN" in the logs)) created by bharat

In some configurations, the organize feature fails to load any data. Thanks to jrforbes in #gallery, it turns out the problem is that we were accidentally sending our custom headers using underscores instead of hyphens and that breaks some proxies.

23:45 Ticket #1271 (Comments Editing Doesn't work) reopened by ocbroadband
Steps 1) Install fresh copy of G3. 2) Perform import of gallery 2 pictures into Gallery 3 that include comments. 3) Once imported into G3, attempt to manipulate the comments via admin->Content->Comments->Approved. 4) Select either Delete/Spam/Disapprove, and none of the options work. In this case, there are actually multiple displays of the same comment.
23:26 Ticket #1304 (Illegal character in combined javascript) created by inposure

Chrome does not render Gallery 3 pages correctly due to an illegal character in the combined javascript generated by Gallery 3, see attachments.

When copying the character for analysis, it seems to be a strange combination of U+001F UNIT SEPARATOR, U+008B and U+0008 BACKSPACE.

22:11 Ticket #973 (Use reasonable standard size / dimension of videos / movies) closed by bharat
fixed: Fixed in c6a28a93ddfcf692e67342707d2b4a41dcf19fe5 -- don't take movies if we don't have ffmpeg.
22:10 Ticket #1303 (Handle the case if ffmpeg moves or is deleted) closed by bharat
fixed: Fixed in 4a01aaddc9fa443ca9e022666078d8a2d0578d8a
22:10 Ticket #1303 (Handle the case if ffmpeg moves or is deleted) created by bharat

Steps to reproduce:
1) Install ffmpeg
2) Install G3
3) Upload a movie (all works ok)
4) Delete or move ffmpeg
5) Upload a movie
--> fail (haven't verified this so don't know the exact fail case, but we'll try to exec a binary that doesn't exist)

21:14 Ticket #1167 (Large photos bork the gallery display) closed by bharat
duplicate: This is a dupe of https://sourceforge.net/apps/trac/gallery/ticket/1283 What's happening is that the graphics operation is failing, possibly because your server is limiting your CPU or imagemagick is running out of memory. The Kohana graphics toolkit that we rely on does not do great error handling and as a result you wind up with an invalid image and we can't easily detect it. Rebuilding may not work because if the rebuild failed once, it can fail again. The workaround for now is to use the "rebuild items" module: http://codex.gallery2.org/Gallery3:Modules:rebuild_items We'll fix this properly in 3.1 -- marking this as a dupe for now.
21:10 Ticket #1271 (Comments Editing Doesn't work) closed by bharat
worksforme: Can't reproduce; missing details. Closing as "works for me". Please reopen if you can provide steps to reproduce, thanks!
21:07 Ticket #1217 (Insecure cookie over HTTPS) closed by bharat
fixed
03:23 Ticket #1302 (Simple Uploader dialog buttons) created by nivekiam

1) 'Cancel All' should be 'Cancel all' to conform to our capitalization standards

2) Once the upload starts the 'Done' button should be grayed out until the process is actually complete. We have the 'Cancel all' button to cancel uploads. Pressing 'Done' while the uploads are still working closes the dialog and cancels the uploads. But may confuse users who thing they've selected the photos, they start uploading and go to press 'Done' thinking it'll finish in the background.

08/20/10:

14:50 Ticket #1301 (Enhancement request - Amazon S3 support / External storage support) created by bromide-g3

A particular integration with S3 and Gallery2 is discussed here:

http://gallery.menalto.com/node/77816

Additionally, from this wiki page:

http://codex.gallery2.org/Gallery3:About

There is a link to a feature list spreadsheet that shows that Amazon S3 integration was a feature considered for Gallery3.

If you assume that the person deploying the system can set up a virtual filesystem such as s3fs or a mounted NAS drive I think that this could be a fairly easy feature to implement; I believe all it would require is the ability to prepend the correct domain name and path to each image.

Another issue might be ensuring that the tmp folder can be placed at its own path outside of the remote filesystem due to possible latency issues in writing to the remote server. It might also be prudent, if things don't already work this way internally, to save an uploaded image to the tmp folder and queue it up for transfer to the proper storage location for better usability and error handling.

08/19/10:

11:38 Ticket #265 (Rotate images based on EXIF rotation information) closed by dmolavi
fixed: The autorotate module is now in gallery3-contrib on git.
06:58 Ticket #1300 (Fix timezone issues) created by galbit

Gallery interprets the capture date from the Exif header using the server time zone. That is only correct if camera and server happen to use the same time zone, which is not very likely under travel and/or if your server is in a remote place.

It was discussed in http://gallery.menalto.com/node/49336, and more recently in in http://gallery.menalto.com/node/97359, where bharat suggested to file a ticket for G3 as well.

Fixing this might solve #602 as well, depending on how it is done.

04:43 Ticket #1299 (server_add does not work for video files when ffmpeg is not installed) created by rlparadise

In order for the server_add to save a movie item, it goes through a set of logic that will cause an exception to be thrown IFF ffmpeg is not installed.

I would recommend considering a default width/height for video files so that ffmpeg is not required for a server_add of video files. More details on this idea and the context for where code changes could be made can be found at:

http://gallery.menalto.com/node/97453

08/18/10:

05:33 Ticket #1298 (Organize fails with "Remote server error: Contact your gallery ...) closed by bharat
fixed: Fixed in 387d30da764b152a9bb40ac6db7d9ce5282aa7a3
05:30 Ticket #1298 (Organize fails with "Remote server error: Contact your gallery ...) created by bharat

If your web setup is has a series of worker servers behind a single canonical hostname, Organize fails with "Remote server error: Contact your gallery administrator"

Behind the scenes, Flash requires any network requests to go back to the original host. In round robin setups, we stick in the name of the server, not the name of the host in the http headers. Flash asks the canonical host for crossdomain, it doesn't exist, Organize code falls over.

08/16/10:

17:38 Ticket #1297 (Improve Search for partial matches) created by orbisvicis

All my images are named "FileName?_XResxYRes.ext" and titled "FileName? XRes_YRes" (the default), so that might be part of the problem:

Some example searches highlighting the problem

  • "a" -> returns nothing. I expect to see any filename,description,or tag containing an "a"
  • I have an image named "388_1920x1200.jpg" and titled "388 1920x1200".
    • Search for "388" returns nothing.
    • Search for "388_1920x1200" returns the image -> good, full name search returns only the image.
    • Search for "388 1920x1200" returns any 1920x1200 image -> good, boolean "or" search working
    • Search for "1920x1200" returns any 1920x1200 image.
    • Search for "1920" returns nothing.

In general it seems that searching for a portion of a word doesn't work. That could be a problem if I have an image title "CoolTiteAtNight?" and want to search for "night".
I don't know why the search for "388" didn't work.

06:41 Ticket #1296 ([Uploader] Absolute URIs break http -> https proxies) created by orbisvicis

On linux, in order to convince flash to trust my self-signed certificate, I use stunnel as an http->https proxy to gallery. The problem is that some of the absolute URIs returned by gallery3 break the proxy, for example:

$base_url = ((empty($_SERVER['HTTPS']) OR $_SERVER['HTTPS'] ===
'off') ? 'http' : 'https').'://'.$site_domain;

(note: I'm not sure at all that specifically this line actually causes any problems)

Assuming my stunnel configuration is as so:

[https]
accept=127.0.0.1:11111
connect=my.website.net:myport
sslVersion=TLSv1

While browsing at http://127.0.0.1:11111, my browser will be redirected to https://127.0.0.1:11111. It then proceeds to encrypt the data, which is then doubly-encrypted by stunnel, so that my apache logs see:

Invalid method in request \x16\x03\x01    # ... this is a TLS Hello
Sequence

Why does this only happen on certain transfers during the flash upload (Say 5 in every 100 images)? I can say for sure that when browsing a gallery it occurs for each an every image. I'm not sure how firefox manages to recover from these errors, but I notice that browsing over stunnel tends to be 1.5-2x times slower.

Several ideas:

  • Is it really necessary to specify the protocol? Why not just return an absolute URL such as /gallery3/index.php?ImageName?...
  • Maybe use an X_HTTP_ONLY header to disallow SSL chatter?

08/15/10:

09:00 Ticket #1285 (Sendmail uses wrong encoding) closed by bharat
fixed: Fixed in ff1d8aea2f2805f85ce3cc7e4079d04fb9f1bac4
07:53 Ticket #1295 (Double clicking on dialog links causes a 2nd dialog to appear) created by bharat

Steps to reproduce:
1) Log in
2) Find any dialog menu, like Add > Add Photos
3) Double click the menu option
--> See the dialog appear, then scroll down and see another copy of the form pasted in the bottom of the page

Every time we click, it adds a new data <div> but it only binds one of them into the dialog itself. We should prevent double clicks.

07:18 Ticket #1294 ([flash uploader] retry failed transfers) created by orbisvicis

Use case:
Say I'm uploading 200+ images via the flash uploader, and by happenstance say 5 images fail to fully transfer (Get cut off, etc).
Shouldn't the flash uploader try to re-upload these failed images/transfers?
Otherwise its kinda'of a pain to hunt through 200+ entries in that small static flash window looking for failed transfers, then manually retry each.

Details
There probably should be more than one retry for each failed transfer. Say for example:
uploading 500+
50 fail
retry, uploading 50
5 fail
retry, uploading 5
1 fails
etc..

Also, its probably a good idea to inform the user which of the images terminally failed to upload, so the user doesn't have to go hunt through the miniscule flash window result log.

07:01 Ticket #1293 (Organize can't handle the new "data" resource) closed by bharat
fixed: Ah, I figured it out. Fixed in d2c59740b11c0764967410b233f3b01fc3dab85d

08/14/10:

22:50 Ticket #1293 (Organize can't handle the new "data" resource) created by bharat

We now return a data resource implemented by data_rest that points to the thumbnail, resize or full size of a protected image. The organize module needs to request those using the REST protocol and send a X-Gallery-Request-Key param.

Steps to repro:
1) Lock down the view perms on an album with photos in it
2) Organize that album (as admin is fine)
--> broken thumbnails

22:48 Ticket #1292 (REST items resource exposes the ids of members that users can't see) closed by bharat
fixed: Fixed in b562751fdb2ae8aab3a344e84176ea03381ca04c
22:47 Ticket #1292 (REST items resource exposes the ids of members that users can't see) created by bharat

Steps to reproduce:
1) Create root albums A and B, user A in group A.
2) Remove view permissions for album B from group A
3) Log in as user A and to to album A
4) Run Organize Album
--> blank results

The REST call to the root is returning the existence of album B, and then the Organize code is trying to request B and getting a 403, and then crapping out.

21:56 Ticket #1289 (Missing access_cache rows can break a variety of functions) closed by bharat
fixed: Fixed in d9f8c8a295b760bb5b858c96f1658d50c321bd01
13:07 Ticket #797 (Cannot upload watermark image) reopened by vor0nwe
I'm having a similar issue, except that I couldn't upload any type of image for my watermarks. (Running Gallery3 RC2) After a bit of judicious spelunking in the Gallery3 code looking for 'validation' and 'invalid_type', I ended up in gallery3/modules/forge/libraries/Form_Upload.php, near line 139. I haven't looked at it very thoroughly, but it would appear that that upload form accepts or rejects the image based on the MIME-type sent by the browser(!). A very quick and REALLY dirty workaround for me was to change the rule to accept everything by default, upload the new watermark, and revert the code change. So I changed line 139 of gallery3/modules/forge/libraries/Form_Upload.php from // Allow nothing by default $allow = FALSE; to $allow = TRUE; // TODO: Revert this dirty hack!!! Then the transparent PNG was accepted without a hitch. Could someone adjust that test so that it'll accept a file based on it actually being a valid file format? Or, if that's too difficult, by file extension?

08/13/10:

06:18 Ticket #1291 (Create item REST API request results in a HTTP/1.1 500 Internal Server ...) closed by bharat
wontfix: "jhead" is not an official module. Please disable that module and ask the original author in the forums to update it for the latest version of Gallery 3. Looks like it's using the old K2.3 APIs.

08/12/10:

17:45 Ticket #1291 (Create item REST API request results in a HTTP/1.1 500 Internal Server ...) created by xkjq

Item and metadata is created successfully but the result is a HTTP/1.1 500 Internal Server Error.

Log file contains:

2010-08-12 10:36:44 -07:00 --- error: Kohana_PHP_Exception [ 1 ]: Call to undefined method Kohana::log()
/home/gallery3/modules/jhead/helpers/jhead_event.php [ 44 ]
#0 /home/gallery3/system/core/Event.php(208): Kohana_PHP_Exception_Core::shutdown_handler(NULL)
#1 /home/gallery3/system/core/Kohana.php(549): Event_Core::run(Array, Array)
#2 [internal function]: Kohana_Core::shutdown('system.shutdown')
#3 {main}

Error page is attached.

09:22 Ticket #1290 (Allow creation of multiple tags per REST request.) created by xkjq

It would be useful to be able to create/request multiple tags in a single API request.

Forum thread.

05:56 Ticket #1289 (Missing access_cache rows can break a variety of functions) created by bharat

If there's a bug and uploads go wrong, we can wind up without access_cache rows. This is going to be rare, but it's a pain when it happens. We should extend the Fix task to find missing access_cache rows and add them.

04:03 Ticket #974 (G3 Protected Videos do not play the first time the page is visited) closed by bharat
fixed
04:02 Ticket #974 (G3 Protected Videos do not play the first time the page is visited) reopened by bharat

08/11/10:

15:04 Ticket #1288 (Dangling <li> element in admin.html.php) closed by tnalmdal
fixed: Add a containing <ul> element for the footer on the admin page. Also respect the "show credits" variable setting. Commit: c90996341aa309a0c585392427561831890767c7
15:00 Ticket #1288 (Dangling <li> element in admin.html.php) created by tnalmdal

Just noticed that there is no containing <ul> around the credits on the admin.html page.

12:16 Ticket #1287 (Mails from Notification module use wrong language) created by gertschi83

Steps to reproduce

  • Enable the Notification module
  • Add German as an additional language
  • Set your user's default language to English
  • Set Gallery's default language to German
  • Create a new album named Foo
  • Enable notifications for album Foo
  • Upload one image to album Foo

What I expected to see
The received email from the Notification module should be completly in English since the user's default language is English.

What I saw instead
The subject line of the email is in English. However, the email content is in German. My tests show that the content is always in G3's default language.

12:01 Ticket #1286 (Mails from Notification module contain useless notifications) created by gertschi83

Steps to reproduce

  • Enable the Notification module
  • Create a new album named Foo
  • Enable notifications for album Foo
  • Upload one image to album Foo

What I expected to see
The received email should contain the following text: Photo "Bar" added to "Foo"

What I saw instead
The email contains the following notifications:

  • Photo "Bar" updated
  • Photo "Bar" updated
  • Photo "Bar" updated
  • Photo "Bar" added to "Foo"

I'm not sure why I get those three notifications about 'Photo "Bar" updated'. However, I don't think that this is an intended behaviour.

11:45 Ticket #1285 (Sendmail uses wrong encoding) created by gertschi83

Steps to reproduce
Change the default language to German and reset your password. You will receive an email where not every character is readable. At least Thunderbird shows "Passwort zurücksetzen anfordern" instead of "Passwort zurücksetzen anfordern".

Cause
The Content-Type is set to ISO-8859-1 instead of UTF-8.

Solution
Change the Content-Type header in the following files:

./modules/notification/helpers/notification.php
./modules/user/controllers/password.php
./modules/gallery/controllers/user_profile.php

The correct way to set the header is:

->header("Content-Type", "text/html; charset=UTF-8")

08/10/10:

04:59 Ticket #1284 (A string in Organize module can't be translated.) created by engineer9

Please see the attached file.

Does it cause by the separate lines (line 54 and 55) in modules/organize/helpers/organize_event.php file?

03:56 Ticket #1283 (Image toolkit errors are ignored) created by bharat

The graphics code is expecting the image processing code to throw an exception when there's a problem, but instead it returns a status code which we ignore.

graphics::generate()

   155      try {
   ...
   171          foreach (self::_get_rules($target) as $rule) {
   172            $args = array($working_file, $output_file, unserialize($rule->args));
   173            call_user_func_array($rule->operation, $args);
   174            $working_file = $output_file;
   175          }
   176        }
   ...
   192      } catch (Exception $e) {
   193        // Something went wrong rebuilding the image.  Leave it dirty and move on.
   194        // @todo we should handle this better.
   195        Kohana_Log::add("error", "Caught exception rebuilding image: {$item->title}\n" .
   196                    $e->getMessage() . "\n" . $e->getTraceAsString());
   197        throw $e;
   198      }

gallery_graphics::resize()

    63        $image = Image::factory($input_file)
    64          ->resize($options["width"], $options["height"], $options["master"])
    65          ->quality(module::get_var("gallery", "image_quality"));
    66        if (graphics::can("sharpen")) {
    67          $image->sharpen(module::get_var("gallery", "image_sharpen"));
    68        }
    69        $image->save($output_file);

Image::save()

   375          public function save($new_image = FALSE, $chmod = 0644, $keep_actions = FALSE, $background = NULL)
   376          {
   ...
   405                  return $status;
   406          }

We need to check the $status and properly handle it in all cases.

08/09/10:

22:39 Ticket #1282 (G2 import re-copies already imported comments) created by beckettmw

Re-running the G2 import module re-copies all comments, even if they've previously been imported from an earlier run.

-Beckett

22:18 Ticket #1281 (Can't edit root album) closed by bharat
fixed: Fixed in https://sourceforge.net/apps/trac/gallery/ticket/1281
22:17 Ticket #1281 (Can't edit root album) created by bharat

Steps to reproduce:
1) Go to root album
2) Edit album
3) Change title
4) [Save]
--->
2010-08-09 15:14:15 -07:00 --- error: ErrorException? [ 0 ]: Undefined index: name
/gallery3/modules/gallery/controllers/albums.php [ 135 ]

07:29 Ticket #1280 (Pagination doesn't work in Admin > Contents > Comments) closed by bharat
fixed: Fixed in b6a50140474b4ac20eb3bf6e1c9427674f728b54
07:27 Ticket #1280 (Pagination doesn't work in Admin > Contents > Comments) created by bharat

We're using Database_Builder::limit() the way the old API used to work.

04:50 Ticket #1226 (Need a button to reset the REST access key) closed by bharat
fixed
04:25 Ticket #1261 (date/time format configuring is broken) closed by bharat
fixed: Fixed in 2dda8e22a7a32db8a5577aad0cff2b47ac0f9c63
04:22 Ticket #1279 (theme::get_info fails with special characters in the theme name) closed by bharat
fixed: Fixed in 1ad1f9517f91875875f2e062bda7d834827c3430
04:21 Ticket #1263 (Logout forwards to IP-address of the local server instead of the ...) closed by bharat
worksforme: I'm not sure how we're reasonably going to detect that the code is running behind a proxy with a different canonical domain name. We do some reasonable things in application/config/config.php for the $configsite_domain? variable, but if this is inadequate you can always edit that setting yourself. Closing as "worksforme" since there's a workaround.
04:17 Ticket #1274 (G2 Import: obey image rotation) closed by bharat
fixed: Fixed in 639d31a2c1a54f31ad32208b8602a8922d336fa0
00:26 Ticket #1279 (theme::get_info fails with special characters in the theme name) created by tnalmdal

theme::get_info uses

     $theme_name = preg_replace("/[^\w]/", "", $theme_name);

to sanitize the theme name

two problems with sanitizing it here:
1) "-" and "_" are valid file names in some theme names and they are stripped with this replace.
2) It doesn't match the name that was checked to see if the file exists.

00:25 Ticket #1227 (Periodically refresh cached group ids in sessions) closed by bharat
fixed: Fixed in acb1faaa594fc5067c4340e073afca3b83f819d4
00:14 Ticket #1258 (ORM_Validation_Exception should always report what failed validation) closed by bharat
fixed: Fixed in ebbb73787d6f935354478d4bdbe626c163c90a9c
00:10 Ticket #1269 (G2 Import: Visually separate the subject of imported comments) closed by bharat
fixed: Fixed in e85b345edaded7d4a68ae758138bcff9d0ceaefb

08/08/10:

23:54 Ticket #1278 (Date/time formats are inconsistent) closed by bharat
fixed: Fixed in 2dda8e22a7a32db8a5577aad0cff2b47ac0f9c63
23:53 Ticket #1278 (Date/time formats are inconsistent) created by bharat

We should be using gallery::date(), gallery::date_time() and gallery::time() everywhere.

23:50 Ticket #1215 (G2 import - comments date.) closed by bharat
fixed: Fixed in cdb6306d7e75451587fbc029b94ef197f42842f1
22:17 Ticket #1277 (PHP bug causes stderr from exec("which ...") to overflow into other file ...) created by bharat

See conversation with dzm starting here:
http://gallery.menalto.com/gallery_3.0_rc2_feedback?page=2#comment-349917

In theory we can simply redirect stderr into stdout, but I'm worried that there are cases where there's random stderr from the PHP/exec/bash interaction that is getting ignored, and thise close to the final release I'm leery of changing it unless we have a strong reason.

For 3.1, we should implement dzm's patch and get it tested.

22:02 Ticket #1205 (Add JSONP support to REST replies) closed by bharat
fixed: Fixed in d6f5a8a8d13892d6487f344c5e5b1f5dd48893d5
19:46 Ticket #1228 (404 exceptions are very noisy in the logs) closed by bharat
fixed: Fixed in 3c7dc6d7a63e59c841f60d9594575efcf0969f98
18:35 Ticket #1173 (Create a REST service registry) closed by bharat
fixed: Fixed in ded9ed4df809d28ba2f4519a398e06daf335ee81
17:14 Ticket #1276 (G2 Import: missing sort order direction in G2 album results in invalid ORM) closed by bharat
fixed: Fixed in a22cf8cf1c1f3eccedb01ab4629e579c95594dae
17:14 Ticket #1276 (G2 Import: missing sort order direction in G2 album results in invalid ORM) created by bharat

If the G2 album doesn't have a order direction specified, it can use the default value. For some reason in our infinite wisdom, we set the default.orderDirection to "1" instead of "asc" or "desc" which results in the error here:

http://gallery.menalto.com/node/96511

09:42 Ticket #1236 (Replacing image file via RESTful API has no effect) closed by bharat
fixed: Fixed in 4e95ec843a2bef45e044e2aa3a36fcb590d85464
09:32 Ticket #1223 (Fix album/photo hierarchy goes way, way over the # of total items) closed by bharat
fixed
09:26 Ticket #1264 (Add new photo button of empty albums is broken) closed by bharat
worksforme
08:49 Ticket #1275 (The error page should provide more tips on how to get help) closed by bharat
fixed: Fixed in 0d2237979a2cc92d707a47115e492bff57fa9c5d
08:49 Ticket #1275 (The error page should provide more tips on how to get help) created by bharat

We should have links to the var/logs logfiles, links to the forums and the tracker. Also, we should provide a cut-n-pasteable list of details about the system to get the conversation going.

05:33 Ticket #1224 (Need a REST resource that returns the image data directly) closed by bharat
fixed
05:31 Ticket #504 (Adding a photo that already exists in an album should replace the existing ...) closed by bharat
fixed: I've added support in the API to replace a file with another one of the same mime type in dfb095a26267f8b68b40add03dfe407966c49b92
01:01 Ticket #1274 (G2 Import: obey image rotation) created by bharat

When importing photos from G2, we should read the derivative operation rules and do our best to obey any rotation rules that we find.

I think this is a priority for the 3.0 release since many people will use the importer at that time and we don't want them to have to go back and manually fix up all of their rotated photos.

08/07/10:

09:15 Ticket #1273 (Split edit/add permissions) created by peterkr333

At the moment 'edit' permission covers both
1) editing permissions and
2) editing descriptions (captions).

It is highly desirable that users are able to edit description of their photos or albums but at the same time are unable to change permissions. Setting permissions should be reserved to administrator.

- addition from ckdake below -
Per a conversation at GalleryCon?, we identified several other key modes and have decided to split out the add/edit permissions into the following:

* add_album -> Ability to add subalbums to an album
* add_photos -> Ability to add photos to an album
* edit -> Ability to edit an album (Same as it is now, and default for owners when they create a new album. This is #1 from original feature description)
* edit_all_photos (and albums) -> Ability to edit/delete/rename/caption etc for everything contained in an album. (This is #2 from original feature description)
* edit_my_photos -> Ability to edit/delete/rename/caption/etc photos owned by the user.

No "edit my albums" is needed because Album owners can always edit their albums.

03:20 Ticket #1272 (Provide a way to order modules) closed by bharat
fixed

08/06/10:

18:05 Ticket #1203 (Control module load (execution) order) closed by floridave
duplicate: Bharat created https://sourceforge.net/apps/trac/gallery/ticket/1272 and started on this task so I am closing as a dupe.
17:23 Ticket #1272 (Provide a way to order modules) created by bharat

Module order is unspecified which makes it hard for us to constrain event triggering order. Add a "weight" column to the module table to let us (currently the 3rd party moduleorder module) specify the order. We may eventually want to make this a core feature.

15:35 Ticket #1271 (Comments Editing Doesn't work) created by ocbroadband

Gallery Ver: Gallery 3.0 RC2 (Santa Fe)

Original Import from Gallery 2 to Gallery 3.0 RC1

When going to the comments edit section under Admin->Content->Comments, 4 options are shown..

1) Awaiting Moderation
2) Approved
3) Spam
4) Recently Deleted

If I select the Approved, all the comments are shown from my gallery. Any comments that have been added with v3.x, I can edit just fine. Anything that was brought in with the import, I am unable to perform any edits to them via any of the 3 options..

1) Unapprove
2) Spam
3) Delete

None of the above work on the imported pictures.

08/04/10:

05:09 Ticket #1270 (Add retry logic to the task framework) created by bharat

For long running tasks, if a single reply gets dropped the task pauses. The JS should employ some kind of retry logic. I propose:

1) After no response for 15 seconds assume that the task is stalled and retry. Repeat this 3 times. Inform the user at every step with a message like "Task stalled, retrying".

2) After a successful retry, reset the fail count to 0 again.

3) After 3 failed retries, put up a message saying "Task failed, check the maintenance page for details"

04:39 Ticket #1269 (G2 Import: Visually separate the subject of imported comments) created by bharat

We did away with the subject field in comments in G3. But when we import comments from G2 we should visually separate the subject from the body. Perhaps just wrapping them in a bold tags would be enough?

See http://gallery.menalto.com/node/97140

01:57 Ticket #1268 (Simple uploader fails if flash not installed) created by floridave

If the user does not have flash installed there is no warning that they need it to add items.

I thought that there was a fallback. I uninstalled flash from my client and then tried to add an item ad get the modal window and the browse button but can add any items.

Here is a link to the demo behavior:
http://anpmech.com/recordMyDesktop.ogv

Recommend:
1. warning that they need flash installed for the uploader to work. 2. Give them the option to add the HTML_uploader.

08/02/10:

05:30 Ticket #1231 (Wrong link when using mod_rewrite) closed by bharat
fixed: This makes sense. We set the url for that message in the database before you disabled the mod_rewrite urls, so it's not easy for us to find/fix it. While it's a little irritating, that's only going to happen very early in the process. I don't think that this needs fixing, I'm going to close it as "wontfix". If you feel strongly about it, please reopen the bug and make a case for it :-)
05:20 Ticket #1265 (Incorrect old password in change password form yields ...) closed by bharat
fixed
05:10 Ticket #1267 (Maintenance page is unthemed) closed by bharat
fixed
04:50 Ticket #1260 (Expand the Fix task to handle duplicate names and slugs) closed by bharat
fixed: The 2nd problem came from a couple of album_cover_item_id columns pointing to bogus items. I've improved the Fix task to take care of that in ca54cdd6448ec919efe3853992dc652b7c671d97
04:32 Ticket #1267 (Maintenance page is unthemed) created by bharat

And it looks a lot like login/html (which you can see if you fail to login once). Why not jut replace the maintenance view with login/html altogether. We just need to carry forward the "redirect to admin/maintenance after logging in" part.

04:02 Ticket #1259 (Put Gallery in maintenance mode when running the Fix task) closed by bharat
fixed
03:56 Ticket #1260 (Expand the Fix task to handle duplicate names and slugs) reopened by santabutthead
So, since it appears you're not here, here's what I did: I updated gallery (This required git reset --hard so I could get rid of the in tree changes) Ran the maintenance task as requested in the forums The 'Fix your gallery' operation never completes (it's still running according to the progress bar, which is pinned at a full blue bar and the round thing is still turning, but it /never/ offers to complete and there is no longer any real activity coming from apache2/mysql after 5 minutes. So I hit pause, and reresumed and it's now tried again. Started over a second time it /did/ end, hit 87508/87523 and offers to close now.

08/01/10:

17:54 Ticket #1225 (A bunch of forms are broken) closed by bharat
fixed
17:53 Ticket #1219 ("Welcome to Gallery" dialog is broken) closed by bharat
fixed
08:35 Ticket #1266 (Empty username in Admin > Users results in "validation.required" msg) closed by bharat
fixed: Fixed in a5f701951ee00f85690b804a8c63a9bddc48b67f
04:40 Ticket #1260 (Expand the Fix task to handle duplicate names and slugs) closed by bharat
fixed
03:34 Ticket #1266 (Empty username in Admin > Users results in "validation.required" msg) created by bharat

Steps to reproduce
1) Admin > Users
2) Click [edit] on the "admin" user
3) blank out the username
4) click "Modify user"
---> See "validation.required" as the error message

03:22 Ticket #1265 (Incorrect old password in change password form yields ...) created by bharat

Steps to reproduce:
1) Click on your name in the top right
2) Click "change password"
3) Enter an invalid old password
4) Hit "Save"
---> See "validation.invalid_password"

01:34 Ticket #1264 (Add new photo button of empty albums is broken) created by mamouneyya

Steps to reproduce:
(1) Create an album
(2) Gallery will say: There aren't any photos here yet! Add some. Just try to click on Add some button. Nothing will happen.

07/31/10:

15:51 Ticket #1263 (Logout forwards to IP-address of the local server instead of the ...) created by wanke

Link: https://aaa.bbb.ccc.ddd/gallery3/index.php/logout?csrf=<something>&continue_url=http%3A%2F%2F192.168.100.101%2Fgallery3%2Findex.php%2Fadmin

aaa.bbb.ccc.ddd is the public IP-address of a proxy server
192.168.100.101 is the local IP-address of the gallery-Apache the proxy forwards all gallery requests to

12:48 Ticket #1262 (Make the month names translatable) created by mamouneyya

It's important for RTL languages, like Arabic, to have pure Arabic letters in the string lines. Otherwise, the alignment will be broken in Gallery, in case there was English/Arabic in the same line.

See the attached image to understand.

12:39 Ticket #1261 (date/time format configuring is broken) created by mamouneyya

Steps to reproduce:
(1) Go to Admin -> Settings -> Advanced and change the date/time format to anything other than the default.
(2) Go to any photo in your albums and add comment on it. You will see that its time stamp is formatted as you configured.
(3) Refresh the page. Now you will see that the date/time format is shown as it was before, regardless your changes!

07/30/10:

04:49 Ticket #1260 (Expand the Fix task to handle duplicate names and slugs) created by bharat

Slugs are easy; we can just change those. Names are harder because even if we change them, there'll be no underlying data file. We can copy the data file, I guess. Or just leave it broken.

04:22 Ticket #1259 (Put Gallery in maintenance mode when running the Fix task) created by bharat

The Fix task updates MPTT pointers -- we should be in single user mode when we run it.

02:26 Ticket #1258 (ORM_Validation_Exception should always report what failed validation) created by bharat

We trap this in a variety of places, but we should centralize this by overriding ORM_Validation_Core and having it generate the correct message in handle_validation().

07/28/10:

03:06 Ticket #1257 (Better handling of UI hangs) closed by tnalmdal
duplicate: This is probably related to #236
00:04 Ticket #1257 (Better handling of UI hangs) created by nivekiam

See thread here (first 4 posts cover the topic)
http://gallery.menalto.com/node/97146

When something like what he's describing there happens (table crash, or other DB problem) could we not hang the UI, but instead display some sort of "fail whale/Your DB has problems" type message to give the user a clue as to what might be going on or where to start digging?

07/27/10:

18:26 Ticket #1241 (Missing flash files in Organize) reopened by bharat
This fix breaks the organize feature for me. The canvas where the images are supposed to show up is missing entirely.
18:25 Ticket #1256 (The "get flash player" button doesn't show up on the organize dialog) closed by bharat
fixed
18:18 Ticket #1256 (The "get flash player" button doesn't show up on the organize dialog) created by bharat

If you don't have flash installed, it's supposed to give you a button to install flash, but that button is missing. Instead, you get a JS error.

17:50 Ticket #1255 (Don't unnecessarily regenerate the thumbnail when making album covers) closed by bharat
fixed: Fixed in 52f1c4b8c6a3a4043fcca3901a659b140b77f9d9
17:49 Ticket #1255 (Don't unnecessarily regenerate the thumbnail when making album covers) created by bharat

When we make an album cover from an item that's already got a clean thumbnail, just copy over that thumbnail instead of invoking a graphics toolkit since the thumbnails should be exactly the same.

04:38 Ticket #1253 (Relocating Gallery 3 after configuring G2 import results in broken Admin > ...) closed by bharat
fixed: I'm seeing this with PHP 5.3.2-1 on Debian with: Zend Engine v2.3.0, Copyright (c) 1998-2010 Zend Technologies with Xdebug v2.0.5, Copyright (c) 2002-2008, by Derick Rethans with Suhosin v0.9.31, Copyright (c) 2007-2010, by SektionEins? GmbH I've found that the paths to the various files are all fine, and this problem goes away if I actually touch the generated files in some way (eg: using the unix "touch" command). My theory is that there's a bytecode cache of some kind in here and that it's kicking in and preserving the wrong paths. Unclear exactly why since I don't believe I'm running a cache, but perhaps Xdebug is getting in the way. One solution is to just touch all the files if we don't generate them. I've implemented that fix in addbd6fb81685e42fb262882dc798b1bd040dd8c

07/26/10:

15:15 Ticket #1254 (EXIF doesn't use Unicode) created by inposure

EXIF extracted from Gallery 3 is not using UTF-8, but ISO-8859-1.

For example, the copyright character "©" is transformed to "©", see attached image.

My workflow is CS5 with all parameters set to UTF-8; this error only occurs with Gallery, not with any other app or internet service.

07/25/10:

18:14 Ticket #1253 (Relocating Gallery 3 after configuring G2 import results in broken Admin > ...) created by bharat

Steps to reproduce:
1) Install G2 import and configure it
2) Rename gallery3 to a new dir
3) Go to Admin > Maintenance
---> Fatal error: main(): Failed opening required '/var/www/gallery3/var/modules/g2_import/6cb83d3b54d38535598f5c77b34e2f74/main.php'

18:11 Ticket #1252 (Moving Gallery3 breaks existing .htaccess files) closed by bharat
fixed: Fixed in 5be9ae3250fab24631c0fc6b900ffccd9b1755f2
16:44 Ticket #1252 (Moving Gallery3 breaks existing .htaccess files) created by bharat

We should have a maintenance task that finds and fixes them all.

07/24/10:

06:15 Ticket #1242 (Tag Cloud: No tags cause the tag cloud movie to fail) closed by tnalmdal
fixed: Don't try to initialize the tag_cloud.swf file if there are no tags present. Commit: http://bit.ly/dwyQpn
06:05 Ticket #1241 (Missing flash files in Organize) closed by tnalmdal
fixed: Combine all the flex runtime libraries into a single downloadable file. Commit: http://bit.ly/9PPacq

07/23/10:

15:33 WikiStart edited by tnalmdal
Remove spam (diff)
15:31 Ticket #1246 (Pharmacie Sans Ordonnance sur internet) closed by tnalmdal
invalid
15:30 Ticket #1247 (Acheter medicaments Sans Ordonnance) closed by tnalmdal
invalid
15:30 Ticket #1248 (Acheter Generique Sans Ordonnance) closed by tnalmdal
invalid
15:28 Ticket #1249 (Achat Medicaments generiques) closed by tnalmdal
invalid
15:27 Ticket #1250 (Acheter Medicaments) closed by tnalmdal
invalid
15:23 Ticket #1251 (Achat Medicaments) closed by tnalmdal
invalid
15:22 Ticket #1245 (Pharmacie sur internet) closed by tnalmdal
invalid
15:22 Ticket #1244 (Pharmacie En Ligne France) closed by tnalmdal
invalid
15:21 Ticket #1243 (Acheter Generique France Sans Ordonnance, Achat Medicaments bon marche sur ...) closed by tnalmdal
invalid
15:20 Ticket #1251 (Achat Medicaments) created by jodoreps

* Achat Medicaments
* upload javascript
* Compra Medicamentos Por Internet
* where to Buy Generic online without prescription
* Acheter generique en ligne france

15:20 Ticket #1250 (Acheter Medicaments) created by jodoreps

* Acheter Medicaments
* free javascript hosting
* Comprar Medicamentos sin receta
* where to Buy Generics online no prescription
* Achat generique en ligne france

15:20 Ticket #1249 (Achat Medicaments generiques) created by jodoreps

* Achat Medicaments generiques
* upload text
* Compra Medicamentos genericos
* where to Buy medicaments online generic side effects
* Acheter generique bon marche

15:20 Ticket #1248 (Acheter Generique Sans Ordonnance) created by jodoreps

* Acheter Generique Sans Ordonnance
* paste javascript
* Comprar genericos sin receta
* where to Buy Generic online usa canada
* Le blog sur la medicine

15:20 Ticket #1247 (Acheter medicaments Sans Ordonnance) created by jodoreps

* Acheter medicaments Sans Ordonnance
* share javascript
* Donde Comprar genericos sin receta
* Buy Generic online no prescription
* pharmacie en ligne france

15:18 Ticket #1246 (Pharmacie Sans Ordonnance sur internet) created by jodoreps

* Pharmacie Sans Ordonnance sur internet
* paste css
* Farmacia Genericos
* Order Generic cheapest online
* pharmacie en ligne

15:18 Ticket #1245 (Pharmacie sur internet) created by jodoreps

* Pharmacie sur internet
* free css hosting
* Farmacia Española
* Cheap Generics online
* Medicaments en ligne

15:18 Ticket #1244 (Pharmacie En Ligne France) created by jodoreps

* Pharmacie En Ligne France
* upload css
* Comprar Genericos En España Sin Receta
* where to buy Generics online
* Pharmacie en france

15:18 Ticket #1243 (Acheter Generique France Sans Ordonnance, Achat Medicaments bon marche sur ...) created by jodoreps

* Acheter Generique France Sans Ordonnance, Achat Medicaments bon marche sur internet
* free text hosting
* Farmacia Española , Comprar Genericos En España Sin Receta , Compra Medicamentos Por Internet
* Medical Assistant - Your Assistant Online
* L'Assistant Medical - Ton Assistant en ligne

15:17 WikiStart edited by jodoreps
(diff)
15:15 WikiStart edited by jodoreps
(diff)
14:27 Ticket #1242 (Tag Cloud: No tags cause the tag cloud movie to fail) created by tnalmdal

If there are no tags, then the tag cloud movie fails badly and hangs the browser.

12:54 Ticket #1241 (Missing flash files in Organize) created by tnalmdal

Occasionally, depending on what version of flash is installed, the appropriate flash runtime libraries are not installed.

10:16 Ticket #1240 (Access older (more than 5) details of user activity in Dashboard 'Log ...) created by andyduggan

Having problems with users editing/deleting other users photos now the permissions are by group only.

The dashboard 'Log Entries' only show the 5 most recent user activities and I cant see who deleted the photos.

A way of accessing older details might be useful.

Note: See TracTimeline for information about the timeline view.