Timeline
06/05/09:
- 22:41 Ticket #346 (Show rejected / pending translation submissions) created by
-
We need a UI to show rejected / pending translation submissions.
This is a follow up task for ticket 250.
On GMC, we need a UI to triage pending sumbissions. That's a different task though.
In G3, we need to show a list of pending / rejected l10n translation submissions when the user uploads translations.
- 22:38 Ticket #250 (Handle translation submission errors by translation, not for the whole ...) closed by
- fixed
- 21:19 Ticket #345 (G2 Import description formatting mistakes) created by
-
When importing a G2 gallery I found that " in the g2 description turns into " in g3.
Also, extra enter lines in the g2 description are removed when importing to g3.
- 06:58 Ticket #324 (Server Add needs a complete rewrite) reopened by
- 06:22 Ticket #344 (Rebuild images task loops endlessly when there are broken images) closed by
- fixed
- 06:20 Ticket #344 (Rebuild images task loops endlessly when there are broken images) created by
-
If you have an image that is broken such that you can't generate a thumb/resize, then the rebuild task loops endlessly. The total # of images to be processed keeps going up, as does the total # that are completed.
- 05:12 Ticket #340 (Album order not preserved when using next/previous links) closed by
- fixed: Fixed in 4f0a3fefa035ec351bc881093f49f9bc81941f3d
- 04:26 Ticket #343 (missing file: gallery3/modules/gallery/controllers/s.php) closed by
- fixed: Fixed!
- 04:26 Ticket #343 (missing file: gallery3/modules/gallery/controllers/s.php) created by
-
CGI sapi confuses Router which doens't realize that http://example.com/gallery3 is equiv to http://example.com/gallery3/index.php so it doesn't use the default route, which confuses MY_url::parse_url() resulting in it thinking that there's an item when there isn't resulting using the controller "{$item->type}s" which results in "s". Bad.
- 04:12 Ticket #342 (Page titles in the default theme are not very useful.) created by
-
http://gallery.menalto.com/gallery_3.0_alpha_4_feedback?page=1#comment-309386
They're all "Browse Photos album". They should include the title of the photo or album we're looking at.
- 04:11 Ticket #341 (Explain "default" sort order better in album options) created by
-
http://gallery.menalto.com/gallery_3.0_alpha_4_feedback?page=1#comment-309386
Users are confused by "Default" as a sort order option. I think it means "sort by id" which really means "sort in the order in which items were created in gallery 3"
- 04:09 Ticket #340 (Album order not preserved when using next/previous links) created by
-
http://gallery.menalto.com/gallery_3.0_alpha_4_feedback?page=1#comment-309386
"When rearranging items in an album, the album page views update correctly. However if you click through the album image-by-image, the previous/next links use the original album order."
06/04/09:
- 21:33 Ticket #339 (G2 Import rotated images have a rotated thumb and an un-rotated original) created by
-
After importing via G2 Import, any images that you rotated in your G2 where you checked the "save the original" box wind up with a rotated thumbnail, but an un-rotated original.
What's happening is that G3 is copying the "pure" original (the one that G2 saved off before it did the rotation you requested). This is probably what you want in that it's giving you the best data available. But when it makes the thumbnail it realizes that it can just copy the thumbnail over from G2 so it copies the file over but that thumbnail was generated against the rotated version.
So we can either:
1) Ignore the "pure" original in G2 and import the one that was rotated (end result is probably what you want to see, but since rotation is slightly lossy you're going to lose the benefit of your "preserve the original" checkbox from G2).
2) Import the "pure" original from G2 and generate the thumbnail from it instead of copying the thumbnail over. This saves the highest quality data, but we know it's not what you want to see. And when you rotate the image you're immediately going to change it because G3 doesn't save off a copy of the pure original.
thoughts?
- 19:32 Ticket #324 (Server Add needs a complete rewrite) closed by
- fixed: Was rolled into beta 1, by bharat on June 4th
- 13:56 Ticket #338 (Installing Gallery3) created by
-
When installing Gallery3 to http://gallery3.localhost/
until setup is complete, redirects to http://www.\.com/installer
- 01:13 Ticket #163 (If album is empty, display messages to users and privileged users) closed by
- fixed
- 01:02 Ticket #337 (Display error message when trying to upload a photo that's bigger than ...) created by
-
I just tried to upload a couple of photos, one of the being bigger than 2MB. It was very weird that all of the uploaded fine and I didn't get any error message, but one picture just wouldn't upload. Only after some searching I found out that the one picture was bigger than the others and that my upload_max_filesize was only set to 2M.
We need to display some sort of error message here.
It would be best if we also provide some help on how to change upload_max_filesize.
06/03/09:
- 11:57 Ticket #336 (Automatically add certain paths to the gallery) created by
-
I would like to let my users upload photos by WebDAV and also synchronize them with rsync. Ideally, a user would work either with his collection on a local or remote disk using Picasa and Gallery3 should automatically update its database.
Currently, an update to EXIF data would work out of the box (i.e. photo's annotation). What is missing though is a way to automatically include all changes to the var/albums directory in the web UI. Essentially, this is an automatic "server add" action on the var/albums directory + update recognition.
- 05:11 Ticket #335 (Organize: Visually differentiate album microthumbs) created by
-
Use the album icon provided by Ben Dunkle
- 04:52 Ticket #322 (Make adding photos more prominent in the site menu) closed by
- fixed: should be fixed with this: http://github.com/gallery/gallery3/commit/dde5fb96ee9db5a67b286ea4ac4f35190453a6ef
06/02/09:
- 22:59 Ticket #334 (Tag Albums) created by
-
The ability to create an album from a list of tags. So if you create an album called "Photography Portfolio" you would probably associate the tags "photography" and "portfolio". The album would contain the pictures that held those tags. It might be an option for the album to contain the subset of pictures with both tags, or include both sets.
This would be similar to the delicious concept of tag bundles.
- 22:53 Ticket #333 (Display related tags when viewing a tag) created by
-
I'd like to make a suggestion to display a list of any associated tags while the user is viewing a tag.
Something similar to the delicious tag interface. When you're looking at a tag you get a list of related tags on the right. When you click on a related tag, you view the subset of both tags.
- 19:09 Ticket #320 (Rename Item_Model::{thumb,movie,resize}_tag() to xxx_image() for clarity) closed by
- fixed: Fixed with this revision: http://bit.ly/3KIgfz
- 18:42 Ticket #332 (js error "PicLensLite is not defined") created by
-
When I press the slideshow button, nothing happens and I get the above javascript message. When i look in the piclens_optimzed.js file it is empty.
- 18:34 Ticket #331 (Badly formed html in header text messes the layout) created by
-
In the theme options the administrator can enter a custom header and footer. The header and footer can contain html. If this html is badly formed (i.e. <h2>Header Text<h2>) not the missing closing tag, then the layout of the page is changed.
We should try to find a way to validate the text (assume its html) and force the validation as part of the save processing
- 07:47 Ticket #254 (Double quotes not handled correctly in module.info parsing and l10n server) closed by
- fixed: That was an issue with module.info files and parse_ini_file(). Fixed with a workaround for now: http://github.com/gallery/gallery3/commit/d0845aadc629cf10b8eee490a651c039750a1430
- 07:45 Ticket #148 (Add l10n_client UI / functionality to translate plural forms.) closed by
- fixed
- 07:25 Ticket #25 (Trap and log all errors) closed by
- fixed
- 07:25 Ticket #25 (Trap and log all errors) reopened by
- 07:24 Ticket #308 (ImageMagick) closed by
- wontfix
- 07:24 Ticket #308 (ImageMagick) reopened by
- 07:24 Ticket #303 (Browser hangs in server add module on large number of files (1500)) closed by
- duplicate
- 07:24 Ticket #303 (Browser hangs in server add module on large number of files (1500)) reopened by
- 07:23 Ticket #284 (Safari drops session) closed by
- worksforme
- 07:23 Ticket #284 (Safari drops session) reopened by
- 07:23 Ticket #281 (Rotating Images while in "Browse Album" view doesn't always rotate the ...) closed by
- duplicate
- 07:23 Ticket #281 (Rotating Images while in "Browse Album" view doesn't always rotate the ...) reopened by
- 07:22 Ticket #260 (gToolbar buttons need title text (or other pop-ups) to explain functions.) closed by
- fixed
- 07:22 Ticket #260 (gToolbar buttons need title text (or other pop-ups) to explain functions.) reopened by
- 07:22 Ticket #211 (Server add over 200 images hangs browser) closed by
- worksforme
- 07:21 Ticket #211 (Server add over 200 images hangs browser) reopened by
- 07:21 Ticket #225 (G2 Import: support more sort orders) closed by
- fixed
- 07:20 Ticket #225 (G2 Import: support more sort orders) reopened by
- 07:20 Ticket #222 (G2 Import: import origination timestamps from g2) closed by
- fixed
- 07:20 Ticket #222 (G2 Import: import origination timestamps from g2) reopened by
- 07:19 Ticket #217 (server_add doesn't understand folder names that are numerical only) closed by
- fixed
- 07:19 Ticket #217 (server_add doesn't understand folder names that are numerical only) reopened by
- 07:19 Ticket #209 (Delete sometimes deletes the image to the left) closed by
- duplicate
- 07:18 Ticket #209 (Delete sometimes deletes the image to the left) reopened by
- 07:18 Ticket #124 (Show appropriate EXIF data) closed by
- fixed
- 07:18 Ticket #124 (Show appropriate EXIF data) reopened by
- 07:01 Ticket #327 (Recaptcha goes away when comment addition fails) closed by
- fixed
- 06:29 Ticket #326 (Server add must be restricted to admins only) closed by
- fixed
- 06:27 Ticket #297 (Organize: Handle dialog resize) closed by
- duplicate: Superseded by #325
- 06:26 Ticket #298 (Organize: Implement Edit Tags functionality) closed by
- fixed: Implemented a rudimentary tag edit capability
- 06:25 Ticket #262 (Organize: Album tree not synchronized on open) closed by
- duplicate: Superseded by #325
- 06:24 Ticket #267 (Organize: Using the lasso doesn't scroll) closed by
- duplicate: Superseded by #325
- 06:23 Ticket #266 (Organize: Scrolling looses selection) closed by
- duplicate: Superseded by #325
- 06:23 Ticket #261 (Organize: Enable Drag from album tree) closed by
- duplicate: Superseded by #325
- 06:22 Ticket #296 (Organize: Renaming the album in organize cause error on exit) closed by
- duplicate: Superseded by #325
- 06:22 Ticket #289 (Organize:Integrate organize into core) closed by
- duplicate: Superseded by #325
- 04:45 Ticket #330 (Login page in default theme looks yucky) created by
-
To reproduce, edit the permissions on your gallery and deny "view" permissions to guests. Then go to the main url and log out.
- 04:38 Ticket #329 (Admin > Languages page looks like poo) created by
-
It does. Really.
- 04:35 Ticket #328 (The pager on /admin/comments displays vertically) created by
-
See screenshot
- 04:32 Ticket #327 (Recaptcha goes away when comment addition fails) created by
-
Enable recaptcha then as a guest, try adding a comment and leave out the name field. You get the form back, but missing the recaptcha.
- 03:35 Ticket #326 (Server add must be restricted to admins only) created by
- 03:32 Ticket #325 (Organize needs a complete rewrite) created by
-
The version in beta 1 is a great prototype, but it's sprawling and needs to be boiled down to a clear and more concise version, with security considered from the beginning.
- 03:32 Ticket #324 (Server Add needs a complete rewrite) created by
-
We need to change it to do the work on the server side. The current model won't scale at all and is very difficult to contain from a security perspective.
06/01/09:
- 05:27 Ticket #316 (The link on the Permissions AllowOverride error message is not found) closed by
- fixed
- 05:13 Ticket #128 (urlencoding ~ in urls breaks thumbnail urls when passed through file_proxy) closed by
- fixed: Fixed in b6c99a062bbc8e4316929a73be03969d9d6cd2b2 Thanks ck!
- 04:49 Ticket #323 (Graphics toolkit is not auto-detected at install time) closed by
- fixed: Fixed in 8ebd941c81070b1454ff5e4ab97b4f3e14cbf345
- 04:44 Ticket #323 (Graphics toolkit is not auto-detected at install time) created by
-
Post-install tasks are run the first time an admin user logs in, for want of a better trigger. But when we specify the admin user via the installer so that we can bring up the welcome message, we don't actually call user::login() so it doesn't work.
This is broken since f24c8f66ea9673d812c882dd7db6fbe49bd01dfb
- 04:35 Ticket #239 (G2 import fails on PSD image) closed by
- worksforme
- 04:35 Ticket #239 (G2 import fails on PSD image) reopened by
05/31/09:
- 21:45 Ticket #188 (make Add Photo more prominent) closed by
- duplicate: this is a duplicate of #322
- 21:37 Ticket #91 (Lightbox Module) closed by
- fixed: The lightbox module is working. Should be added to gallery3-contrib on github.com
- 21:12 Ticket #187 (text mode, image mode, and dual text/image mode for buttons) closed by
- wontfix: This is not a defect, it's an enhancement request. There are now currently title tags for all icons, which are displayed as tooltips/help text by the browser. This request was discussed and although the suggestion is often employed in desktop apps, it's not common among web apps. This is not to say that we don't agree with the point, but this is beyond our current scope. Individuals who'd like this in their Gallery 3 instances can create a theme which uses text + icons or just text.
- 21:07 Ticket #186 (tooltips for all buttons please) closed by
- fixed: There are currently title tags for all icons, which are displayed as tooltips/help text by the browser. Won't go beyond this right now.
- 20:58 Ticket #93 (Find/make a better notification icon) closed by
- fixed: I'm marking this as completed for now. An envelope icons denotes email only but there's a possibility that RSS may be supported in the future. There are two other icons to consider that Ben Dunkle's created, an alarm clock and a bullhorn. I've put the bull horn in and am closing this. http://fieldii.com/gallery_icons/ico-watch.png http://fieldii.com/gallery_icons/ico-watch2.png
- 19:54 Ticket #321 (FLV movies don't show up) closed by
- fixed
- 19:54 Ticket #322 (Make adding photos more prominent in the site menu) created by
-
Create a new menu item 'add photos' to have a prominent, discoverable way for people to start uploading.
It should not be a dropdown menu if there is only one upload method available. Otherwise the dropdown will show all the options: via browser, via server add, ...
It's not clear whether add album should be integrated as well?
- 19:35 Ticket #321 (FLV movies don't show up) created by
-
When I click through on a movie, on the resize page I can hear the movie but I can't see it. This happens on Firefox 3 and dev Chrome.
Steps to repro:
1) Add the attached FLV
2) click its thumbnail
3) see no movie (but hear it)
- 19:31 Ticket #320 (Rename Item_Model::{thumb,movie,resize}_tag() to xxx_image() for clarity) created by
-
The "tag" part of the function name makes me think that it's related to the tags module. We should rename them to, eg: thumb_img() since it's an <img> element.
- 19:30 Ticket #319 (Use Item_Model::movie_tag in themes/default/views/movie.html) created by
-
Right now the theme hardcodes FlowPlayer?, which is nice, we should really be providing a sane default so that themers don't have to think about it.
- 17:08 Ticket #318 (Optimize default theme CSS) created by
-
This should be done before the separation of the admin_default and default themes, ticket #48
- 05:22 Ticket #244 (Running list of IE 6-8 UI and style issues) closed by
- fixed: Fixed in several recent commits.
05/30/09:
- 19:10 Ticket #317 (Rename theme_details controller/views to theme_options to match menu label) created by
- 07:00 Ticket #316 (The link on the Permissions AllowOverride error message is not found) created by
-
When allowoverride is not set an error message is produced which contains a link. The link points at a non existent page.
- 04:43 Ticket #240 (Don't allow spaces/special characters in short urls) closed by
- fixed
- 04:40 Ticket #315 (file_proxy shouldn't update the session) created by
-
On my system, 25% of the total time to fetch an image (using ab on the same box) is spent updating the sessions table. We don't need to do this. We should find a way to abort the session save handler before the request ends.
- 03:26 Ticket #164 (Move Gallery Project credits to Footer text db storage variable) closed by
- fixed: Fixed in 60d1bbc
- 00:55 Ticket #313 (Users without add permission can still access the "Add a photo" menu ...) closed by
- fixed: Fixed in 055e0a7..2925a1c
- 00:51 Ticket #314 (User can edit away their own edit permisison) created by
-
Give a non-admin group edit permissions to an album
Put a user in that group
Login as that user
Go to the album
Edit permissions
Click on the [x] next to "edit"
--> error
- 00:35 Ticket #313 (Users without add permission can still access the "Add a photo" menu ...) created by
-
We should both guard that in the menu and prvent the view from appearing in the controller.
05/29/09:
- 23:00 Ticket #312 (G2 Import should provide better logging for failed image imports) created by
-
Right now we just put up a temporary message and write it to the logs. We should provide a real, persistent report of some kind.
- 05:56 Ticket #311 (Replace Superfish with forthcoming jQuery UI Menu) created by
05/28/09:
- 07:46 Ticket #301 (Renaming the directory for the album you're currently in causes a 404) closed by
- fixed: Fixed in 8d2782ad1df10679b302ab6c4fafdd2f5535be4a
- 07:34 Ticket #176 (UX improvement: change label to add tag on album view) closed by
- fixed: Fixed in http://bit.ly/fnSsG
- 07:22 Ticket #302 (Watermark not Uploading) closed by
- fixed: This is a misconfiguration of the file info extension: http://us2.php.net/manual/en/book.fileinfo.php The extension is installed, so we try to use it. I don't think there's much we can do in the code to try to account for this kind of scenario; it needs to be fixed by your system administrator...sorry.
05/27/09:
- 06:18 Ticket #308 (ImageMagick) closed by
- wontfix: Gallery3 in a windows environment is not supported. If you have the same issues running in a linux environment please reopen the ticket.
05/26/09:
- 23:47 Changeset [20926] by
-
- gallery3/trunk/.htaccess
Oops, forgot to delete this too
- 23:46 Changeset [20925] by
-
- gallery3/trunk/GALLERY3_HAS_MOVED_TO_GIT
- gallery3/trunk/LICENSE
- gallery3/trunk/README
- gallery3/trunk/core
- gallery3/trunk/index.php
- gallery3/trunk/installer
- gallery3/trunk/kohana
- gallery3/trunk/lib
- gallery3/trunk/modules
- gallery3/trunk/themes
gallery3/trunk has moved to git
- 22:45 Changeset [20924] by
-
- gallery3/vendor/GALLERY3_HAS_MOVED_TO_GIT
- gallery3/vendor/README
- gallery3/vendor/exifer
- gallery3/vendor/flowplayer
- gallery3/vendor/forge
- gallery3/vendor/jquery
- gallery3/vendor/jquery-autocomplete
- gallery3/vendor/kohana
- gallery3/vendor/phpass
- gallery3/vendor/simple-uploader
- gallery3/vendor/superfish
- gallery3/vendor/swfupload
- gallery3/vendor/ui.jquery
- gallery3/vendor/ui.themeroller
gallery3/vendor has moved to git
- 20:35 Ticket #310 (Gallery3 not adding photos to albums with quotes in their name) created by
-
I am having 2-3 album names like
birthday's etc
which has single quote or special characters in their name
The photos i upload to such albums are nowhere seen, when checked the var folder, i found the album folder itself is not created and images were not getting uploaded.
When i uploaded same photos to album without special characters or quotes in their name, it uploaded fine.
- 20:28 Ticket #309 (Permissions for single album) created by
-
I am running latest svn version
I am having problems setting permissions. Suppose i have 3 albums, a b and c. I need only b to be public and rest a and c for registered users. please note all these a, b and c albums are in root folder, not one inside another
Now if i am restricting public access for a, it gets restricted for all albums in that folder, if i am giving public for b, all albums in that folder gets public access.
- 20:23 Changeset [20923] by
-
- gallery3/packaging/GALLERY3_HAS_MOVED_TO_GIT
- gallery3/packaging/ReleaseChecklist
- gallery3/packaging/build.php
gallery3/packaging has moved to git
- 20:20 Ticket #308 (ImageMagick) created by
-
I am having a windows wamp installation. I have gallery2 and gallery3 installation on same setup.
In gallery2 i can give path to my imagemagick location and it detects fine and works fine. but in gallery3 i dont have an option in adminUI to give path to imagemagick installation and also it doesnot detect on its own.
I tried editing the vars table in mysql giving graphics_toolkit and graphics_toolkit_path set in there, but even that is not getting gallery3 detect imagemagick working.
I know my imagemagick installation is not faulty as it has been working with path defined in gallery2 for quiet a long time and with other apps too.
Please provide a solution to this.
I am currently running latest to the minute CVN version
- 20:17 Ticket #307 (Gallery3 having problems with private galleries) created by
-
my version is
latest cvn 20922
I imported my gallery3 installation properly. All albums are displaying fine.
the point about my gallery is all albums are private. I mean all albums are available to registered users only. When i change permissions to be given access to only registered users(ie. no access for everyone group), some albums stop displaying pictures and even the album cover.
This gets fixed when i give permission for everyone group
ie. some album pics are not displayed even when i am logged in as administrator
- 14:43 Changeset [20922] by
-
- gallery3/trunk/core/controllers/core_organize.php
- gallery3/trunk/core/helpers/core_event.php
- gallery3/trunk/core/helpers/core_organize.php
- gallery3/trunk/modules/organize/controllers/organize.php
- gallery3/trunk/modules/organize/helpers/organize.php
- gallery3/trunk/modules/tag/controllers/tags.php
- gallery3/trunk/modules/tag/helpers/tag.php
- gallery3/trunk/modules/tag/helpers/tag_event.php
Since organize is now in the preview stage and will probably be
rewritten by beta2, pull all of its "tenticles" back into itself and
out of core or tags module.
- 06:01 Changeset [20921] by
-
- gallery3/trunk/core/controllers/scaffold.php
- gallery3/trunk/core/helpers/core_installer.php
- gallery3/trunk/core/helpers/graphics.php
- gallery3/trunk/core/helpers/log.php
- gallery3/trunk/core/helpers/module.php
- gallery3/trunk/modules/exif/helpers/exif_installer.php
- gallery3/trunk/modules/search/helpers/search_installer.php
clean up whitespace errors introduced in last commit
- 05:29 Ticket #306 (Refactor dialog, panel, and other js to use jQuery .live()) created by
-
http://docs.jquery.com/Events/live
Doing so will eliminate hacks to reapply event handlers to elements loaded via ajax, see #144
- 05:28 Changeset [20920] by
-
- gallery3/trunk/core/controllers/admin_modules.php
- gallery3/trunk/core/controllers/scaffold.php
- gallery3/trunk/core/helpers/access.php
- gallery3/trunk/core/helpers/block_manager.php
- gallery3/trunk/core/helpers/core.php
- gallery3/trunk/core/helpers/core_installer.php
- gallery3/trunk/core/helpers/core_menu.php
- gallery3/trunk/core/helpers/graphics.php
- gallery3/trunk/core/helpers/log.php
- gallery3/trunk/core/helpers/module.php
- gallery3/trunk/core/helpers/task.php
- gallery3/trunk/core/hooks/init_gallery.php
- gallery3/trunk/core/libraries/Admin_View.php
- gallery3/trunk/core/libraries/Theme_View.php
- gallery3/trunk/core/views/admin_modules.html.php
- gallery3/trunk/core/views/kohana_error_page.php
- gallery3/trunk/installer/install.sql
- gallery3/trunk/modules/akismet/helpers/akismet_installer.php
- gallery3/trunk/modules/comment/helpers/comment_installer.php
- gallery3/trunk/modules/exif/helpers/exif_installer.php
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
- gallery3/trunk/modules/g2_import/helpers/g2_import_installer.php
- gallery3/trunk/modules/gallery_unit_test/controllers/gallery_unit_test.php
- gallery3/trunk/modules/image_block/helpers/image_block_installer.php
- gallery3/trunk/modules/info/helpers/info_installer.php
- gallery3/trunk/modules/notification/helpers/notification_installer.php
- gallery3/trunk/modules/organize/helpers/organize_installer.php
- gallery3/trunk/modules/recaptcha/helpers/recaptcha_installer.php
- gallery3/trunk/modules/rss/helpers/rss_installer.php
- gallery3/trunk/modules/search/helpers/search.php
- gallery3/trunk/modules/search/helpers/search_installer.php
- gallery3/trunk/modules/server_add/helpers/server_add_installer.php
- gallery3/trunk/modules/slideshow/helpers/slideshow_event.php
- gallery3/trunk/modules/slideshow/helpers/slideshow_installer.php
- gallery3/trunk/modules/tag/helpers/tag_installer.php
- gallery3/trunk/modules/user/helpers/user_installer.php
- gallery3/trunk/modules/watermark/helpers/watermark_installer.php
Restructure the module lifecycle.
Install: <module>_installer::install() is called, any necessary tables
are created.
Activate: <module>_installer::activate() is called. Module
controllers are routable, helpers are accessible, etc. The module is
in use.
Deactivate: <module>_installer::deactivate() is called. Module code
is not accessible or routable. Module is *not* in use, but its tables
are still around.
Uninstall: <module>_installer::uninstall() is called. Module is
completely removed from the database.
Admin > Modules will install and activate modules, but will only
deactivate (will NOT uninstall modules).
- 05:05 Ticket #144 (Deleting a group doesn't show up in the popup window) closed by
- fixed: Fixed in r20919
- 05:05 Changeset [20919] by
-
- gallery3/trunk/modules/user/views/admin_users.html.php
Quick fix for ticket #144. Reapply event handler for delete link gDialog when group is refreshed.
- 05:00 Changeset [20918] by
-
- gallery3/trunk/modules/user/helpers/user_theme.php
- gallery3/trunk/modules/user/views/admin_users.html.php
Link to gallery.panel.js from the head, not body.
- 04:56 Changeset [20917] by
-
- gallery3/trunk/lib/gallery.panel.js
Fixed docblock reference
- 04:18 Changeset [20916] by
-
- gallery3/trunk/core/tests/File_Structure_Test.php
Ignore index.local.php
- 03:59 Changeset [20915] by
-
- gallery3/trunk/lib/gallery.common.js
- gallery3/trunk/lib/gallery.form.js
- gallery3/trunk/lib/gallery.panel.js
- gallery3/trunk/modules/user/views/admin_users.html.php
- gallery3/trunk/themes/admin_default/js/ui.init.js
- gallery3/trunk/themes/admin_default/views/admin.html.php
- gallery3/trunk/themes/default/js/ui.init.js
- gallery3/trunk/themes/default/views/page.html.php
Split out re-used JavaScript? for common functions (messages, valign), panel toggle, and forms to external files.
- 01:53 Changeset [20914] by
-
- gallery3/trunk/modules/user/controllers/admin_users.php
- gallery3/trunk/modules/user/helpers/user.php
White space fixes
05/25/09:
- 20:46 Changeset [20913] by
-
- gallery3/trunk/modules/user/helpers/user.php
Changed name to username in user admin form labels
- 19:48 Ticket #305 (Refactor module admin UI to handle de-activate and uninstall actions) created by
-
-devel message from Bharat:
(stream of consciousness type response as I go through the code, with some conclusions at the end)
I've been going through the various modules to understand the
implications of trying to get this right. The states that I think
are necessary are:
Uninstalled:
- the module does not exist in the database and is not available
to the rest of the code.
Installed: but inactive:
- the module exists in the database
- the module code (hooks, theme callbacks, etc) are NOT ACTIVE
- database tables MAY be out of date (ie: it may require an
upgrade before you can activate it).
Installed and active:
- the module exists and is up to date in the database
- the module code (hooks, theme callbacks, etc) are ACTIVE
With those states, let's consider a few modules:
Watermark module:
- deactivate and then reactivate it, you should not have to
rebuild all of your thumbnails/resizes
- uninstall it and all your watermarks should go away
Tag module:
- deactivate then reactivate should leave your tag data unchanged
- uninstall it and all your tags should go away
Recaptcha module:
- deactivate then reactivate should preserve your settings
Open issues/thoughts:
1) Deactivated modules won't have up-to-date data. Scenario: we
apply tags to a photo, then deactivate the tag module, then delete the photo, then reactivate the tag module. Upon reactivation, the tag module needs to make sure that its data is clean. This applies to any module that has data related to items. The exif and search modules have maintenance tasks to take care of this scenario so they're covered, but comments, tags, and notification don't.
CONCLUSIONS
Having thought about this a bit I think that we need to give modules the ability to separate activation from installation. So I'm thinking that we'll extend the installer API to have activate() and deactivate() calls. Invariants that the framework enforces:
* We always call install() before activate()
* We always call deactivate() before calling uninstall()
* Modules which are not activated are not accessible in the code
The admin UI can remain exactly the same. It'd work like this:
* If you check the box next to a module (ie, you're saying "I want to use this module") then we call install() followed by activate().
* If you uncheck the box next to a module ("I don't want to use
this") then we call deactivate() BUT WE DON'T CALL UNINSTALL().
- 06:12 Changeset [20912] by
-
- gallery3/trunk/modules/organize/helpers/organize_installer.php
Delete placeholder comments.
05/24/09:
- 20:19 Ticket #260 (gToolbar buttons need title text (or other pop-ups) to explain functions.) closed by
- fixed: fixed in SVN
- 18:27 Changeset [20911] by
-
- gallery3/trunk/core/helpers/module.php
Partially revert r20906 -- it was breaking the test framework.
- 09:19 Changeset [20910] by
-
- gallery3/trunk/core/helpers/photo.php
Make img_dimensions() return early if the width or height is zero (probably a broken image).
- 06:45 Changeset [20909] by
-
- gallery3/vendor/kohana/README
Add ref to ticket 1695
- 06:43 Changeset [20908] by
-
- gallery3/trunk/kohana/core/Kohana.php
Change Kohana::include_path() to put APPPATH (core) at the end of the
module list so that all modules can override core views and helpers,
etc for max application flexibility.
- 06:12 Changeset [20907] by
-
- gallery3/trunk/core/helpers/module.php
Ignore core when we're loading modules (it's not a module!)
- 06:11 Changeset [20906] by
-
- gallery3/trunk/modules/user/helpers/user.php
Use phpass as our hashing mechanism, and check for it first (instead
of checking G1/G2 techniquew first).
- 06:10 Changeset [20905] by
-
- gallery3/trunk
- gallery3/trunk/index.php
Add support for index.local.php where you can override any existing settings (useful for developers). This might be a bad idea; trying it out for now.
05/23/09:
- 13:47 Ticket #304 (Thumbnail too large after rotate (OK after refresh)) created by
-
After rotate, the thumbnail image is too large. When the page is then refreshed, the thumbnail image is OK.
Please see attached files for more info and to reproduce:
- before: image before rotate
- afterRotate: image after rotate (too large)
- afterRotateRefresh: proper image after refresh
- no apparent errors in log file
05/22/09:
- 21:11 Ticket #303 (Browser hangs in server add module on large number of files (1500)) closed by
- duplicate: Closing as a duplicate of #300
- 16:28 Ticket #303 (Browser hangs in server add module on large number of files (1500)) created by
-
Browser window hangs when adding a large number of files using server add. No apparent error is logged on either guest or host. Firefox error console shows no error. Apache error logs on server are clean. I suspect script is still running, waiting for input. This has occurred on both Firefox (win and lin) and IE7. Possible js limitation or bug?
To reproduce, attempt add 1500+ images at a time using server add module.
This will reproduce error: download this archive and unpack it in a server add directory then attempt to browse it.
http://www.trbailey.org/files/bizarre.tar.gz
Might I suggest an html only server add option?
It would be easier than trying to make the ajax box work, would it not? And this module is generally for admins only so it's doesn't need to be pretty.
- 16:14 Changeset [20904] by
-
- gallery3/trunk/modules/tag/controllers/tags.php
- gallery3/trunk/modules/tag/helpers/tag.php
- gallery3/trunk/modules/tag/helpers/tag_event.php
Implement a basic tag management interface with the organize drawer
- 16:13 Changeset [20903] by
-
- gallery3/trunk/modules/organize/js/organize.js
Set a minimum distance (10px) that the cursor has to move inorder for
the draggable functionality to be activated
- 00:12 Changeset [20902] by
-
- gallery3/trunk/themes/default/css/screen.css
- gallery3/trunk/themes/default/images/ico-album.png
- gallery3/trunk/themes/default/views/album.html.php
Added album icon before album titles. Thx again Ben.
05/21/09:
- 20:53 Ticket #302 (Watermark not Uploading) created by
-
When i try to upload a water mark image it just hangs and i see this error in the logs
<?php defined('SYSPATH') or die('No direct script access.'); ?> 2009-05-21 14:32:29 -04:00 --- error: Uncaught PHP Error: finfo_open() [<a href='function.finfo-open'>function.finfo-open</a>]: Failed to load magic database at '(null)'. in file kohana/helpers/file.php on line 51Let me know if you need any other info.
Thanks,
Peter
- 14:01 Changeset [20901] by
-
- gallery3/trunk/core/controllers/core_organize.php
- gallery3/trunk/core/helpers/core_event.php
- gallery3/trunk/core/helpers/core_organize.php
Standardize the method names
- 06:27 Changeset [20900] by
-
- gallery3/trunk/index.php
Set the error level to E_NONE for production.
- 06:20 Changeset [20899] by
-
- gallery3/trunk/core/config/cookie.php
Make our own cookie config and turn on the httponly setting.
- 06:06 Changeset [20898] by
-
- gallery3/trunk/core/controllers/permissions.php
- gallery3/trunk/core/helpers/access.php
- gallery3/trunk/core/views/permissions_browse.html.php
Check to make sure that our permission system is working and report
back to our users in the edit permissions dialog.
- 05:54 Changeset [20897] by
-
- gallery3/trunk/core/controllers/file_proxy.php
Ignore query parameters in the file proxy. This strips off the
recently added cache buster query param.
- 05:12 Ticket #284 (Safari drops session) closed by
- worksforme: Was unable to reproduce in Safari 4 beta, build 5528.16
- 05:07 Changeset [20896] by
-
- gallery3/trunk/core/views/permissions_browse.html.php
Minor cleanups.
- 04:50 Ticket #242 (Fix name field in the login/password reset dialog) closed by
- fixed: fixed in r20895
- 04:48 Changeset [20895] by
-
- gallery3/trunk/modules/user/controllers/password.php
- gallery3/trunk/modules/user/helpers/user.php
Changed Name label to Username, closes ticket #93
- 04:19 Ticket #301 (Renaming the directory for the album you're currently in causes a 404) created by
-
Steps to repro:
1) create album test
2) browse to album test
3) edit album
4) change directory name from "test" to "foo"
5) click "save"
--> error page
It's trying to get to /test but it needs to go to /foo now.
- 04:15 Ticket #300 (Server Add is very inefficient with large data sets) created by
-
When adding large chunks of images, the server_add tree is very slow to get data from the server, and provides no feedback during the upload process. It *works*, it just doesn't give us any feedback during the process.
- 04:13 Ticket #211 (Server add over 200 images hangs browser) closed by
- worksforme: I can't make heads or tails of that description. I was able to add a large set of photos via server add, but it was very slow and unresponsive during the operation. I'm going to close this bug and file a new one about it with a better summary against B2.
- 04:05 Changeset [20894] by
-
- gallery3/trunk/modules/server_add/controllers/server_add.php
Change $view->action to a absolute url.
- 03:50 Ticket #299 (Notification takes you back to an error page) closed by
- fixed: Fixed in r20893
- 03:50 Changeset [20893] by
-
- gallery3/trunk/modules/notification/controllers/notification.php
Redirect after success to the absolute url
- 03:50 Ticket #299 (Notification takes you back to an error page) created by
-
Clicking the "watch" button takes you to an error page. When you return to the right page, the watch state has successfully changed.
- 03:42 Ticket #274 (Database errors cause database url, username, and password to be shown in ...) closed by
- fixed
- 03:42 Changeset [20892] by
-
- gallery3/trunk/index.php
Set display_errors to false for security.
- 03:38 Changeset [20891] by
-
- gallery3/trunk/themes/default/css/screen.css
- gallery3/trunk/themes/default/images/ico-watch-add.png
- gallery3/trunk/themes/default/images/ico-watch-remove.png
Added Ben Dunkle's current watch icon. Renamed icon file name to keep 'em grouped
- 02:26 Ticket #241 (Ask for confirmation before deleting) closed by
- fixed: Implemented delete confirmation with r20890.
- 02:24 Changeset [20890] by
-
- gallery3/trunk/core/js/quick.js
- gallery3/trunk/core/views/quick_pane.html.php
- gallery3/trunk/modules/organize/js/organize.js
- gallery3/trunk/modules/organize/views/organize.html.php
Provide delete confirmations in quick pane and organize features. If
I've missed any spots let me know.
- 02:03 Changeset [20889] by
-
- gallery3/trunk/core/helpers/core_theme.php
- gallery3/trunk/themes/default/views/footer.html.php
Fix the admin credits, too
- 02:00 Changeset [20888] by
-
- gallery3/trunk/core/helpers/core_theme.php
- gallery3/trunk/themes/default/views/footer.html.php
Move the credits string into core_theme::credits()
- 01:36 Ticket #231 (Organize needs the editing component) closed by
- fixed: implemented as r20887
- 01:31 Changeset [20887] by
-
- gallery3/trunk/core/controllers/core_organize.php
- gallery3/trunk/core/helpers/core_event.php
- gallery3/trunk/core/helpers/core_organize.php
- gallery3/trunk/core/helpers/item.php
- gallery3/trunk/core/views/organize_edit_general.html.php
- gallery3/trunk/core/views/organize_edit_sort.html.php
- gallery3/trunk/modules/organize/css/organize.css
- gallery3/trunk/modules/organize/js/organize.js
- gallery3/trunk/modules/organize/views/organize.html.php
- gallery3/trunk/modules/organize/views/organize_button_pane.html.php
- gallery3/trunk/modules/organize/views/organize_edit.html.php
- gallery3/trunk/modules/tag/helpers/tag_event.php
- gallery3/trunk/modules/tag/views/tag_organize.html.php
1) This provides the editting functionality for albums and photos in the
organize feature.
2) Remove the tag functionality at this point
3) Added a callback to handle validating conflicting names (only used
by organize at this point.
4) Closes #231
- 01:26 Ticket #298 (Organize: Implement Edit Tags functionality) created by
- 00:22 Ticket #297 (Organize: Handle dialog resize) created by
-
Currently if the window changes size, the organize dialog box doesn't change size as well.
05/20/09:
- 23:58 Changeset [20886] by
-
- trunk/gallery2/bootstrap.inc
- trunk/gallery2/init.inc
- trunk/gallery2/lib/bbcode/stringparser.class.php
- trunk/gallery2/lib/bbcode/stringparser_bbcode.class.php
- trunk/gallery2/lib/tools/phpunit/index.php
- trunk/gallery2/modules/core/classes/GalleryPlatform.class
- trunk/gallery2/modules/core/classes/GalleryStorage.class
- trunk/gallery2/modules/core/classes/GalleryTemplateAdapter.class
- trunk/gallery2/modules/core/classes/GalleryUtilities.class
- trunk/gallery2/modules/core/test/phpunit/FactoryTest.class
- trunk/gallery2/modules/ffmpeg/classes/FfmpegToolkit.class
- trunk/gallery2/modules/imagemagick/classes/ImageMagickToolkit.class
- trunk/gallery2/modules/imagemagick/classes/ImageMagickToolkitHelper.class
- trunk/gallery2/modules/migrate/classes/Gallery1DataParser.class
- trunk/gallery2/modules/netpbm/classes/NetPbmToolkit.class
- trunk/gallery2/modules/rewrite/test/phpunit/RewriteHelperTest.class
- trunk/gallery2/modules/watermark/test/phpunit/WatermarkSiteAdminControllerTest.class
Updates for PHP 5.3:
- All date/time functions now require a default timezone to be set
(via ini setting or date_default_timezone_set function).
- All ereg functions are deprecated
- Using & with the "new" operator is deprecated
Review#800
- 21:33 Ticket #296 (Organize: Renaming the album in organize cause error on exit) created by
-
If you rename the album path of the album you are organizing then you get the attached error when exiting organize.
If you have this directory structure
A
B
and you start the organize on B, go up to A and edit B such that the path name is now b, will cause the error.
- 20:21 Ticket #295 (Click anywhere to close full size view) created by
-
The close button when viewing an image full size is small, and probably unnecessary anyway.
I suggest that the use be able to close the full size view by clicking anywhere.
- 16:49 Changeset [20885] by
-
- gallery3/trunk/core/helpers/core_event.php
- gallery3/trunk/modules/user/controllers/login.php
Move the first-admin-login steps out of the user module and into an event listener in core
- 16:42 Changeset [20884] by
-
- gallery3/trunk/core/helpers/graphics.php
Always set the graphics_toolkit_path, even if we're on GD. That'll
force it to show up in Admin > Settings > Advanced so that people can
easily forcefully change over to ImageMagick? or GraphicsMagick?.
- 07:00 Ticket #121 (New album covers don't always display correctly) closed by
- fixed: Fixed the cases where we show a distorted thumbnail by adding a cache buster in r20883. Not sure what's up with the half-gray image.. I don't think that's a Gallery bug since the browser is getting the thumbnail directly from Apache without any Gallery interaction there. Closing this as fixed.
- 06:58 Changeset [20883] by
-
- gallery3/trunk/core/models/item.php
Add a cache buster to thumbnail urls, using the item update time.
Fixes ticket #121.
- 06:13 Ticket #234 (Rotate keeps showing "loading" image in alpha 3) closed by
- fixed
- 06:10 Ticket #235 (Creating tmp table cause connection timeout in admin/maintenance) closed by
- fixed: r20882 takes care of the search module also. This should resolve the issue so I'm closing the bug. If you're still seeing performance issues here, please reopen this ticket.
- 06:10 Changeset [20882] by
-
- gallery3/trunk/modules/exif/helpers/exif.php
- gallery3/trunk/modules/exif/helpers/exif_installer.php
- gallery3/trunk/modules/exif/helpers/exif_task.php
- gallery3/trunk/modules/search/helpers/search.php
- gallery3/trunk/modules/search/helpers/search_event.php
- gallery3/trunk/modules/search/helpers/search_installer.php
- gallery3/trunk/modules/search/helpers/search_task.php
Avoid complex inserts in available_tasks() to make admin/maintenance
run faster. This fixes ticket #235.
Incidentally, refactor exif and search to use the same patterns
overall so that if you understand one, you understand the other and
they generally use the same strings for localization.
- 05:46 Changeset [20881] by
-
- gallery3/trunk/modules/exif/helpers/exif_task.php
Avoid doing an expensive insert in available_tasks(). Partial fix for ticket #235.
- 04:25 Ticket #294 (G2 Import should not try to import non gif/jpg/png) closed by
- fixed: Fix r20880
- 04:25 Changeset [20880] by
-
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
Don't import non-viewable image types (eg: psd). Swap in a broken
image instead so that we at least have a target for comments.
Fixes ticket #294
- 04:14 Ticket #294 (G2 Import should not try to import non gif/jpg/png) created by
-
We can't handle non image formats (eg: PSD) so don't import them. Import a placeholder of some kind instead and notify the user.
- 04:05 Ticket #293 (Provide a way to specify image quality level) closed by
- fixed: Done in r20879. You can configure the "image_quality" variable in via Admin > Settings > Advanced.
- 04:05 Ticket #293 (Provide a way to specify image quality level) created by
- 04:04 Changeset [20879] by
-
- gallery3/trunk/core/helpers/core_installer.php
- gallery3/trunk/core/helpers/graphics.php
- gallery3/trunk/installer/install.sql
Add a default image quality level. There's no UI for it, except Admin
Settings > Advanced. The default is 75.
- 03:41 Ticket #292 (admin/dashboard blocks should support cut and paste) created by
-
Especially the platform block. You *can* cut and paste by double clicking on a word and dragging, but single clicks drag the entire block.
- 03:30 Ticket #291 (The "cancel all" button should close the upload dialog) created by
-
The button cancels the file uploads, but doesn't close the dialog box.
- 03:24 Changeset [20878] by
-
- gallery3/trunk/core/views/quick_pane.html.php
Replace the old "add photo" form with the simple uploader version in
the "add a photo" quick menu option.
- 01:18 Changeset [20877] by
-
- gallery3/trunk/core/controllers/admin_modules.php
Fix a typo; swapped uninstalled and installed.
05/19/09:
- 21:01 Ticket #281 (Rotating Images while in "Browse Album" view doesn't always rotate the ...) closed by
- duplicate: Duplicate of #290
- 21:00 Ticket #209 (Delete sometimes deletes the image to the left) closed by
- duplicate: Duplicate of #290
- 21:00 Ticket #290 (Quick menu sometimes interacts with the wrong item) created by
-
Typically what I've seen is that you're moving the mouse over lots of images quickly, then you settle on an image and the quick bar comes up, but it's referencing the wrong image so you delete/rotate/edit/whatever the wrong image.
- 20:52 Ticket #289 (Organize:Integrate organize into core) created by
- 20:44 Ticket #239 (G2 import fails on PSD image) closed by
- worksforme: Closing this as "works for me". If you can reproduce it, please reopen.
- 07:31 Ticket #221 (G2 Import: album highlights) closed by
- fixed: Implemented in r20876
- 07:31 Changeset [20876] by
-
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
- gallery3/trunk/modules/g2_import/helpers/g2_import_task.php
Import album highlights. Fixes ticket #221.
- 05:59 Ticket #288 (Rollup multiple module action status messages into a summary message) closed by
- fixed: Fixed in r20875
- 05:59 Changeset [20875] by
-
- gallery3/trunk/core/controllers/admin_modules.php
Collate install/uninstall messages. Fixes ticket #288
- 04:32 Ticket #288 (Rollup multiple module action status messages into a summary message) created by
-
Instead of showing N number of messages, show a single summary message, ex. The selected modules have been activated
- 04:20 Changeset [20874] by
-
- gallery3/trunk/modules
- gallery3/trunk/modules/comment/helpers/comment_menu.php
Rolled back r20813 to restore jump to comments, at least for now
- 04:17 Changeset [20873] by
-
- gallery3/trunk/themes/default/images/ico-view-album.png
- gallery3/trunk/themes/default/images/ico-view-comments.png
- gallery3/trunk/themes/default/images/ico-view-fullsize.png
- gallery3/trunk/themes/default/images/ico-view-hybrid.png
- gallery3/trunk/themes/default/images/ico-view-slideshow.png
- gallery3/trunk/themes/default/js/ui.init.js
Added the nice new icons for the view buttons. No need to have them in a jQuery UI button, they stand well on their own. Thx to Ben Dunkle!
- 03:54 Ticket #287 (G2 Import bombs when the G2 is missing a source image) closed by
- fixed: Fixed in r20872
- 03:54 Changeset [20872] by
-
- gallery3/trunk/modules/g2_import/data
- gallery3/trunk/modules/g2_import/data/broken-image.gif
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
If there's a missing source image during import, swap in our "broken
image" placeholder and keep on trucking. Oh, and notify the admin.
Fixes ticket #287
- 03:53 Ticket #287 (G2 Import bombs when the G2 is missing a source image) created by
-
You get a stack trace like this:
2009-05-16 23:42:39 -04:00 --- error: @todo MISSING_IMAGE_FILE in /var/www/html/newgallery/core/helpers/photo.php at line 43:
#0 /var/www/html/newgallery/modules/g2_import/helpers/g2_import.php(295): photo_Core::create(Object(Item_Model), '/var/ourgallery...', 'IMG_0373.JPG', 'IMG_0373', NULL, 3)
#1 /var/www/html/newgallery/modules/g2_import/helpers/g2_import_task.php(125): g2_import_Core::import_item(Array)
#2 [internal function]: g2_import_task_Core::import(Object(Task_Model))
#3 /var/www/html/newgallery/core/helpers/task.php(78): call_user_func_array('g2_import_task:...', Array)
#4 /var/www/html/newgallery/core/controllers/admin_maintenance.php(140): task_Core::run('1')
#5 [internal function]: Admin_Maintenance_Controller->run('1')
#6 /var/www/html/newgallery/core/controllers/admin.php(49): call_user_func_array(Array, Array)
#7 [internal function]: Admin_Controller->call('maintenance', Array)
#8 /var/www/html/newgallery/kohana/core/Kohana.php(277): ReflectionMethod?->invokeArgs(Object(Admin_Controller), Array)
#9 [internal function]: Kohana::instance()
#10 /var/www/html/newgallery/kohana/core/Event.php(209): call_user_func(Array)
#11 /var/www/html/newgallery/kohana/core/Bootstrap.php(55): Event::run('system.execute')
#12 /var/www/html/newgallery/index.php(61): require('/var/www/html/n...')
#13 {main}
05/18/09:
- 19:34 Changeset [20871] by
-
- gallery3/trunk/core/helpers/core_event.php
- gallery3/trunk/core/views/organize_edit_general.html.php
- gallery3/trunk/core/views/organize_edit_sort.html.php
- gallery3/trunk/modules/organize/controllers/organize.php
- gallery3/trunk/modules/organize/css/organize.css
- gallery3/trunk/modules/organize/js/organize.js
- gallery3/trunk/modules/organize/views/organize.html.php
- gallery3/trunk/modules/organize/views/organize_edit.html.php
- gallery3/trunk/modules/tag/helpers/tag_event.php
- gallery3/trunk/modules/tag/views/tag_organize.html.php
This takes us the next step closer to providing bulk edit. We still
can't edit, but we are getting closer :-).
This change sets up a framework for modules to contribute edit panels
to the organize drawer. Currently implemented General (albums and
photos), Sort Order (albums only) and Manage Tags
- 06:30 Changeset [20870] by
-
- gallery3/trunk/core/libraries/MY_View.php
- gallery3/trunk/core/views/kohana_error_page.php
- gallery3/trunk/index.php
Turn on IN_PRODUCTION mode now across the board. Create our own error
page where we'll show whatever information is useful. Get rid of the
IN_PRODUCTION hack in MY_View.php that we no longer need.
- 06:22 Changeset [20869] by
-
- gallery3/trunk/core/tests/File_Structure_Test.php
Update filters
- 04:52 Changeset [20868] by
-
- gallery3/trunk/core/tests/File_Structure_Test.php
update PasswordHash? path
- 04:21 Changeset [20867] by
-
- gallery3/trunk/core/controllers/admin_modules.php
verify csrf when installing/uninstalling modules
- 04:20 Changeset [20866] by
-
- gallery3/trunk/core/controllers/scaffold.php
Clean up tmp when packaging
- 04:15 Changeset [20865] by
-
- gallery3/trunk/core/tests/File_Structure_Test.php
Restructure the code preamble checking tests to check all PHP files,
not just the ones that we created ourselves.
- 04:13 Changeset [20864] by
-
- gallery3/trunk/modules/user/lib
- gallery3/trunk/modules/user/lib/PasswordHash.php
Get rid of trailing whitespace in security preamble
- 04:05 Changeset [20863] by
-
- gallery3/vendor/phpass/refresh_modified.sh
Get rid of trailing whitespace in preamble
- 04:05 Changeset [20862] by
-
- gallery3/vendor/phpass/modified/PasswordHash.php
Get rid of trailing whitespace in preamble
- 04:03 Changeset [20861] by
-
- gallery3/vendor/README
phpass has its own README now
- 04:03 Changeset [20860] by
-
- gallery3/vendor/exifer/refresh_modified.sh
Get rid of trailing whitespace in preamble
- 04:02 Changeset [20859] by
-
- gallery3/trunk/modules/forge
- gallery3/trunk/modules/forge/libraries/Forge.php
- gallery3/trunk/modules/forge/libraries/Form_Checkbox.php
- gallery3/trunk/modules/forge/libraries/Form_Checklist.php
- gallery3/trunk/modules/forge/libraries/Form_Dateselect.php
- gallery3/trunk/modules/forge/libraries/Form_Dropdown.php
- gallery3/trunk/modules/forge/libraries/Form_Group.php
- gallery3/trunk/modules/forge/libraries/Form_Hidden.php
- gallery3/trunk/modules/forge/libraries/Form_Input.php
- gallery3/trunk/modules/forge/libraries/Form_Password.php
- gallery3/trunk/modules/forge/libraries/Form_Phonenumber.php
- gallery3/trunk/modules/forge/libraries/Form_Radio.php
- gallery3/trunk/modules/forge/libraries/Form_Submit.php
- gallery3/trunk/modules/forge/libraries/Form_Textarea.php
- gallery3/trunk/modules/forge/libraries/Form_Upload.php
Get rid of trailing whitespace in preamble
- 04:01 Changeset [20858] by
-
- gallery3/vendor/forge/refresh_modified.sh
Get rid of trailing whitespace
- 04:01 Changeset [20857] by
-
- gallery3/vendor/forge/modified/libraries/Forge.php
- gallery3/vendor/forge/modified/libraries/Form_Checkbox.php
- gallery3/vendor/forge/modified/libraries/Form_Checklist.php
- gallery3/vendor/forge/modified/libraries/Form_Dateselect.php
- gallery3/vendor/forge/modified/libraries/Form_Dropdown.php
- gallery3/vendor/forge/modified/libraries/Form_Group.php
- gallery3/vendor/forge/modified/libraries/Form_Hidden.php
- gallery3/vendor/forge/modified/libraries/Form_Input.php
- gallery3/vendor/forge/modified/libraries/Form_Password.php
- gallery3/vendor/forge/modified/libraries/Form_Phonenumber.php
- gallery3/vendor/forge/modified/libraries/Form_Radio.php
- gallery3/vendor/forge/modified/libraries/Form_Submit.php
- gallery3/vendor/forge/modified/libraries/Form_Textarea.php
- gallery3/vendor/forge/modified/libraries/Form_Upload.php
Get rid of trailing whitespace
- 04:00 Changeset [20856] by
-
- gallery3/trunk/modules/exif/lib
- gallery3/trunk/modules/exif/lib/exif.php
- gallery3/trunk/modules/exif/lib/makers/canon.php
- gallery3/trunk/modules/exif/lib/makers/fujifilm.php
- gallery3/trunk/modules/exif/lib/makers/gps.php
- gallery3/trunk/modules/exif/lib/makers/nikon.php
- gallery3/trunk/modules/exif/lib/makers/olympus.php
- gallery3/trunk/modules/exif/lib/makers/panasonic.php
- gallery3/trunk/modules/exif/lib/makers/sanyo.php
Update preamble to avoid extra opening php block
- 03:58 Changeset [20855] by
-
- gallery3/vendor/exifer/modified/exif.php
- gallery3/vendor/exifer/modified/makers/canon.php
- gallery3/vendor/exifer/modified/makers/fujifilm.php
- gallery3/vendor/exifer/modified/makers/gps.php
- gallery3/vendor/exifer/modified/makers/nikon.php
- gallery3/vendor/exifer/modified/makers/olympus.php
- gallery3/vendor/exifer/modified/makers/panasonic.php
- gallery3/vendor/exifer/modified/makers/sanyo.php
Update preamble to avoid extra opening php block
- 03:55 Changeset [20854] by
-
- gallery3/trunk/modules/gallery_unit_test/views/kohana_error_page.php
- gallery3/trunk/modules/gallery_unit_test/views/kohana_unit_test_cli.php
Fix security preambles
- 03:51 Changeset [20853] by
-
- gallery3/trunk/modules/user/lib/PasswordHash.php
Add security preamble
- 03:50 Changeset [20852] by
-
- gallery3/vendor/phpass/modified
- gallery3/vendor/phpass/modified/PasswordHash.php
- gallery3/vendor/phpass/refresh_modified.sh
- gallery3/vendor/phpass/refresh_upstream.sh
Delete everything we don't want from modified, and add a preamble to the file as appropriate. Create refresh scripts
- 03:48 Changeset [20851] by
-
- gallery3/vendor/phpass/upstream/test.php
Oops, this is part of the upstream package
- 03:44 Changeset [20850] by
-
- gallery3/vendor/phpass/README
- gallery3/vendor/phpass/upstream
- gallery3/vendor/phpass/upstream/PasswordHash.php
- gallery3/vendor/phpass/upstream/c
First pass at restructuring this package for consistency with other vendor packages
- 03:39 Changeset [20849] by
-
- gallery3/trunk/modules/user/helpers/user.php
- gallery3/trunk/modules/user/lib
Move 3rd party PasswordHash? library into the "lib" dir for
consistency. No 3rd party libs in "libraries", at least for now.
- 03:34 Changeset [20848] by
-
- gallery3/trunk/modules/unit_test
- gallery3/trunk/modules/unit_test/views
Remove modules/unit_test/views; we don't use them
- 03:32 Changeset [20847] by
-
- gallery3/vendor/kohana/refresh_modified.sh
Remove unit_test views; we don't use them
- 03:32 Changeset [20846] by
-
- gallery3/vendor/kohana/modified/modules/unit_test/views
Remove unit_test views; we don't use them
- 03:28 Changeset [20845] by
-
- gallery3/trunk/modules/forge
- gallery3/trunk/modules/forge/libraries/Forge.php
- gallery3/trunk/modules/forge/libraries/Form_Checkbox.php
- gallery3/trunk/modules/forge/libraries/Form_Checklist.php
- gallery3/trunk/modules/forge/libraries/Form_Dateselect.php
- gallery3/trunk/modules/forge/libraries/Form_Dropdown.php
- gallery3/trunk/modules/forge/libraries/Form_Group.php
- gallery3/trunk/modules/forge/libraries/Form_Hidden.php
- gallery3/trunk/modules/forge/libraries/Form_Input.php
- gallery3/trunk/modules/forge/libraries/Form_Password.php
- gallery3/trunk/modules/forge/libraries/Form_Phonenumber.php
- gallery3/trunk/modules/forge/libraries/Form_Radio.php
- gallery3/trunk/modules/forge/libraries/Form_Submit.php
- gallery3/trunk/modules/forge/libraries/Form_Textarea.php
- gallery3/trunk/modules/forge/libraries/Form_Upload.php
Merged /gallery3/vendor/forge/modified:r20843
Added preamble to all Forge files.
- 01:09 Changeset [20844] by
-
- gallery3/vendor/forge/refresh_modified.sh
Drop unnecesary dirs, add preamble to whatever's left
- 01:01 Changeset [20843] by
-
- gallery3/vendor/forge/modified/libraries/Forge.php
- gallery3/vendor/forge/modified/libraries/Form_Checkbox.php
- gallery3/vendor/forge/modified/libraries/Form_Checklist.php
- gallery3/vendor/forge/modified/libraries/Form_Dateselect.php
- gallery3/vendor/forge/modified/libraries/Form_Dropdown.php
- gallery3/vendor/forge/modified/libraries/Form_Group.php
- gallery3/vendor/forge/modified/libraries/Form_Hidden.php
- gallery3/vendor/forge/modified/libraries/Form_Input.php
- gallery3/vendor/forge/modified/libraries/Form_Password.php
- gallery3/vendor/forge/modified/libraries/Form_Phonenumber.php
- gallery3/vendor/forge/modified/libraries/Form_Radio.php
- gallery3/vendor/forge/modified/libraries/Form_Submit.php
- gallery3/vendor/forge/modified/libraries/Form_Textarea.php
- gallery3/vendor/forge/modified/libraries/Form_Upload.php
Add proper preambles
- 00:31 Changeset [20842] by
-
- gallery3/trunk/modules/forge
- gallery3/trunk/modules/forge/controllers
- gallery3/trunk/modules/forge/models
- gallery3/trunk/modules/forge/views
Remove Forge files that we don't use
- 00:28 Changeset [20841] by
-
- gallery3/trunk/index.php
Define KOHANA as the front controller .php file.
- 00:25 Changeset [20840] by
-
- gallery3/vendor/forge/modified/controllers
- gallery3/vendor/forge/modified/models
- gallery3/vendor/forge/modified/views
Remove stuff we don't want from Forge in Gallery3
- 00:21 Changeset [20839] by
-
- gallery3/trunk/kohana/libraries/ORM_Versioned.php
Add preamble. http://dev.kohanaphp.com/issues/1661
- 00:19 Changeset [20838] by
-
- gallery3/vendor/kohana/README
Take note of upstream ticket #1661
- 00:16 Changeset [20837] by
-
- gallery3/trunk/modules/gallery_unit_test/views/kohana_unit_test_cli.php
There's a new view for CLI unit test output in the Unit_Test library
- 00:14 Changeset [20836] by
-
- gallery3/trunk/kohana
- gallery3/trunk/kohana/config/sql_types.php
- gallery3/trunk/kohana/core/Benchmark.php
- gallery3/trunk/kohana/core/Kohana.php
- gallery3/trunk/kohana/helpers/arr.php
- gallery3/trunk/kohana/helpers/date.php
- gallery3/trunk/kohana/helpers/expires.php
- gallery3/trunk/kohana/helpers/feed.php
- gallery3/trunk/kohana/helpers/form.php
- gallery3/trunk/kohana/helpers/request.php
- gallery3/trunk/kohana/helpers/valid.php
- gallery3/trunk/kohana/libraries/Cache.php
- gallery3/trunk/kohana/libraries/Database.php
- gallery3/trunk/kohana/libraries/ORM.php
- gallery3/trunk/kohana/libraries/Router.php
- gallery3/trunk/kohana/libraries/drivers/Database.php
- gallery3/trunk/kohana/libraries/drivers/Database/Mssql.php
- gallery3/trunk/kohana/libraries/drivers/Database/Mysql.php
- gallery3/trunk/kohana/libraries/drivers/Database/Mysqli.php
- gallery3/trunk/kohana/libraries/drivers/Database/Pdosqlite.php
- gallery3/trunk/kohana/libraries/drivers/Database/Pgsql.php
- gallery3/trunk/kohana/views/kohana_error_disabled.php
- gallery3/trunk/kohana/views/kohana_error_page.php
- gallery3/trunk/modules/unit_test
- gallery3/trunk/modules/unit_test/i18n/en_US/unit_test.php
- gallery3/trunk/modules/unit_test/libraries/Unit_Test.php
- gallery3/trunk/modules/unit_test/views/kohana_unit_test_cli.php
Updated kohana and modules/unit_test to upstream r4356
- 00:10 Changeset [20835] by
-
- gallery3/vendor/kohana/modified/kohana/config/sql_types.php
- gallery3/vendor/kohana/modified/kohana/core/Benchmark.php
- gallery3/vendor/kohana/modified/kohana/core/Kohana.php
- gallery3/vendor/kohana/modified/kohana/helpers/arr.php
- gallery3/vendor/kohana/modified/kohana/helpers/date.php
- gallery3/vendor/kohana/modified/kohana/helpers/expires.php
- gallery3/vendor/kohana/modified/kohana/helpers/feed.php
- gallery3/vendor/kohana/modified/kohana/helpers/form.php
- gallery3/vendor/kohana/modified/kohana/helpers/request.php
- gallery3/vendor/kohana/modified/kohana/helpers/valid.php
- gallery3/vendor/kohana/modified/kohana/libraries/Cache.php
- gallery3/vendor/kohana/modified/kohana/libraries/Database.php
- gallery3/vendor/kohana/modified/kohana/libraries/ORM.php
- gallery3/vendor/kohana/modified/kohana/libraries/Router.php
- gallery3/vendor/kohana/modified/kohana/libraries/drivers/Database.php
- gallery3/vendor/kohana/modified/kohana/libraries/drivers/Database/Mssql.php
- gallery3/vendor/kohana/modified/kohana/libraries/drivers/Database/Mysql.php
- gallery3/vendor/kohana/modified/kohana/libraries/drivers/Database/Mysqli.php
- gallery3/vendor/kohana/modified/kohana/libraries/drivers/Database/Pdosqlite.php
- gallery3/vendor/kohana/modified/kohana/libraries/drivers/Database/Pgsql.php
- gallery3/vendor/kohana/modified/kohana/views/kohana_error_disabled.php
- gallery3/vendor/kohana/modified/kohana/views/kohana_error_page.php
- gallery3/vendor/kohana/modified/modules/unit_test/i18n/en_US/unit_test.php
- gallery3/vendor/kohana/modified/modules/unit_test/libraries/Unit_Test.php
- gallery3/vendor/kohana/modified/modules/unit_test/views/kohana_unit_test_cli.php
- gallery3/vendor/kohana/refresh_modified.sh
modified version of upstream r4356
- 00:08 Changeset [20834] by
-
- gallery3/vendor/kohana/upstream/application/controllers/examples.php
- gallery3/vendor/kohana/upstream/install.php
- gallery3/vendor/kohana/upstream/modules/auth/libraries/drivers/Auth/ORM.php
- gallery3/vendor/kohana/upstream/modules/gmaps/config/gmaps.php
- gallery3/vendor/kohana/upstream/modules/gmaps/libraries/Gmap.php
- gallery3/vendor/kohana/upstream/modules/gmaps/libraries/Gmap_Options.php
- gallery3/vendor/kohana/upstream/modules/payment/libraries/drivers/Payment/Authorize.php
- gallery3/vendor/kohana/upstream/modules/unit_test/i18n/en_US/unit_test.php
- gallery3/vendor/kohana/upstream/modules/unit_test/libraries/Unit_Test.php
- gallery3/vendor/kohana/upstream/modules/unit_test/views/kohana_unit_test_cli.php
- gallery3/vendor/kohana/upstream/system/config/sql_types.php
- gallery3/vendor/kohana/upstream/system/core/Benchmark.php
- gallery3/vendor/kohana/upstream/system/core/Kohana.php
- gallery3/vendor/kohana/upstream/system/helpers/arr.php
- gallery3/vendor/kohana/upstream/system/helpers/date.php
- gallery3/vendor/kohana/upstream/system/helpers/expires.php
- gallery3/vendor/kohana/upstream/system/helpers/feed.php
- gallery3/vendor/kohana/upstream/system/helpers/form.php
- gallery3/vendor/kohana/upstream/system/helpers/request.php
- gallery3/vendor/kohana/upstream/system/helpers/valid.php
- gallery3/vendor/kohana/upstream/system/i18n/de_DE/image.php
- gallery3/vendor/kohana/upstream/system/i18n/es_ES/image.php
- gallery3/vendor/kohana/upstream/system/i18n/es_ES/validation.php
- gallery3/vendor/kohana/upstream/system/i18n/fr_FR/pagination.php
- gallery3/vendor/kohana/upstream/system/i18n/zh_CN/cache.php
- gallery3/vendor/kohana/upstream/system/i18n/zh_CN/calendar.php
- gallery3/vendor/kohana/upstream/system/i18n/zh_CN/captcha.php
- gallery3/vendor/kohana/upstream/system/i18n/zh_CN/core.php
- gallery3/vendor/kohana/upstream/system/i18n/zh_CN/database.php
- gallery3/vendor/kohana/upstream/system/i18n/zh_CN/encrypt.php
- gallery3/vendor/kohana/upstream/system/i18n/zh_CN/errors.php
- gallery3/vendor/kohana/upstream/system/i18n/zh_CN/event.php
- gallery3/vendor/kohana/upstream/system/i18n/zh_CN/image.php
- gallery3/vendor/kohana/upstream/system/i18n/zh_CN/orm.php
- gallery3/vendor/kohana/upstream/system/i18n/zh_CN/pagination.php
- gallery3/vendor/kohana/upstream/system/i18n/zh_CN/profiler.php
- gallery3/vendor/kohana/upstream/system/i18n/zh_CN/session.php
- gallery3/vendor/kohana/upstream/system/i18n/zh_CN/swift.php
- gallery3/vendor/kohana/upstream/system/i18n/zh_CN/upload.php
- gallery3/vendor/kohana/upstream/system/i18n/zh_CN/validation.php
- gallery3/vendor/kohana/upstream/system/libraries/Cache.php
- gallery3/vendor/kohana/upstream/system/libraries/Database.php
- gallery3/vendor/kohana/upstream/system/libraries/ORM.php
- gallery3/vendor/kohana/upstream/system/libraries/Router.php
- gallery3/vendor/kohana/upstream/system/libraries/drivers/Database.php
- gallery3/vendor/kohana/upstream/system/libraries/drivers/Database/Mssql.php
- gallery3/vendor/kohana/upstream/system/libraries/drivers/Database/Mysql.php
- gallery3/vendor/kohana/upstream/system/libraries/drivers/Database/Mysqli.php
- gallery3/vendor/kohana/upstream/system/libraries/drivers/Database/Pdosqlite.php
- gallery3/vendor/kohana/upstream/system/libraries/drivers/Database/Pgsql.php
- gallery3/vendor/kohana/upstream/system/tests
- gallery3/vendor/kohana/upstream/system/views/kohana_error_disabled.php
- gallery3/vendor/kohana/upstream/system/views/kohana_error_page.php
Updated to upstream r4356
- 00:05 Changeset [20833] by
-
- gallery3/trunk/core/views/kohana_profiler.php
Fix preamble
- 00:01 Ticket #286 (ogg HTML5/Video support) created by
-
Support for the new web standard in displaying video should be included by default.
05/17/09:
- 23:04 Changeset [20832] by
-
- gallery3/trunk/core/tests/File_Structure_Test.php
Update preamble test to list all broken files at once
- 22:47 Changeset [20831] by
-
- gallery3/trunk/core/tests/Albums_Controller_Test.php
- gallery3/trunk/core/tests/Photos_Controller_Test.php
Update tests to reflect the new code that allows changing file and directory names
- 21:51 Changeset [20830] by
-
- gallery3/trunk/installer/web.php
Make our dependency on json_encode() an explicit requirement
- 04:55 Changeset [20829] by
-
- gallery3/trunk/index.php
Define TMPPATH
- 04:44 Changeset [20828] by
-
- gallery3/trunk/core/helpers/core_installer.php
- gallery3/trunk/installer/init_var.php
- gallery3/trunk/installer/install.sql
Add var/tmp
- 04:37 Changeset [20827] by
-
- gallery3/trunk/core/helpers/module.php
Rollback some of the changes from r20822. But still pull the
determination of the function name and arguments to outside
the module loop
- 01:53 Ticket #46 (general settings administration view) closed by
- fixed
- 00:48 Ticket #227 (G2 Import hangs) closed by
- fixed
- 00:46 Changeset [20826] by
-
- gallery3/trunk/modules/g2_import/helpers/g2_import_task.php
Skip over empty import modes. Fixes ticket #227
05/16/09:
- 22:31 Changeset [20825] by
-
- gallery3/trunk/core/js/albums_form_add.js
Silently drop trailing periods in the album name so that we don't have
to throw up an error message (since we don't accept them in album
names).
- 22:28 Ticket #248 (Album name may not end in ".") closed by
- fixed
- 22:27 Changeset [20824] by
-
- gallery3/trunk/core/helpers/album.php
- gallery3/trunk/core/helpers/item.php
- gallery3/trunk/core/helpers/photo.php
Don't allow photos, albums or movies to have a trailing period to avoid
security problems. Ref http://dev.kohanaphp.com/issues/684).
- 22:20 Changeset [20823] by
-
- gallery3/trunk/core/helpers/album.php
- gallery3/trunk/core/helpers/movie.php
- gallery3/trunk/core/helpers/photo.php
- gallery3/trunk/core/tests/Album_Helper_Test.php
- gallery3/trunk/core/tests/Movie_Helper_Test.php
- gallery3/trunk/core/tests/Photo_Helper_Test.php
Don't allow albums/photos/movies to end in "." because it risks
securit issues (and so Kohana won't route them, see
http://dev.kohanaphp.com/issues/684).
Partial fix for ticket #248.
- 16:46 Changeset [20822] by
-
- gallery3/trunk/core/helpers/module.php
Modify the module::event method to accept 2 additional parameters
instead of a variable list and then pass both of these parameters by
reference to the event handlers. 2 parameters cover 100% of our
existing event calls.
- 04:32 Ticket #278 (Edit Album Directory Name doesn't work.) closed by
- fixed: Implemented in r20821 for albums, movies and photos.
- 04:32 Changeset [20821] by
-
- gallery3/trunk/core/controllers/albums.php
- gallery3/trunk/core/controllers/movies.php
- gallery3/trunk/core/controllers/photos.php
- gallery3/trunk/core/helpers/album.php
- gallery3/trunk/core/helpers/item.php
- gallery3/trunk/core/helpers/photo.php
Support renaming albums, photos and movies.
Fixes ticket #278.
- 03:48 Changeset [20820] by
-
- gallery3/trunk/core/helpers/album.php
- gallery3/trunk/core/helpers/photo.php
- gallery3/trunk/core/tests/Album_Helper_Test.php
- gallery3/trunk/core/tests/Movie_Helper_Test.php
- gallery3/trunk/core/tests/Photo_Helper_Test.php
Don't allow the various ::create() methods to take "/" in the name.
- 03:37 Changeset [20819] by
-
- gallery3/trunk/core/models/item.php
- gallery3/trunk/core/tests/Item_Model_Test.php
Item_Model::rename() cannot accept new filenames that contain "/"
- 03:29 Changeset [20818] by
-
- gallery3/trunk/core/models/item.php
- gallery3/trunk/core/tests/Item_Model_Test.php
Implement Item_Model::rename(), with unit tests.
- 02:49 Changeset [20817] by
-
- gallery3/trunk/core/helpers/core_menu.php
Rename the theme menu options under the Appearance menu.
- 01:14 Ticket #285 (Database names with period (.) in them get over-escaped.) created by
-
Use a database called "db.site.ru" to see it fail.
http://gallery.menalto.com/gallery_3.0_alpha_4_released?page=1#comment-307955
- 01:07 Ticket #284 (Safari drops session) created by
-
Users of Safari on OS X 10.5.7 and Safari 4 beta report that they are losing their session when performing operations like changing their password.
- 00:48 Ticket #283 (URL generation of non-ascii filenames is mangled) created by
-
If you upload a file called "ładne-zdjęcie.jpg" the resulting url we generate is something along the lines of http://[server name]/[directory name]/index.php/%EF%BF%BD_adne-zdj%EF%BF%BD_cie.jpg which we don't properly parse.
I believe the culprit is down in parse_url() in url::site() which mangles the raw utf8. We may need to urlencode the path before calling parse_url() to make sure that it's in a form that parse_url() can digest.
http://gallery.menalto.com/gallery_3.0_alpha_4_feedback#comment-307958
05/15/09:
- 17:08 Changeset [20816] by
-
- gallery3/trunk/core/libraries/MY_ORM.php
Only cache rows if they are objects, which assumes also that they are instances of ORM.
- 01:25 Changeset [20815] by
-
- gallery3/trunk/core/views/permissions_form.html.php
Make denied links not clickable at the root level when the permission
is already denied. Ie, at the root level you can't click the item to
reset because there's no permission to inherit from, so denied is now
just a non-actionable status.
05/14/09:
- 23:49 Changeset [20814] by
-
- gallery3/trunk/modules/organize/views/organize_album.html.php
Use ternary operators to tighten up some logic
- 23:41 Changeset [20813] by
-
- gallery3/trunk/modules/comment/helpers/comment_menu.php
Get rid of the 'View comments on this item' menu option for photos.
It doesn't fit in with the others and as Jakob points out, the scroll
wheel on the mouse is perfectly sufficient. I'll leave the icon around, though.
- 23:40 Changeset [20812] by
-
- gallery3/trunk/core/libraries/Menu.php
Provide tooltips for Menu_Element_Link
- 22:39 Changeset [20811] by
-
- gallery3/trunk/installer/install.css
- gallery3/trunk/installer/views/get_db_info.html.php
Tell the user the location of VARPATH so that they know where their photos are getting installed.
- 22:39 Changeset [20810] by
-
- gallery3/trunk/core/controllers/admin_advanced_settings.php
Fix save() to stop using ORM objects.
- 22:27 Changeset [20809] by
-
- gallery3/trunk/core/js/albums_form_add.js
Convert spaces into underscores when generating the album name from the title
- 20:20 Ticket #145 (Search should search file name substrings) closed by
- fixed: Fixed.
- 15:15 Ticket #268 (Organize: Move Pictures to different Album produces error!) closed by
- fixed: Fix implemented r20808
- 15:14 Changeset [20808] by
-
- gallery3/trunk/core/helpers/item.php
- gallery3/trunk/core/helpers/model_cache.php
Fix for ticket #268
1) Added a clear method to model_cache
2) Cleared the model_cache, when the make_album_cover or
remove_album_cover is called.
- 04:28 Changeset [20807] by
-
- gallery3/trunk/core/config/config.php
Specify the internal_cache_path (even though we're not using this yet).
- 04:23 Changeset [20806] by
-
- gallery3/trunk/core/js/albums_form_add.js
Bind to the change() event also so that we can pick up autocompletions in the title box.
- 04:05 Changeset [20805] by
-
- gallery3/trunk/core/controllers/albums.php
Change the way we update view_count to use math instead of ORM for better accuracy
- 04:00 Changeset [20804] by
-
- gallery3/trunk/core/helpers/movie.php
- gallery3/trunk/core/helpers/photo.php
Use the active user as the new item's owner, if no owner id is specified
- 03:56 Changeset [20803] by
-
- gallery3/trunk/core/controllers/admin_advanced_settings.php
- gallery3/trunk/core/controllers/scaffold.php
- gallery3/trunk/core/helpers/module.php
- gallery3/trunk/core/views/admin_advanced_settings.html.php
- gallery3/trunk/installer/install.sql
Cache variables in core._cache so that we can retrieve them all in a
single query. In most cases, we were fetching 4-5 variables per page
load, so this is 2-3x faster.
- 02:15 Ticket #40 (cache thumbnail/resize paths) closed by
- fixed
- 02:14 Changeset [20802] by
-
- gallery3/trunk/core/helpers/core_installer.php
- gallery3/trunk/core/models/item.php
- gallery3/trunk/installer/install.sql
Introduce a relative_path_cache column in the items table. This lets
us avoid doing lots of MPTT lookups to find the parent path when we're
trying to generate thumbnails, etc. Invalidate the cache at all the
right times. This greatly reduces our query count on album page views.
This fixes ticket #40.
- 02:00 Changeset [20801] by
-
- gallery3/trunk/core/tests/Photos_Controller_Test.php
Updated to match r20797
- 01:19 Changeset [20800] by
-
- gallery3/trunk/core/helpers/model_cache.php
- gallery3/trunk/core/libraries/MY_ORM.php
Overload ORM_Iterator to cache models as we pull them out of the
result set. This allows us to see the cache and avoid further
lookups.
- 00:59 Changeset [20799] by
-
- gallery3/trunk/core/helpers/MY_url.php
Use model_cache() instead of ORM::factory()
- 00:12 Changeset [20798] by
-
- gallery3/trunk/core/views/permissions_form.html.php
- gallery3/trunk/themes/default/css/screen.css
- gallery3/trunk/themes/default/images/ico-denied-gray.png
- gallery3/trunk/themes/default/images/ico-denied-pale.png
- gallery3/trunk/themes/default/images/ico-lock.png
- gallery3/trunk/themes/default/images/ico-success-gray.png
- gallery3/trunk/themes/default/images/ico-success-pale.png
permissions UI facelift
- 00:06 Changeset [20797] by
-
- gallery3/trunk/core/controllers/simple_uploader.php
Beautify only the title, not the filename
05/13/09:
- 23:52 Changeset [20796] by
-
- gallery3/trunk/core/controllers/l10n_client.php
Fix a bad redirect.
- 23:28 Changeset [20795] by
-
- gallery3/trunk/core/helpers/photo.php
Use the $filename not the $name to find the path extension.
- 23:23 Changeset [20794] by
-
- gallery3/trunk/core/controllers/albums.php
- gallery3/trunk/core/js/albums_form_add.js
Add a little JS sugar to set the album directory name to the same as
the album title.
- 22:57 Ticket #226 (Album cover doesn't propagate all the way up) closed by
- fixed: Closing as it does propagate up. item::make_album_cover is now recursive. r20793 addresses the pt about trying to use C as the album cover for its parents even if it has no cover itself
- 22:56 Changeset [20793] by
-
- gallery3/trunk/core/js/quick.js
- gallery3/trunk/core/views/quick_pane.html.php
Address the final point in #226. Disable the make album cover icon if
the pane has the ui-state-disabled class
- 22:34 Changeset [20792] by
-
- gallery3/trunk/installer/index.php
- gallery3/trunk/installer/installer.php
- gallery3/trunk/installer/web.php
Suppress some warnings
- 21:33 Ticket #232 (Detect / allow configuration of graphics & movie toolkits) closed by
- fixed: r20789 and r20791 together allow us to let admin users modify the ffmpeg path, which is probably good enough here.
- 21:32 Changeset [20791] by
-
- gallery3/trunk/core/controllers/admin_advanced_settings.php
- gallery3/trunk/core/views/admin_advanced_settings.html.php
Allow admins to modify variables. This way when something goes wrong,
we can tell them what to do in the forums and we don't have to build
super smart admin UIs to help users with weird edge cases.
- 20:55 Changeset [20790] by
-
- gallery3/trunk/core/helpers/core_menu.php
I should test this stuff before I submit it, eh.
- 20:46 Changeset [20789] by
-
- gallery3/trunk/core/helpers/movie.php
Store the ffmpeg path in a variable.
- 20:42 Changeset [20788] by
-
- gallery3/trunk/core/helpers/core_menu.php
Fix menu typo.
- 20:04 Changeset [20787] by
-
- gallery3/trunk/core/config/config.php
- gallery3/trunk/core/config/database.php
- gallery3/trunk/core/config/locale.php
- gallery3/trunk/core/config/routes.php
- gallery3/trunk/core/config/sendmail.php
- gallery3/trunk/core/config/session.php
- gallery3/trunk/core/config/upload.php
- gallery3/trunk/core/controllers/admin.php
- gallery3/trunk/core/controllers/admin_advanced_settings.php
- gallery3/trunk/core/controllers/admin_dashboard.php
- gallery3/trunk/core/controllers/admin_graphics.php
- gallery3/trunk/core/controllers/admin_languages.php
- gallery3/trunk/core/controllers/admin_maintenance.php
- gallery3/trunk/core/controllers/admin_modules.php
- gallery3/trunk/core/controllers/admin_theme_details.php
- gallery3/trunk/core/controllers/admin_themes.php
- gallery3/trunk/core/controllers/after_install.php
- gallery3/trunk/core/controllers/albums.php
- gallery3/trunk/core/controllers/file_proxy.php
- gallery3/trunk/core/controllers/items.php
- gallery3/trunk/core/controllers/l10n_client.php
- gallery3/trunk/core/controllers/maintenance.php
- gallery3/trunk/core/controllers/move.php
- gallery3/trunk/core/controllers/movies.php
- gallery3/trunk/core/controllers/permissions.php
- gallery3/trunk/core/controllers/photos.php
- gallery3/trunk/core/controllers/quick.php
- gallery3/trunk/core/controllers/rest.php
- gallery3/trunk/core/controllers/scaffold.php
- gallery3/trunk/core/controllers/simple_uploader.php
- gallery3/trunk/core/helpers/MY_remote.php
- gallery3/trunk/core/helpers/MY_url.php
- gallery3/trunk/core/helpers/access.php
- gallery3/trunk/core/helpers/album.php
- gallery3/trunk/core/helpers/batch.php
- gallery3/trunk/core/helpers/block_manager.php
- gallery3/trunk/core/helpers/core.php
- gallery3/trunk/core/helpers/core_block.php
- gallery3/trunk/core/helpers/core_event.php
- gallery3/trunk/core/helpers/core_installer.php
- gallery3/trunk/core/helpers/core_menu.php
- gallery3/trunk/core/helpers/core_search.php
- gallery3/trunk/core/helpers/core_task.php
- gallery3/trunk/core/helpers/core_theme.php
- gallery3/trunk/core/helpers/dir.php
- gallery3/trunk/core/helpers/graphics.php
- gallery3/trunk/core/helpers/item.php
- gallery3/trunk/core/helpers/l10n_client.php
- gallery3/trunk/core/helpers/l10n_scanner.php
- gallery3/trunk/core/helpers/locale.php
- gallery3/trunk/core/helpers/log.php
- gallery3/trunk/core/helpers/message.php
- gallery3/trunk/core/helpers/model_cache.php
- gallery3/trunk/core/helpers/module.php
- gallery3/trunk/core/helpers/movie.php
- gallery3/trunk/core/helpers/photo.php
- gallery3/trunk/core/helpers/rest.php
- gallery3/trunk/core/helpers/site_status.php
- gallery3/trunk/core/helpers/task.php
- gallery3/trunk/core/helpers/theme.php
- gallery3/trunk/core/helpers/xml.php
- gallery3/trunk/core/hooks/init_gallery.php
- gallery3/trunk/core/libraries/Admin_View.php
- gallery3/trunk/core/libraries/Block.php
- gallery3/trunk/core/libraries/I18n.php
- gallery3/trunk/core/libraries/MY_Database.php
- gallery3/trunk/core/libraries/MY_Forge.php
- gallery3/trunk/core/libraries/MY_ORM.php
- gallery3/trunk/core/libraries/MY_Pagination.php
- gallery3/trunk/core/libraries/MY_View.php
- gallery3/trunk/core/libraries/Menu.php
- gallery3/trunk/core/libraries/ORM_MPTT.php
- gallery3/trunk/core/libraries/Sendmail.php
- gallery3/trunk/core/libraries/Task_Definition.php
- gallery3/trunk/core/libraries/Theme_View.php
- gallery3/trunk/core/models/access_cache.php
- gallery3/trunk/core/models/access_intent.php
- gallery3/trunk/core/models/graphics_rule.php
- gallery3/trunk/core/models/incoming_translation.php
- gallery3/trunk/core/models/item.php
- gallery3/trunk/core/models/log.php
- gallery3/trunk/core/models/message.php
- gallery3/trunk/core/models/module.php
- gallery3/trunk/core/models/outgoing_translation.php
- gallery3/trunk/core/models/permission.php
- gallery3/trunk/core/models/task.php
- gallery3/trunk/core/models/theme.php
- gallery3/trunk/core/models/var.php
- gallery3/trunk/core/tests/Access_Helper_Test.php
- gallery3/trunk/core/tests/Album_Helper_Test.php
- gallery3/trunk/core/tests/Albums_Controller_Test.php
- gallery3/trunk/core/tests/Core_Installer_Test.php
- gallery3/trunk/core/tests/Database_Test.php
- gallery3/trunk/core/tests/Dir_Helper_Test.php
- gallery3/trunk/core/tests/DrawForm_Test.php
- gallery3/trunk/core/tests/File_Structure_Test.php
- gallery3/trunk/core/tests/I18n_Test.php
- gallery3/trunk/core/tests/Item_Model_Test.php
- gallery3/trunk/core/tests/Menu_Test.php
- gallery3/trunk/core/tests/ORM_MPTT_Test.php
- gallery3/trunk/core/tests/Photo_Helper_Test.php
- gallery3/trunk/core/tests/Photos_Controller_Test.php
- gallery3/trunk/core/tests/REST_Controller_Test.php
- gallery3/trunk/core/tests/REST_Helper_Test.php
- gallery3/trunk/core/tests/Sendmail_Test.php
- gallery3/trunk/core/tests/Var_Test.php
- gallery3/trunk/index.php
- gallery3/trunk/installer/cli.php
- gallery3/trunk/installer/index.php
- gallery3/trunk/installer/installer.php
- gallery3/trunk/installer/web.php
- gallery3/trunk/modules/akismet/controllers/admin_akismet.php
- gallery3/trunk/modules/akismet/helpers/akismet.php
- gallery3/trunk/modules/akismet/helpers/akismet_event.php
- gallery3/trunk/modules/akismet/helpers/akismet_installer.php
- gallery3/trunk/modules/akismet/helpers/akismet_menu.php
- gallery3/trunk/modules/akismet/tests/Akismet_Helper_Test.php
- gallery3/trunk/modules/comment/controllers/admin_comments.php
- gallery3/trunk/modules/comment/controllers/comments.php
- gallery3/trunk/modules/comment/helpers/comment.php
- gallery3/trunk/modules/comment/helpers/comment_block.php
- gallery3/trunk/modules/comment/helpers/comment_event.php
- gallery3/trunk/modules/comment/helpers/comment_installer.php
- gallery3/trunk/modules/comment/helpers/comment_menu.php
- gallery3/trunk/modules/comment/helpers/comment_search.php
- gallery3/trunk/modules/comment/helpers/comment_theme.php
- gallery3/trunk/modules/comment/models/comment.php
- gallery3/trunk/modules/comment/tests/Comment_Event_Test.php
- gallery3/trunk/modules/comment/tests/Comment_Helper_Test.php
- gallery3/trunk/modules/exif/controllers/exif.php
- gallery3/trunk/modules/exif/helpers/exif.php
- gallery3/trunk/modules/exif/helpers/exif_event.php
- gallery3/trunk/modules/exif/helpers/exif_installer.php
- gallery3/trunk/modules/exif/helpers/exif_task.php
- gallery3/trunk/modules/exif/helpers/exif_theme.php
- gallery3/trunk/modules/exif/models/exif_key.php
- gallery3/trunk/modules/exif/models/exif_record.php
- gallery3/trunk/modules/exif/tests/Exif_Test.php
- gallery3/trunk/modules/g2_import/controllers/admin_g2_import.php
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
- gallery3/trunk/modules/g2_import/helpers/g2_import_event.php
- gallery3/trunk/modules/g2_import/helpers/g2_import_installer.php
- gallery3/trunk/modules/g2_import/helpers/g2_import_menu.php
- gallery3/trunk/modules/g2_import/helpers/g2_import_task.php
- gallery3/trunk/modules/g2_import/models/g2_map.php
- gallery3/trunk/modules/gallery_unit_test/controllers/gallery_unit_test.php
- gallery3/trunk/modules/image_block/helpers/image_block_installer.php
- gallery3/trunk/modules/image_block/helpers/image_block_theme.php
- gallery3/trunk/modules/info/helpers/info_installer.php
- gallery3/trunk/modules/info/helpers/info_theme.php
- gallery3/trunk/modules/notification/controllers/notification.php
- gallery3/trunk/modules/notification/helpers/notification.php
- gallery3/trunk/modules/notification/helpers/notification_event.php
- gallery3/trunk/modules/notification/helpers/notification_installer.php
- gallery3/trunk/modules/notification/helpers/notification_menu.php
- gallery3/trunk/modules/notification/models/pending_notification.php
- gallery3/trunk/modules/notification/models/subscription.php
- gallery3/trunk/modules/organize/controllers/organize.php
- gallery3/trunk/modules/organize/helpers/organize_installer.php
- gallery3/trunk/modules/organize/helpers/organize_menu.php
- gallery3/trunk/modules/organize/helpers/organize_task.php
- gallery3/trunk/modules/organize/helpers/organize_theme.php
- gallery3/trunk/modules/recaptcha/controllers/admin_recaptcha.php
- gallery3/trunk/modules/recaptcha/helpers/recaptcha.php
- gallery3/trunk/modules/recaptcha/helpers/recaptcha_event.php
- gallery3/trunk/modules/recaptcha/helpers/recaptcha_installer.php
- gallery3/trunk/modules/recaptcha/helpers/recaptcha_menu.php
- gallery3/trunk/modules/recaptcha/libraries/Form_Recaptcha.php
- gallery3/trunk/modules/rss/controllers/rss.php
- gallery3/trunk/modules/rss/helpers/rss.php
- gallery3/trunk/modules/rss/helpers/rss_installer.php
- gallery3/trunk/modules/rss/helpers/rss_theme.php
- gallery3/trunk/modules/search/controllers/search.php
- gallery3/trunk/modules/search/helpers/search.php
- gallery3/trunk/modules/search/helpers/search_event.php
- gallery3/trunk/modules/search/helpers/search_installer.php
- gallery3/trunk/modules/search/helpers/search_task.php
- gallery3/trunk/modules/search/helpers/search_theme.php
- gallery3/trunk/modules/search/models/search_record.php
- gallery3/trunk/modules/server_add/controllers/admin_server_add.php
- gallery3/trunk/modules/server_add/controllers/server_add.php
- gallery3/trunk/modules/server_add/helpers/server_add.php
- gallery3/trunk/modules/server_add/helpers/server_add_installer.php
- gallery3/trunk/modules/server_add/helpers/server_add_menu.php
- gallery3/trunk/modules/server_add/helpers/server_add_task.php
- gallery3/trunk/modules/server_add/helpers/server_add_theme.php
- gallery3/trunk/modules/slideshow/helpers/slideshow_event.php
- gallery3/trunk/modules/slideshow/helpers/slideshow_installer.php
- gallery3/trunk/modules/slideshow/helpers/slideshow_menu.php
- gallery3/trunk/modules/slideshow/helpers/slideshow_theme.php
- gallery3/trunk/modules/tag/controllers/admin_tags.php
- gallery3/trunk/modules/tag/controllers/tags.php
- gallery3/trunk/modules/tag/helpers/tag.php
- gallery3/trunk/modules/tag/helpers/tag_event.php
- gallery3/trunk/modules/tag/helpers/tag_installer.php
- gallery3/trunk/modules/tag/helpers/tag_menu.php
- gallery3/trunk/modules/tag/helpers/tag_theme.php
- gallery3/trunk/modules/tag/models/tag.php
- gallery3/trunk/modules/tag/tests/Tag_Test.php
- gallery3/trunk/modules/user/controllers/admin_users.php
- gallery3/trunk/modules/user/controllers/login.php
- gallery3/trunk/modules/user/controllers/logout.php
- gallery3/trunk/modules/user/controllers/password.php
- gallery3/trunk/modules/user/controllers/users.php
- gallery3/trunk/modules/user/helpers/group.php
- gallery3/trunk/modules/user/helpers/user.php
- gallery3/trunk/modules/user/helpers/user_event.php
- gallery3/trunk/modules/user/helpers/user_installer.php
- gallery3/trunk/modules/user/helpers/user_menu.php
- gallery3/trunk/modules/user/helpers/user_theme.php
- gallery3/trunk/modules/user/models/group.php
- gallery3/trunk/modules/user/models/user.php
- gallery3/trunk/modules/user/tests/User_Groups_Test.php
- gallery3/trunk/modules/user/tests/User_Installer_Test.php
- gallery3/trunk/modules/watermark/controllers/admin_watermarks.php
- gallery3/trunk/modules/watermark/helpers/watermark.php
- gallery3/trunk/modules/watermark/helpers/watermark_installer.php
- gallery3/trunk/modules/watermark/helpers/watermark_menu.php
Gee it's May already. Update copyright to 2009.
- 19:48 Changeset [20786] by
-
- gallery3/trunk/core/controllers/admin_advanced_settings.php
- gallery3/trunk/core/helpers/core_menu.php
- gallery3/trunk/core/views/admin_advanced_settings.html.php
- gallery3/trunk/themes/admin_default/css/screen.css
Add the "advanced settings" controller which lets you see all the
vars. We'll eventually turn this into a registry where you can edit
settings directly (at your own risk).
- 18:03 Changeset [20785] by
-
- gallery3/trunk/core/controllers/albums.php
- gallery3/trunk/core/controllers/simple_uploader.php
- gallery3/trunk/core/helpers/core_installer.php
- gallery3/trunk/installer/install.sql
- gallery3/trunk/modules/server_add/controllers/server_add.php
- gallery3/trunk/modules/server_add/helpers/server_add_task.php
Create a new "add" permission and require it at the controller level
when adding photos/movies/albums
- 18:02 Changeset [20784] by
-
- gallery3/trunk/core/controllers/scaffold.php
Unlink var/modules dir also when packaging
- 05:13 Changeset [20783] by
-
- gallery3/trunk/modules/watermark/helpers/watermark.php
Set the default transparency to 1 (no transparency at all)
- 05:11 Changeset [20782] by
-
- gallery3/trunk/core/helpers/graphics.php
Exclude the root album from the "dirty images" query
Clean some HTML out of a translated string.
- 04:45 Changeset [20781] by
-
- gallery3/trunk/installer/install.sql
updated to reflect tinyint(2) -> smallint(6) change
- 04:36 Changeset [20780] by
-
- gallery3/trunk/core/controllers/scaffold.php
Clean out old dirs before packaging.
- 04:33 Changeset [20779] by
-
- gallery3/trunk/core/helpers/movie.php
Oops, use filename instead of name
- 04:02 Changeset [20778] by
-
- gallery3/trunk/modules/user/js
Empty dir
- 04:02 Ticket #213 (User Module Permits Deletion of Built-In User Accounts) closed by
- fixed: Fixed in r20775 and r20776
- 04:01 Changeset [20777] by
-
- gallery3/trunk/modules/user/controllers/admin_users.php
Don't allow admins to delete the guest user. Fixes ticket #213
- 03:59 Changeset [20776] by
-
- gallery3/trunk/modules/user/views/admin_users.html.php
Make the 'this user cannot be deleted' link actually not clickable.
- 03:56 Changeset [20775] by
-
- gallery3/trunk/modules/user/controllers/admin_users.php
- gallery3/trunk/modules/user/controllers/users.php
- gallery3/trunk/modules/user/helpers/user.php
- gallery3/trunk/modules/user/models/user.php
Variety of changes to the way we do user editing:
1) Allow admins to edit the admin bit of other admins
2) Don't allow admins to delete themselves (partial fix for ticket #213)
3) Inline user::update(). Don't do form processing in helper methods!
4) Inline user::_get_edit_form() so that we can treat edit forms differently.
Trying to hard to make common functions makes for weird edge cases.
- 03:44 Changeset [20774] by
-
- gallery3/trunk/modules/user/views/admin_users.html.php
- gallery3/trunk/themes/admin_default/css/screen.css
Colorize admin user rows to make them stand out
- 03:36 Changeset [20773] by
-
- gallery3/trunk/modules/user/views/login.html.php
Use the name field if the full_name field is empty.
- 02:55 Ticket #251 (include "password reset" events in the log entries) closed by
- fixed
- 02:54 Ticket #175 (Installer won't allow multiple tables in database) closed by
- fixed
- 02:54 Ticket #204 (Watermark transparency field is logically inverted) closed by
- fixed
- 02:54 Ticket #198 (Show the load average in the Gallery Stats block) closed by
- fixed
- 02:54 Ticket #193 (Add multiple tags using space as a separator) closed by
- fixed
- 02:54 Ticket #282 (Deleting an album sometimes deletes everything under var) closed by
- fixed
- 02:53 Ticket #237 (Drop the extension from the automatically generated photo title) closed by
- fixed: Added in r20772
- 02:52 Changeset [20772] by
-
- gallery3/trunk/core/controllers/simple_uploader.php
Beautify the title of uploaded files. Convert underscores to spaces, collapse multiple spaces, drop the extension. Fixes ticket #237
- 01:43 Changeset [20771] by
-
- gallery3/trunk/modules/tag/controllers/tags.php
- gallery3/trunk/modules/tag/helpers/tag.php
- gallery3/trunk/modules/tag/models/tag.php
Allow users to enter multiple tags at once, split by space, semicolon
or comma.
Fixes ticket #193.
- 01:32 Changeset [20770] by
-
- gallery3/trunk/core/helpers/core_block.php
- gallery3/trunk/core/views/admin_block_platform.html.php
Display the server load average in the platform block. Fixes ticket #198.
- 01:21 Changeset [20769] by
-
- gallery3/trunk/core/controllers/admin_maintenance.php
Log the complete exception information for exceptions that happen in tasks so that we have some clue as to what went wrong
- 00:47 Changeset [20768] by
-
- gallery3/trunk/modules/user/controllers/password.php
Log password reset attempts. Fixes ticket #251.
- 00:32 Changeset [20767] by
-
- gallery3/trunk/installer/cli.php
- gallery3/trunk/installer/installer.php
- gallery3/trunk/installer/views/db_not_empty.html.php
Warn the user if they're attemping to reinstall into a database that
already has Gallery 3 tables. Otherwise, permit it to continue.
We key this off of the existence of the g3_items table. Theoretically
it's possible that the g3_items table is gone but other tables are
still there, which could mess things up. I'm not going to worry about
that for now.
Fixes ticket #175
- 00:09 Changeset [20766] by
-
- gallery3/trunk/modules/watermark/controllers/admin_watermarks.php
- gallery3/trunk/modules/watermark/helpers/watermark.php
Fix the logical inversion of the transparency field. Now, 100% is max
transparency and 1% is min transparency (no transparency at all).
Fixes ticket #204.
05/12/09:
- 23:48 Ticket #258 (PicLensLite/JS error in alpha 4) closed by
- fixed: This is because the rss module isn't active. I made this dependency more explicit in r20765
- 23:46 Changeset [20765] by
-
- gallery3/trunk/modules/slideshow/helpers/slideshow_event.php
- gallery3/trunk/modules/slideshow/helpers/slideshow_installer.php
Use the module_change event to figure out if the rss module is
inactive. If it is, we need to alert the admin user.
- 23:43 Changeset [20764] by
-
- gallery3/trunk/core/controllers/admin_modules.php
Fire off the module_change event whenever we install or uninstall a module
- 23:24 Ticket #210 (After deleting all images in an album, the cover picture does not go away) closed by
- fixed: Fixed somewhere around alpha 4
- 23:22 Changeset [20763] by
-
- gallery3/trunk/core/models/item.php
Simplify delete()
- 23:18 Changeset [20762] by
-
- gallery3/trunk/core/libraries/ORM_MPTT.php
Fix a bug where deleting an album sometimes deletes everything in var. Fixes ticket #282
- 23:17 Ticket #282 (Deleting an album sometimes deletes everything under var) created by
-
On a fresh install, create an album and put about 20 photos in it. Then delete the album. It'll delete everything under var. The problem is that when we delete children in a loop in ORM_MPTT::delete() we're using stale children which result in bogus left/right pointers that eventually lead the code to think that there are no parents and it falls back on var as its directory.
- 22:48 Changeset [20761] by
-
- gallery3/trunk/core/libraries/ORM_MPTT.php
parent() should return null if there's no parent id
- 22:39 Changeset [20760] by
-
- gallery3/trunk/core/models/item.php
fix comment typo.
- 22:35 Ticket #280 (G2 --> G3 converter fails with duplicate group name) closed by
- fixed
- 22:34 Changeset [20759] by
-
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
Gracefully handle duplicate groups. Fixes ticket #280
- 22:34 Changeset [20758] by
-
- gallery3/trunk/modules/user/helpers/group.php
- gallery3/trunk/modules/user/helpers/user.php
Add group::lookup_by_name()
- 22:31 Changeset [20757] by
-
- gallery3/trunk/modules/user/helpers/user.php
Fix a comment.
- 22:27 Ticket #270 (graphics::composite() should allow a configurable pad value) closed by
- fixed
- 22:27 Changeset [20756] by
-
- gallery3/trunk/core/helpers/graphics.php
Allow configurable padding options
- 21:48 Changeset [20755] by
-
- gallery3/trunk/modules/g2_import/controllers/admin_g2_import.php
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
Deal with the user-entered g2 embed.php path a little more sanely so that if the user enters the path to G2 itself, we find the embed.php path from there.
- 21:41 Changeset [20754] by
-
- gallery3/trunk/modules/g2_import/helpers/g2_import_task.php
Beautify the status text
- 21:30 Ticket #25 (Trap and log all errors) closed by
- fixed: Closing this for now since lowering the kohana notification level greatly reduces the log spam.
- 21:29 Ticket #140 (Developer Tools) closed by
- fixed
- 21:19 Ticket #218 (SWF Uploader not working with HTTPS) closed by
- fixed: Fixed.
- 21:15 Ticket #191 (Use EXIF data to populate photo caption) closed by
- fixed
- 21:09 Ticket #225 (G2 Import: support more sort orders) closed by
- fixed: keywords are now tags. originationTimestamp is "captured" and that's sortable. I ditched the "sort by random" feature because I deemed it to be lame.
- 05:56 Changeset [20753] by
-
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
Skip the copy if the watermark module is enabled *and* there's a watermark.
- 05:55 Ticket #223 (G2 Import: import G2 keywords and tags module data) closed by
- fixed: Implemented in r20752
- 05:48 Changeset [20752] by
-
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
- gallery3/trunk/modules/g2_import/helpers/g2_import_task.php
Import keywords as tags.
Refactor the general flow of g2_import_task::import() to simplify it
and make it more sensible. It had gotten a little overgrown. It's
still a little overgrown, but I don't see an easy way to simplify it
from here.
- 04:22 Changeset [20751] by
-
- gallery3/trunk/modules/exif/helpers/exif_task.php
Don't divide by zero if there are no photos in the Gallery.
- 04:04 Changeset [20750] by
-
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
- gallery3/trunk/modules/g2_import/helpers/g2_import_task.php
- gallery3/trunk/modules/g2_import/views/admin_g2_import.html.php
Import tags.
- 02:12 Changeset [20749] by
-
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
- gallery3/trunk/modules/g2_import/views/admin_g2_import.html.php
Deal gracefully with the case that the Gallery 2 instance didn't have
any resizes (or thumbnails).
Fix a case where we were over-weighting the max dimension for square
resizes and thumbs.
05/11/09:
- 21:09 Ticket #281 (Rotating Images while in "Browse Album" view doesn't always rotate the ...) created by
-
I noticed a strange behavior while rotating images in "Browse Album" view where I would click to rotate an image (left or right 90degrees) and it would rotate the next image in line (not the currently highlighted image).
See attached Screenshot - Notice I've selected photo "CIMG4035.JPG" yet the next image in line "CIMG4036.JPG" is being rotated.
This only happened some of the time, so I don't have specific instructions on how to recreate, but if you'd like I could do some further testing, just let me know,
-BassKozz?[at]Gmail_dot_com
- 20:45 Ticket #280 (G2 --> G3 converter fails with duplicate group name) created by
-
If you have a group in your G3 install with the same name as a group that is already in the G2 install, the migration utility in Alpha 4 fails with the error below.
2009-05-06 20:44:07 -04:00 --- error: Uncaught Exception: @todo GROUP_ALREADY_EXISTS customers in file modules/user/helpers/group.php on line 36
- 20:35 Ticket #279 (G2 Import: import comments) closed by
- fixed
- 20:35 Ticket #279 (G2 Import: import comments) created by
-
Import comments.
- 20:29 Ticket #125 (Make Gallery3 work with https) closed by
- fixed: I've verified that as of r20748 general G3 operations work fine with SSL. Please file a new more specific bug if you find a place where G3 does not work with SSL.
- 20:21 Ticket #222 (G2 Import: import origination timestamps from g2) closed by
- fixed
- 20:20 Ticket #226 (Album cover doesn't propagate all the way up) reopened by
- r20740 only works for one additional level. We need to propagate this all the way up. Ie, you have albums: A > B > C > D > E > F None of them have album covers. You add a photo to F, it should trigger forcing album covers for the whole hierarchy. This also brings up the other interesting question: what if we have albums A > B > C and we decide to make C the album cover for B when C doesn't have any photos in it? reopening the bug.
- 20:17 Changeset [20748] by
-
- gallery3/trunk/core/models/item.php
Add has_thumb() public API method
- 20:16 Changeset [20747] by
-
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
Import comments. This was a lot easier than I thought it would be
- 20:15 Changeset [20746] by
-
- gallery3/trunk/modules/comment/controllers/admin_comments.php
- gallery3/trunk/modules/comment/views/admin_comments.html.php
Refactor to support pagination and simplify the code.
- Simplify the public controller methods
- Fix a bug where missing thumbnails would cause a divide by zero error
- actually pay attention to the page # for pagination and limit the query accordingly.
- 19:20 Changeset [20745] by
-
- gallery3/vendor/exifer/README
Tickets 1117 and 1118 resolved
- 19:19 Changeset [20744] by
-
- gallery3/trunk/modules/exif/lib
- gallery3/trunk/modules/exif/lib/exif.php
Update exif lib to upstream r3901 which resolves the following tickets:
http://www.zenphoto.org/trac/ticket/1117
http://www.zenphoto.org/trac/ticket/1118
- 19:16 Changeset [20743] by
-
- gallery3/vendor/exifer/modified/exif.php
Update to r3901
- 19:15 Changeset [20742] by
-
- gallery3/vendor/exifer/upstream/exif.php
Update to r3901
- 19:15 Changeset [20741] by
-
- gallery3/vendor/exifer/README
Add upstream ticket 1118
- 18:27 Ticket #278 (Edit Album Directory Name doesn't work.) created by
-
When you go to "Edit Album" and modify the "Directory Name" and then click "Modify" it doesn't do anything, The directory name stays the same.
- 18:14 Ticket #226 (Album cover doesn't propagate all the way up) closed by
- fixed: Fixed r20740
- 18:13 Changeset [20740] by
-
- gallery3/trunk/core/helpers/item.php
Fix for #226
- 17:57 Changeset [20739] by
-
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
- gallery3/trunk/modules/g2_import/helpers/g2_import_task.php
Framework for importing comments -- we don't actually do the import yet
- 17:49 Ticket #277 (mod_security error code 503 when trying to upload from server) created by
-
I got the following error when trying to upload from server on my shared hosting account (Dreamhost) with mod_security enabled:
[Mon May 11 10:26:57 2009] [error] [client 123.45.678.90] mod_security: Access denied with code 503. Pattern match "^$" at HEADER("Content-Length") [severity "EMERGENCY"] [hostname "domain.com"] [uri "/gallery3/index.php/gallery3/index.php/server_add/pause/2/2?csrf=424351809afdfhj45495c16fd15667b"] [unique_id "SQbmJfgQqQUAAG-gLIQBBAAA"]The work around is to turn off mod_security while uploading and then turn it back on afterwards.
- 17:36 Ticket #243 (User should be redirected to the page they were viewing after login, not ...) closed by
- fixed
- 16:38 Changeset [20738] by
-
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
Add some comments
- 16:28 Ticket #276 (G2 Import: comment calls fail if G2 comment module is not enabled) closed by
- fixed: Fixed in r20737
- 16:27 Changeset [20737] by
-
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
- gallery3/trunk/modules/g2_import/views/admin_g2_import.html.php
Don't attempt to interact with comments if the Gallery2 comment module is not installed.
Resolves ticket #276
- 16:14 Ticket #276 (G2 Import: comment calls fail if G2 comment module is not enabled) created by
-
g2_import::stats() calls GalleryCommentHelper::fetchAllComments() which fails if the module is not activated/installed (because the comment view permission does not exist).
- 14:32 Changeset [20736] by
-
- gallery3/trunk/modules/exif/helpers/exif_event.php
Correct the reference to $item->id
- 14:31 Changeset [20735] by
-
- gallery3/trunk/core/tests/Albums_Controller_Test.php
- gallery3/trunk/core/tests/Photos_Controller_Test.php
- gallery3/trunk/core/tests/REST_Controller_Test.php
- gallery3/trunk/core/tests/REST_Helper_Test.php
Save and Restore the $_POST variable in tests that manipulate it so
other tests don't fail unexpectedly
- 07:18 Ticket #275 (Updating translation fail) created by
-
Fail when push new transalation
Exception core/helpers/l10n_client.php [188]: @todo TRANSLATIONS_SUBMISSION_FAILED HTTP/1.0 400 Bad Request Stack Trace * core/controllers/admin_languages.php [51]: l10n_client_Core::submit_translations( ) * Admin_Languages_Controller->share( ) * core/controllers/admin.php [49]: call_user_func_array( Array ( [0] => Admin_Languages_Controller Object ( [theme:private] => [uri] => URI Object ( ) [input] => Input Object ( [use_xss_clean:protected] => 1 [magic_quotes_gpc:protected] => 1 [ip_address] => ) ) [1] => share ) ) * Admin_Controller->__call( languages, Array ( [0] => share ) ) * kohana/core/Kohana.php [277]: ReflectionMethod->invokeArgs( Admin_Controller Object ( [theme:private] => [uri] => URI Object ( ) [input] => Input Object ( [use_xss_clean:protected] => 1 [magic_quotes_gpc:protected] => 1 [ip_address] => ) ) , Array ( [0] => languages [1] => Array ( [0] => share ) ) ) * Kohana::instance( ) * kohana/core/Event.php [209]: call_user_func( Array ( [0] => Kohana [1] => instance ) ) * kohana/core/Bootstrap.php [55]: Event::run( system.execute ) * index.php [61]: require( kohana/core/Bootstrap.php ) Loaded in 1.4703 seconds, using 0.99MB of memory. Generated by Kohana v2.3.3. - 05:18 Changeset [20734] by
-
- gallery3/trunk/modules/search/helpers/search_event.php
Index photos as they're added
- 04:22 Changeset [20733] by
-
- gallery3/trunk/modules/exif/helpers/exif.php
Don't accept negative capture dates from EXIF, they're probably just crap data.
- 03:53 Changeset [20732] by
-
- gallery3/trunk/modules/exif/helpers/exif.php
- gallery3/trunk/modules/exif/helpers/exif_event.php
- gallery3/trunk/modules/exif/helpers/exif_installer.php
- gallery3/trunk/modules/exif/helpers/exif_task.php
- gallery3/trunk/modules/exif/helpers/exif_theme.php
Refactor the exif module to denormalize the stored data. This way we
have a single exif_record for each item instead of 1 per key. It's
about 5x faster to scan photos this way.
- 02:52 Ticket #274 (Database errors cause database url, username, and password to be shown in ...) created by
-
I realize this is probably a Kohana bug, but it seems bad enough to me to call attention to it here.
Warning Message
An error was detected which prevented the loading of this page. If this problem persists, please contact the website administrator.
kohana/libraries/drivers/Database/Mysql.php [69]:
mysql_connect() [function.mysql-connect]: Too many connections
Stack Trace
kohana/libraries/drivers/Database/Mysql.php [69]:
mysql_connect( ***DB LOCATION***, ***DB USER***, ***DB PASSWORD***, 1 )
kohana/libraries/Database.php [221]:
Database_Mysql_Driver->connect( )
kohana/libraries/Database.php [1258]:
Database_Core->connect( )
kohana/libraries/ORM.php [905]:
Database_Core->list_fields( vars, 1 )
kohana/libraries/ORM.php [154]:
ORM_Core->reload_columns( )
kohana/libraries/ORM.php [104]:
ORM_Core->initialize( )
kohana/libraries/ORM.php [82]:
ORM_Core->construct( )
core/helpers/module.php [206]:
ORM_Core::factory( var )
core/libraries/I18n.php [65]:
module_Core::get_var( core, default_locale )
I18n_Core::instance( )
kohana/core/Event.php [209]:
call_user_func( Array
(
[0] => I18n
[1] => instance
)
)
kohana/core/Bootstrap.php [46]:
Event::run( system.ready )
index.php [61]:
require( kohana/core/Bootstrap.php )
Loaded in 0.4234 seconds, using 1.45MB of memory. Generated by Kohana v2.3.3.
- 02:37 Changeset [20731] by
-
- gallery3/trunk/modules/exif/lib/exif.php
Reinstate abortCount code, originally added to exifer in G2:
http://gallery.svn.sourceforge.net/viewvc/gallery?view=rev&revision=13422
it was commented out in the ZenPhoto? version. Filed upstream ticket
about this:
- 02:35 Changeset [20730] by
-
- gallery3/trunk/modules/exif/helpers/exif.php
Don't use ORM to delete old exif_keys.. it's too inefficient
- 02:10 Changeset [20729] by
-
- gallery3/vendor/exifer/README
Add expected difference: http://www.zenphoto.org/trac/ticket/1117
- 01:36 Changeset [20728] by
-
- gallery3/trunk/modules/exif/lib/exif.php
Add a cache in intel2Moto(). Because of the duplicate nature of the
calls to this function, this is a 1-2x order of magnitude performance
improvement.
- 00:19 Changeset [20727] by
-
- gallery3/trunk/core/models/item.php
Avoid using ORM_MPTT::parents() in relative_path() so that we're not
calling ORM just to get paths. This is a 10x performance increase.
05/10/09:
- 21:57 Ticket #269 (graphics::remove_rule() needs to mark target as dirty) closed by
- fixed: Good catch. I've applied it in r20726 Note that you can't use count($status) on ORM calls because that returns an ORM object, not a count of how many items were deleted.
- 21:57 Changeset [20726] by
-
- gallery3/trunk/core/helpers/graphics.php
remove_rule() should mark thumbs/resizes dirty also. Resolves ticket #269, thanks jstricker!
- 21:46 Changeset [20725] by
-
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
Only run copy_matching_thumbnails_and_resizes() when we're doing an import, else it interferes with thumbnail/resize generation during regular imports
- 21:42 Ticket #273 (Apply event listener for #gMessage to apply .fn.showMessage() effect when ...) created by
-
The organize dialog is the best example of where this is needed.
- 21:32 Changeset [20724] by
-
- gallery3/trunk/core/views/simple_uploader.html.php
Beautify the error message.
- 20:54 Changeset [20723] by
-
- gallery3/trunk/core/views/simple_uploader.html.php
Warn users if they have suhosin.session.encrypt enabled that it'll break the uploader
- 20:16 Changeset [20722] by
-
- gallery3/trunk/core/views/permissions_form.html.php
Document why we skip the parent state for the root album.
- 20:02 Changeset [20721] by
-
- gallery3/trunk/themes/default/views/photo.html.php
Don't provide full-size link if the user can't see the full size
image. There's no security hole here, it's just a bad user
experience.
- 19:57 Changeset [20720] by
-
- gallery3/trunk/modules/user/controllers/login.php
After ajax login, just reload the current page.
- 19:00 Changeset [20719] by
-
- gallery3/trunk/core/models/item.php
Disable default sorting for performance. (thanks Romain LE DISEZ)
- 18:56 Changeset [20718] by
-
- gallery3/trunk/core/helpers/access.php
Change TINYINT(2) to SMALLINT for compliance (thanks Romain LE DISEZ)
- 18:52 Changeset [20717] by
-
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
Change wording to avoid breaking File_Structure_Test
- 18:44 Changeset [20716] by
-
- gallery3/trunk/modules/exif/helpers/exif_task.php
- gallery3/trunk/modules/search/helpers/search_task.php
Use a clearer query syntax for deleting extra search and exif records (thanks Romain LE DISEZ)
- 08:31 Ticket #272 (Uncaught GD Exception, corrupt Jpeg) created by
-
I started a gallery2 import yesterday and it stalled after a while when trying to import one specific photo, which seemed to be corrupt. GD seemed to crash, taking gallery3 with it. Here is the logged error entry:
2009-05-09 22:33:52 +02:00 --- error: Uncaught PHP Error: imagecreatefromjpeg() [<a href='function.imagecreatefromjpeg'>function.imagecreatefromjpeg</a>]: gd-jpeg, libjpeg: recoverable error: Corrupt JPEG data: 845 extraneous bytes before marker 0xd9
in file kohana/libraries/drivers/Image/GD.php on line 76
- 04:42 Ticket #271 (Watermark module should support multiple watermarks) created by
-
I've implemented a form of this for thumbnails and resized images; please see the attached files.
If anyone drops these files into an existing Gallery3 Alpha4 installation, it's important to remove your old watermark first. If not, you'll have orphaned entries in your vars table.
Also, please note that the implementation I've provided requires the changes I proposed in ticket 269.
- 04:33 Ticket #270 (graphics::composite() should allow a configurable pad value) created by
-
As it is now, the padding is hard-coded to 10 pixels.
- 04:29 Ticket #269 (graphics::remove_rule() needs to mark target as dirty) created by
-
It seems inconsistent for add_rule and remove_rules to mark items as dirty but remove_rule not to.
I'd propose implementing the method like this:
static function remove_rule($module_name, $target, $operation) { $status = ORM::factory("graphics_rule") ->where("module_name", $module_name) ->where("target", $target) ->where("operation", $operation) ->delete_all(); if (count($status)) { self::mark_dirty($target == "thumb", $target == "resize"); } } - 04:04 Changeset [20715] by
-
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
Make the code that copies g2 derivatives more robust if the g2 data file doesn't exist.
- 03:01 Ticket #268 (Organize: Move Pictures to different Album produces error!) created by
-
I have attached the error received.
- 01:11 Changeset [20714] by
-
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
Fix a bug where when we copied over the g2 thumb or resize, we weren't
saving its dimensions to the item.
Also, import originationTimestamp as captured field.
- 00:13 Changeset [20713] by
-
- gallery3/trunk/modules/tag/helpers/tag_event.php
Fix a copy/paste typo.
05/09/09:
- 22:28 Ticket #267 (Organize: Using the lasso doesn't scroll) created by
- 22:26 Ticket #266 (Organize: Scrolling looses selection) created by
-
If a selection is made, and then the thumbnail panel is scrolled to make additional selections the original selections are lost.
- 22:22 Changeset [20712] by
-
- gallery3/trunk/core/controllers/albums.php
- gallery3/trunk/core/libraries/Theme_View.php
Move the thumb_proportion method into Theme_View and set it by default
if the page type is album.
Leave a todo if we ever set up a theme default API
- 21:59 Changeset [20711] by
-
- gallery3/trunk/modules/server_add/controllers/server_add.php
Remove quotes and correct typo
- 21:13 Changeset [20710] by
-
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
Sigh.. fix it the *right* way.
- 21:11 Changeset [20709] by
-
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
Oops, add in a missing ] (thanks kb7sei!)
- 20:18 Changeset [20708] by
-
- gallery3/trunk/modules/g2_import/controllers/admin_g2_import.php
Don't try to put g2_stats and g2_size into the view if g2 is not initialized.
- 19:13 Ticket #265 (Rotate images based on EXIF rotation information) created by
-
When uploading, if we can figure out the proper orientation, rotate the image accordingly.
- 19:10 Ticket #264 (G2 Import: copy over the thumbnails/resizes where possible) closed by
- fixed: Implemented in r20707
- 19:09 Ticket #264 (G2 Import: copy over the thumbnails/resizes where possible) created by
-
Re-use G2 thumbnail/resize files if they have matching dimensions. This will save us from having to run expensive toolkit operations.
- 19:03 Changeset [20707] by
-
- gallery3/trunk/modules/g2_import/controllers/admin_g2_import.php
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
- gallery3/trunk/modules/g2_import/helpers/g2_import_event.php
- gallery3/trunk/modules/g2_import/helpers/g2_import_task.php
- gallery3/trunk/modules/g2_import/views/admin_g2_import.html.php
Usability and performance improvements
Significantly speed up the process by copying Gallery2 thumbnails and
resizes wherever possible instead of regenerating them. This requires
us to figure out the dimensions of the original G2 derivative and make
sure that it matches in some reasonable way.
To allow users to take advantage of this, calculate the optimal thumb
and resize size to set in G3 to match what was used in G2. While
we're at it, give the user some idea of how much data is available in
G2 to import.
- 17:45 Changeset [20706] by
-
- gallery3/trunk/modules/g2_import/views/admin_g2_import.html.php
Fix indentation.
- 17:17 Changeset [20705] by
-
- gallery3/trunk/themes/admin_default/js/ui.init.js
- gallery3/trunk/themes/default/js/ui.init.js
Apply status message display effect to admin theme. Use double rather than single quotes in JS.
- 16:37 Ticket #263 ("Undefined index: GD Version" in admin/graphics with no GD installed) closed by
- fixed: Fixed in r20704
- 16:37 Changeset [20704] by
-
- gallery3/trunk/core/helpers/graphics.php
Force the 'GD Version' key to exist
- 16:36 Ticket #263 ("Undefined index: GD Version" in admin/graphics with no GD installed) created by
- 16:14 Ticket #262 (Organize: Album tree not synchronized on open) created by
-
If the the album that is opened initially, is more than 2 levels down the corresponding tree branch is not displayed
- 16:11 Ticket #261 (Organize: Enable Drag from album tree) created by
-
Currently images can be dragged from the thumbnail panel to the album tree. We need to implement the reverse, be able to drag a tree branch from the tree onto the thumbnail panel or another location in the tree.
- 15:02 Ticket #260 (gToolbar buttons need title text (or other pop-ups) to explain functions.) created by
-
The buttons in the gToolbar need to be explained.
I suggest use of the title attribute as a simple fix.
- 09:26 Ticket #245 (Add "Activate this graphics toolkit" to Graphics Settings admin) closed by
- worksforme: Appears to be done already.
- 09:22 Ticket #259 (Sub-Albums must be better distinguished from Pictures) created by
-
The dark background isn't enough to obviously distinguish that this item is a album.
I suggest a (fake?) stack of photos from the album be shown, and a count of the number of photos inside.
- 07:34 Ticket #258 (PicLensLite/JS error in alpha 4) created by
-
When attempting to use the slideshow, I get the following error in IE 7 & 8, FF, and Konqueror.
Error: PicLensLite.indexFeeds()[0] is undefined Source File: javascript:PicLensLite.start({maxScale:0,feedUrl:PicLensLite.indexFeeds()[0].url}) Line: 1 - 07:10 Changeset [20703] by
-
- gallery3/trunk/themes/default/css/screen.css
- gallery3/trunk/themes/default/js/ui.init.js
Highlight status messages on load, fade them out after a few seconds. Make success green brighter.
- 06:18 Ticket #257 (Display confirmation message when setting album cover from quick_edit bar) created by
-
Unlike rotate, which provides immediate visual confirmation, and delete, which reloads the album page and displays a status message, users do not see any visual feedback when setting album covers.
- 06:11 Ticket #217 (server_add doesn't understand folder names that are numerical only) closed by
- fixed: Fix implemented r20702
- 06:11 Changeset [20702] by
-
- gallery3/trunk/modules/server_add/controllers/server_add.php
Fix for ticket #217
- 05:42 Changeset [20701] by
-
- gallery3/trunk/core/models/item.php
Fix for ticket #255
2nd iteration
- 05:29 Ticket #255 (Navigation broken by sort orders) closed by
- fixed: Fixed at revision r20700
- 05:28 Changeset [20700] by
-
- gallery3/trunk/core/models/item.php
Fix for ticket #255
05/08/09:
- 19:34 Ticket #256 (Uploading files w/out extensions throws an error) closed by
- fixed: Fixed in r20699
- 19:34 Ticket #256 (Uploading files w/out extensions throws an error) created by
-
http://gallery.menalto.com/node/87507#comment-307311
2009-05-06 22:35:16 -04:00 --- error: Uncaught PHP Error: Undefined index: extension in file core/controllers/simple_uploader.php on line 52
- 19:32 Changeset [20699] by
-
- gallery3/trunk/core/controllers/simple_uploader.php
Don't rely on the file to have an extension (or better: don't throw an
error if we can't find one-- just assume its a photo).
- 19:16 Changeset [20698] by
-
- gallery3/trunk/modules/exif/helpers/exif.php
- gallery3/trunk/modules/tag/helpers/tag_event.php
Don't try to use mb_detect_encoding if the module isn't loaded. Not sure if this is a great solution, but it'll probably cut down on a big class of errors opportunistically
- 19:01 Changeset [20697] by
-
- gallery3/trunk/core/controllers/rest.php
Don't do ORM::factory() lookups on non-ints (thanks Romain LE DISEZ)
- 18:52 Ticket #255 (Navigation broken by sort orders) created by
-
Item_Model::get_position() was broken by sort ordering in r20325. Well, better put -- it has not worked since we implemented sort ordering and change the order from just being based on ids.
In get_position() we're using a select statement that finds all the items up to the one that we care about, then we count what we got back. But this worked because we could just get all the ids that were smaller than the one we're looking at because the where happens before the count. But now what's happening is that the order happens after the where so if the id is some low number, we're already thrown out a bunch of the children before we get to the ordering phase.
We might be able to make this work with a HAVING clause, but I'm not sure. In Gallery2 we fetched all the ids and iterated them until we found the one we cared about which is slow, but reliable. Search for "highlight" in GalleryTheme?.class.
- 17:58 Changeset [20696] by
-
- gallery3/trunk/core/libraries/MY_Database.php
Fix whitespace issues
- 17:48 Changeset [20695] by
-
- gallery3/trunk/core/libraries/ORM_MPTT.php
- gallery3/trunk/core/views/admin_block_platform.html.php
Use lower-case aliases for greater portability (thanks Romain LE DISEZ)
05/07/09:
- 17:39 Changeset [20694] by
-
- gallery3/trunk/modules/organize/css/organize.css
- gallery3/trunk/modules/organize/js/organize.js
- gallery3/trunk/modules/organize/views/organize.html.php
Create a thumbnail stack of selected thumbnails for the organize
drawer
- 05:16 Changeset [20693] by
-
- gallery3/trunk/modules/organize/css/organize.css
- gallery3/trunk/modules/organize/js/organize.js
1) Leave an object selected if its clicked.
2) And a 1em left margin to provide more spacing, so the lasso is less inclusive
- 05:04 Changeset [20692] by
-
- gallery3/trunk/modules/exif/helpers/exif.php
Don't try to use the exif/iptc values if we couldn't extract them cleanly.
- 04:56 Changeset [20691] by
-
- gallery3/trunk/modules/organize/js/organize.js
Improve the selection/drag handling so that drag of a single item
doesn't have to be selected first
- 01:28 Ticket #254 (Double quotes not handled correctly in module.info parsing and l10n server) created by
-
Double quotes of the following message are lost when stored in the outgoing_translations table by the l10n client.
Message from modules/akismet/module.info:
Filter comments through the <a href="http://akismet.com">Akismet web service</a>
andy_st is currently refactoring l10n_client code to pass plural forms around. This refactoring is probably taking care of this issue as well.
- 01:28 Changeset [20690] by
-
- gallery3/trunk/core/helpers/album.php
Allow sorting by Capture Date.
- 01:19 Ticket #238 (Pull the exif caption and use it as the description) closed by
- fixed
- 01:18 Ticket #253 (Import photo capture date from EXIF / IPTC info and display it.) closed by
- fixed: Fixed in r20689
- 01:18 Changeset [20689] by
-
- gallery3/trunk/core/helpers/core_installer.php
- gallery3/trunk/installer/install.sql
- gallery3/trunk/modules/exif/helpers/exif.php
- gallery3/trunk/modules/info/views/info_block.html.php
Grab photo capture date and captions from EXIF/IPTC data.
- Add a "captured" column to the items table.
- Pull the DateTime? EXIF field and put it into the captured column
- Pull the Caption EXIF & IPTC fields and put them into the description
field if there was not already a value there
- 01:16 Ticket #253 (Import photo capture date from EXIF / IPTC info and display it.) created by
-
Subject says it all.
- 01:15 Ticket #252 (include "password reset" events in the log entries) closed by
- duplicate
- 01:14 Ticket #252 (include "password reset" events in the log entries) created by
-
keep track of "password reset" attempts via the log entries portion of the admin Dashboard.
- 01:07 Ticket #251 (include "password reset" events in the log entries) created by
-
keep track of "password reset" attempts viewable within the admin Dashboard.
- 00:46 Changeset [20688] by
-
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
Add debug log strings with the G2 stack trace when there's a failure in a g2 call.
- 00:39 Changeset [20687] by
-
- gallery3/packaging/ReleaseChecklist
Add a note to update g3 version string
- 00:29 Changeset [20686] by
-
- gallery3/trunk/core/config/config.php
Don't throw up a warning if we can't detect whether or not the logs dir is writable.
- 00:28 Ticket #250 (Handle translation submission errors by translation, not for the whole ...) created by
-
Problem:
Translation submissions ("share your translations" feature) are handled as a monolithic request right now.
If there's something wrong with just one of the translations, the whole request results in a HTTP 400 Bad Request error.
That's bad because we lose a lot of valuable translations that way (all but the one with a problem might be OK).
Since error checks also apply to the source message (HTML validation, verifying the hash value), this does actually affect all translators and all submitted translations, in case they contain a message which has issues in the G3 source code to begin with (e.g. a malformed HTML tag).
Proposed fix:
Handle errors on a message by message basis. For each message, send back a status like "ACCEPTED" , "PENDING", "REJECTED", "INVALID".
Code to make this happen is mostly there already. Mostly, the client code needs to be updated. Only very small changes in the server code are necessary.
05/06/09:
- 20:27 Changeset [20685] by
-
- gallery3/trunk/modules/organize/js/organize.js
1) Improved selection processing.
2) Drawer closes if no images or albums are selected
- 14:45 Ticket #72 (Draw Form does not render a <ul> element.) closed by
- fixed: Implemented r20684
- 14:45 Changeset [20684] by
-
- gallery3/trunk/core/libraries/MY_Forge.php
- gallery3/trunk/core/tests/DrawForm_Test.php
- gallery3/trunk/core/views/form.html.php
Fix for ticket #72
- 04:27 Changeset [20683] by
-
- gallery3/trunk/core/views/admin_graphics_gd.html.php
Show the 'activate gd' button even when there's a warning about missing rotation
- 04:08 Ticket #249 (G2 Import fails to import site admin group) closed by
- fixed: Fixed in r20682
- 04:08 Changeset [20682] by
-
- gallery3/trunk/modules/g2_import/helpers/g2_import.php
Don't fail when trying to import site admin group. Resolves ticket #249
- 04:07 Ticket #249 (G2 Import fails to import site admin group) created by
-
Dies with this error:
2009-05-05 20:58:52 -07:00 --- error: Uncaught PHP Error: Undefined variable: group in file modules/g2_import/helpers/g2_import.php on line 124
- 03:47 Changeset [20681] by
-
- gallery3/trunk/core/views/admin_graphics_gd.html.php
- gallery3/trunk/core/views/admin_graphics_graphicsmagick.html.php
- gallery3/trunk/core/views/admin_graphics_imagemagick.html.php
- gallery3/trunk/themes/admin_default/css/screen.css
Usability update: include an "Activate Toolkit Name" button with available toolkits
