Context Navigation

Fixed the sporadic session timeout bug! It was caused by the click counter code stuffing way too much data into the cookie. Cookies have a 1024 byte limit and the new stuff we were putting in would eventually cause the session id to drop out. D'oh!

06:58 Changeset [1188] by bharat

trunk/gallery/view_album.php
trunk/gallery/view_photo.php

Moved the viewedXXX counters out of the cookie and into the session.
By putting them in the cookie we were eventually overflowing the cookie
(which has a limit of 1024 bytes) causing the session to evaporate
(leading to all kinds of nasty bugs)

06:32 Changeset [1187] by bharat

trunk/gallery/save_photos.php

Added the extra argument to fs_import_filename() calls that tells it that
we're going to use the result in an exec call (which causes it to wrap
the text in quotations if it contains a space character).

06:31 Changeset [1186] by bharat

trunk/gallery/util.php

Changed fs_exec() call to exec_internal() where we import the filename
into the platform specific style before passing it off.

06:07 Changeset [1185] by bharat

trunk/gallery/setup/functions.inc
trunk/gallery/setup/index.php
trunk/gallery/util.php

Changed calls to exec() to use fs_exec()

09/09/01:

22:31 Changeset [1184] by bharat

trunk/gallery/ChangeLog
trunk/gallery/version.php

2001-09-09 Bharat Mediratta <bharat@…> (1.2.1-cvs-b1)

Fixed issues with sucking images via the web:
- Fixed timeout bug when parsing large HTML files
- Prepend http: when no scheme is present (both initially and on the results of parsed data)

22:30 Changeset [1183] by bharat

trunk/gallery/save_photos.php

When sucking URLs:

Fixed timeout bug when parsing large HTML files
Prepend http: when no scheme is present (both initially and on the results of parsed data)

21:27 Changeset [1182] by bharat

trunk/gallery/errors/configmode.php
trunk/gallery/errors/needinit.php
trunk/gallery/errors/reconfigure.php
trunk/gallery/errors/unconfigured.php

Forgot to prepend $GALLERY_BASEDIR to the help include.

21:10 Changeset [1181] by bharat

trunk/gallery/ChangeLog

2001-09-09 Bharat Mediratta <bharat@…> (1.2.1-cvs)

It turns out that mod_rewrite requires the FollowSymLinks? option enabled (thanks to Dan Brown for catching this). The setup wizard will now turn it on for you.

21:08 Changeset [1180] by bharat

trunk/gallery/setup/.htaccess
trunk/gallery/setup/mod_rewrite.template

Added "Options FollowSymLinks?". This option is required for mod_rewrite
to work properly.

21:07 Changeset [1179] by bharat

trunk/gallery/view_photo.php

Partial fix for bug #460059 -- we weren't closing the table row
at the end of the caption right before the comments.

09/08/01:

22:36 Changeset [1178] by bharat

trunk/gallery/setup/functions.inc

Check NetPBM files to make sure they're executable in check_graphics()

20:50 Changeset [1177] by bharat

trunk/gallery/errors/configmode.php
trunk/gallery/errors/needinit.php
trunk/gallery/errors/reconfigure.php

Added closing </body> and </html> tags (thanks Jeff Kilbride)

20:38 Changeset [1176] by bharat

trunk/gallery/README

Tweaked the FTP instructions for clarity.

20:11 Changeset [1175] by bharat

trunk/gallery/ChangeLog

Extended the configure instruction pages to have links to the FAQ and the mailing lists

20:05 Changeset [1174] by bharat

trunk/gallery/errors/configmode.php
trunk/gallery/errors/needinit.php
trunk/gallery/errors/reconfigure.php
trunk/gallery/errors/unconfigured.php

Added a link to the configure_help info.

20:04 Changeset [1173] by bharat

trunk/gallery/errors/configure_instructions.php

Added FTP instructions.

20:04 Changeset [1172]

branches/skin-job-branch/gallery/errors/configure_help.php

This commit was manufactured by cvs2svn to create branch
'skin-job-branch'.

20:04 Changeset [1171] by bharat

trunk/gallery/errors/configure_help.php

Brief instructions about what to do when there is a configuration
problem.

08:00 Changeset [1170] by bharat

trunk/gallery/ChangeLog

2001-09-08 Bharat Mediratta <bharat@…> (1.2.1-cvs)

Dial down the error reporting (in case it's turned on for the server) for now. We'll properly address this in v2.0

Fixed a bug in the way that we were detecting HTTPS that was accidentally causing false positives on some systems.

07:57 Changeset [1169] by bharat

trunk/gallery/init.php

* Dial down the error reporting (in case it's turned on for the server)

for now. We'll properly address this in v2.0

* Fixed a bug in the way that we were detecting HTTPS that was

accidentally causing false positives on some systems.

03:18 Changeset [1168] by bharat

trunk/gallery/ChangeLog

2001-09-07 Bharat Mediratta <bharat@…> (1.2.1-cvs)

Fixed bug #459471 where you get "Cannot redeclare fs_copy()" in the config wizard. This only happens on older versions of PHP like 4.0.1pl2

Fixed a bug in the style sheet link function (thanks to Tony Clayton) that caused it to return a link in "/css" when upgrading from older versions of Gallery.

03:13 Changeset [1167] by bharat

trunk/gallery/util.php

Fixed a bug in the style sheet link function (thanks to Tony Clayton)
that caused it to return a link in "/css" when upgrading from older versions
of Gallery.

03:11 Changeset [1166] by bharat

trunk/gallery/version.php

Changed version to v1.2.1-cvs

03:11 Changeset [1165] by bharat

trunk/gallery/setup/init.php

Changed require()'s to include()'s for the platform files since it's
conditional which one we load and older versions of PHP4 (like
PHP4.0.1pl2) complain if you load them both.

09/07/01:

07:01 Changeset [1164]

tags/RELEASE_1_2
tags/RELEASE_1_2/docs
tags/RELEASE_1_2/gallery/images/movie.thumb.jpg
trunk/CVSROOT

This commit was manufactured by cvs2svn to create tag 'RELEASE_1_2'.

07:01 Changeset [1163] by bharat

trunk/gallery/ChangeLog
trunk/gallery/version.php

At long last, v1.2!

06:51 Changeset [1162] by bharat

trunk/gallery/edit_thumb.php

Changed the url code to use $gallery->album->getAlbumDirURL("highlight") (instead
of "thumb") because otherwise it might try to load the thumbnail from your mirror
site which will cause SecurityExceptions? in the JVM.

09/02/01:

06:51 Changeset [1161] by bharat

trunk/gallery/classes/Album.php

The last fix to setNestedProperties would omit the final item in each
album. Fixed by Jeff Kilbride.

08/31/01:

07:30 Changeset [1160] by bharat

trunk/gallery/ChangeLog

Amended:

Set the umask before copying files and making directories (and restore it when we're done) so that we avoid any potential issues if the umask is in some weird state. Thanks to Jeff Kilbride for the patch.

07:19 Changeset [1159] by bharat

trunk/gallery/ChangeLog
trunk/gallery/version.php

Set the umask before copying files and making directories (and restore it when we're done) so that we avoid any potential issues if the umask is in some weird state.

07:18 Changeset [1158] by bharat

trunk/gallery/platform/fs_unix.php
trunk/gallery/platform/fs_win32.php

* Added fs_mkdir(). When making directories, clear the umask and then restore it

when we're done.

* When copying files, set the umask to 0133 then restore it when we're done.

(this should get rid of the executable bit)

07:16 Changeset [1157] by bharat

trunk/gallery/classes/Album.php

When creating albums:
* Changed mkdir($dir, 0777) to fs_mkdir($dir, 0755)

08/30/01:

18:59 Changeset [1156] by bharat

trunk/gallery/classes/Album.php

Fixed off-by-one error in setNestedProperties(). Photos are indexed
from 1..n, not 0..n-1

06:07 Changeset [1155] by bharat

trunk/gallery/ChangeLog
trunk/gallery/version.php

Potentially fixed a bug on PHP 4.0.1 where it complains that the fs_XXX methods are redefined. This is happening because the require() method fires even when the line it's on never gets executed. Replace those with include().

06:05 Changeset [1154] by bharat

trunk/gallery/init.php

Changed all require()'s inside flow constructs to be include()'s.
require() is always replaced with the file, even if the line isn't
executed. Instead, we really want to be using include() which will
only fire if the line is actually used. This potentially fixes problems
with earlier versions of PHP.

06:04 Changeset [1153] by bharat

trunk/gallery/errors/configmode.php
trunk/gallery/errors/configure_instructions.php
trunk/gallery/errors/needinit.php
trunk/gallery/errors/reconfigure.php
trunk/gallery/errors/unconfigured.php

Added instructions for configuring under Windows.

05:55 Changeset [1152] by bharat

trunk/gallery/setup/write.inc

Added Win32 instructions for securing the gallery.

08/24/01:

19:52 Changeset [1151] by bharat

trunk/gallery/ChangeLog

2001-08-24 Bharat Mediratta <bharat@…>

Upped the quality of the ppmtojpeg operation to 95. This is the highest quality setting recommended by the jpeg folks and should minimize image degradation when processing jpeg images.

19:51 Changeset [1150] by bharat

trunk/gallery/util.php

Set the quality of ppmtojpeg to 95.

08:54 Changeset [1149] by bharat

trunk/gallery/classes/Album.php

Minor print statement change.

08:53 Changeset [1148] by bharat

trunk/gallery/README

Updated to reflect the fact that gallery_style.css has been broken
out into standalone_style and embedded_style.

08/21/01:

17:39 Changeset [1147] by jackodog

trunk/gallery/ChangeLog
trunk/gallery/edit_caption.php
trunk/gallery/version.php

fixed IE6 display bug in edit_caption input field

08:14 Changeset [1146]

tags/oh_point_one

This commit was manufactured by cvs2svn to create tag 'oh_point_one'.

08:14 Changeset [1145] by jackodog

Initial import of the new docs module.

08:14 Changeset [1144]

branches/one_point_oh
trunk/CVSROOT
trunk/gallery
trunk/java

This commit was manufactured by cvs2svn to create branch 'one_point_oh'.

08:14 Changeset [1143] by jackodog

trunk/docs
trunk/docs/dev
trunk/docs/dev/g20_edit_dialog_api

Initial revision

08:03 Changeset [1142] by jackodog

branches/skin-job-branch/gallery/classes/Album.php
branches/skin-job-branch/gallery/classes/AlbumDB.php
branches/skin-job-branch/gallery/save_photos.php
branches/skin-job-branch/gallery/setup/config_data.inc
branches/skin-job-branch/gallery/setup/index.php
branches/skin-job-branch/gallery/util.php

merging trunk changes into branch

08:01 Changeset [1141] by bharat

trunk/gallery/setup/config_data.inc

Added extra backslashes to c:\windows\temp so that it displays correctly.

08/20/01:

18:44 Changeset [1140] by bharat

trunk/gallery/setup/index.php

Changed require_once("init.php") to require("init.php") for compatibility
with older versions of PHP4.

07:20 Changeset [1139] by bharat

trunk/gallery/ChangeLog
trunk/gallery/version.php

2001-08-20 Bharat Mediratta <bharat@…> (1.2-cvs-b16)

Fixed a minor bug that would cause index-out-of-bounds errors when trying to move albums. The error is visible in Netscape, but not in IE. The function would still work, but it would look bad.

07:18 Changeset [1138] by bharat

trunk/gallery/util.php

Two changes to printNestedVals():
* replaced a for loop that generates strings with str_repeat()
* Added a bounds-check to the code that checks to see if the child

album is the same as the one we're moving. Without the bounds check
we'll get index-out-of-bounds errors from the Album.

08/16/01:

07:38 Changeset [1137] by bharat

trunk/gallery/save_photos.php

Reworked the HTML parsing code to be more choosy about what it considers
to be an image file name. This takes care of the behaviour where it
sometimes mistakes text with a image tag (eg, any random text that
contains .jpg) as an actual reference to an image.

08/15/01:

22:12 Changeset [1136] by bharat

trunk/gallery/ChangeLog
trunk/gallery/version.php

2001-08-15 Bharat Mediratta <bharat@…> (1.2-cvs-b15)

Fixed a serious bug that could cause album corruption in large albums. The way that we were serializing data files had a race condition; if you have two users who modify an album at the same time (one of them might just be updating a click count) you will wind up with a mangled data file.

22:09 Changeset [1135] by bharat

trunk/gallery/classes/Album.php
trunk/gallery/classes/AlbumDB.php
trunk/gallery/classes/gallery/User.php
trunk/gallery/classes/gallery/UserDB.php

Switch to using safe_serialize() when saving data files.

22:09 Changeset [1134] by bharat

trunk/gallery/util.php

Added safe_serialize() function that creates a randomly named temp
file, writes to that file, moves the original to a backup and then
renames the temp file to be the target file.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed

Gallery 3

Context Navigation

Timeline

09/14/01:

09/13/01:

09/12/01:

09/11/01:

09/10/01: