Timeline
05/19/12:
- 19:29 Ticket #1872 (Don't accept file uploads if the file has multiple extensions) closed by
- fixed
- 19:29 Ticket #1873 (Tags autocomplete returns HTML when it shouldn't) closed by
- fixed: Fixed in a9be0691d9efd84cbf5a9f05236caf4df23bcfdb
- 18:32 Ticket #1874 (Clean HTML in tag autocompletions) closed by
- fixed: Fixed in a9be0691d9efd84cbf5a9f05236caf4df23bcfdb
- 18:32 Ticket #1874 (Clean HTML in tag autocompletions) created by
- 17:54 Ticket #1861 (Add class to thumbnail images) closed by
- fixed: Oh good point - in themes/wind/albums.html.php we have: […] So it's either g-album or g-photo. I'll fix that. Fixed in 68437993b90bb9cc02ca1134e73c754e1f0d8273
05/18/12:
- 22:44 Ticket #1861 (Add class to thumbnail images) reopened by
- g-movie is only available on the movie/photo page. It is not available on the album page.
- 14:13 Ticket #1443 (.album.jpg images missing) reopened by
- 12:14 Ticket #1443 (.album.jpg images missing) closed by
- fixed: Not sure why you think this is a naming convention issue. Closing the ticket. If you think this is not the case then please descripe in more detail why the name is causign the issue. > I will look into this. > > /Heli > > ----------------------------------------------------- > This was brought up mainly because of album highlight problems when using Gallery 3.0 with Drupal 7's .htaccess rules. > SparkyMarky??89 came up with the solution and it's been tested in 3 different Drupal/Gallery installations, it's a simple fix and I can't see there being any issues with it. > Basically, to get highlight thumbs to show in G3 when using Drupal 7: > In Gallery3 .htaccess /events > You HAVE to use <IfModule??> ... </IfModule> > and add: > <FilesMatch?? ".album.jpg"> > Order deny,allow /events københavn > </FilesMatch> > That's it - Album highlights will now show fine in Drupal7/Gallery3 set-ups.
- 03:44 Ticket #1873 (Tags autocomplete returns HTML when it shouldn't) created by
- 03:25 Ticket #1872 (Don't accept file uploads if the file has multiple extensions) created by
-
Because apparently it confuses Apache
05/16/12:
- 19:28 Ticket #1871 (Prevent server_add autocomplete from being interpreted as UTF-7) closed by
- fixed: Fixed in 88c0363344860ff87bb7fa2d084b8ab190b364cb
- 19:25 Ticket #1871 (Prevent server_add autocomplete from being interpreted as UTF-7) created by
- 19:06 Ticket #1869 (Upgrade any UTF-7 to UTF-8 automatically) closed by
- wontfix: I don't think we can realistically do this systemically without breaking a lot of UTF-8. closing as "wontfix"
- 19:05 Ticket #1870 (Gallery should require the mbstring module so that it can do reliable ...) closed by
- wontfix: Changed my mind - this is a bad idea.
- 18:47 Ticket #1870 (Gallery should require the mbstring module so that it can do reliable ...) created by
- 18:33 Ticket #1869 (Upgrade any UTF-7 to UTF-8 automatically) created by
- 18:10 Ticket #1868 (Force admin error page to UTF-8) closed by
- fixed: Fixed in 99af395a01edac438cef4e42af1f4c26a3532acc
- 18:07 Ticket #1868 (Force admin error page to UTF-8) created by
05/15/12:
- 23:11 Ticket #1862 (Notification module does not send text) closed by
- fixed: fixed in ce209b9eaac301b8494d7d6faa72d013ed1c6cb9
- 23:07 Ticket #1861 (Add class to thumbnail images) closed by
- worksforme: You can use "li.g-movie img.thumbnail" as the CSS selector. Reopen this bug if it's not sufficient.
- 23:01 Ticket #1867 (Album creation errors don't render properly) closed by
- fixed: Fixed in 891652b233df120464d8fe7d3ca80c5091681dea
- 23:00 Ticket #1867 (Album creation errors don't render properly) created by
-
Steps to repro:
1) Log in
2) Create an album with slug "invalid/slug"
3) Submit
---> See "%3Cform%20action%3D%22/photos/albums/create/1%22%20method%3D%22post%22%20id%3D%22g-add-album-..."
Should see the form again with an error
- 22:55 Ticket #95 (Routing misinterprets and album named movies as a request to display movie ...) closed by
- fixed: I "fixed" this in aac18ef8339054e134fa3e52788a80e6907dfba5 by disallowing creation of top level albums that have the same name as any controller. This doesn't deal with the case where you create an album with that name lower down and then move it up, but I think it covers the 80% case.
- 17:55 Ticket #1866 (Harden installer against bad characters in the database or prefix) closed by
- fixed
- 17:53 Ticket #1866 (Harden installer against bad characters in the database or prefix) created by
-
Fixed in 3caf3cc323cd25b002aa8e44d871d4677da7a029
- 04:55 Ticket #1865 (Verify that where() clauses are well formed) closed by
- fixed: Fixed in 6a6b3f90f36293a40cba091c3ac387abb64f3c1a
- 04:53 Ticket #1865 (Verify that where() clauses are well formed) created by
-
We accept a singleton value when we should require a triplet.
- 03:52 Ticket #1864 (Simplify dialog title for editing advanced settings) closed by
- fixed: Fixed in e3d50dd8be9cd4bdefb42f41aa6ed96b6fece676
- 03:52 Ticket #1863 (Force uploader statuses to be integers) closed by
- fixed: Fixed in 1531c3898fde620abfa9e306dc6efc73e520bd1c
- 03:51 Ticket #1864 (Simplify dialog title for editing advanced settings) created by
- 03:50 Ticket #1863 (Force uploader statuses to be integers) created by
05/13/12:
- 22:26 Ticket #1862 (Notification module does not send text) created by
-
body is not declared...so
/modules/notification/helpers/notification.php ...line 177
->message($pending->body)
to
->message($pending->text)
- 02:24 Ticket #1861 (Add class to thumbnail images) created by
-
Add a class to thumbnail images to differentiate between movie thumbs and image thumbs.
Currently you have to add a <div> to the thumb_top() and </div> to thumb_bottom() to tell the difference between a movie thumb and a image thumbnail at the theme level.
If the theme author places the thumb_top() and thumb_bottom() calls before or after any other content it is difficult to theme the thumbs differently for different thumb types.
- 02:14 Ticket #1860 (improve preg_match regex for finding imagemagic) created by
-
graphics.php (modules/gallery/helpers/)
if (@is_file($path) &&
preg_match(
$settingsversion_regex?, shell_exec($path . " " . $settingsversion_arg?), $matches)) {
to
if (@is_file($path)/* &&
preg_match(
$settingsversion_regex?, shell_exec($path . " " . $settingsversion_arg?), $matches)*/) {
05/12/12:
- 00:15 Ticket #1859 (Sort the module list by module name, not module id) closed by
- fixed: Fixed in 5d9e71741754809ebe5f543eb874634e6fc8cc9d
- 00:14 Ticket #1859 (Sort the module list by module name, not module id) created by
-
This results in a more natural sort order.
- 00:12 Ticket #1858 (Rename "Gallery2 Import" module to "Gallery 2 Import") closed by
- fixed: Fixed in 6aebc2598e0b76e560a68d6ea78bd59012ae0805
- 00:11 Ticket #1858 (Rename "Gallery2 Import" module to "Gallery 2 Import") created by
-
"Gallery 2" is the canonical name.
05/11/12:
- 22:58 Ticket #1857 (Improve the way server add deals with wacky directory names) closed by
- fixed: Fixed in ca037dc9550590d19a2d25d23391c6ddf48203cd
- 22:58 Ticket #1857 (Improve the way server add deals with wacky directory names) created by
- 22:13 Ticket #1856 (Verify that theme names are well formed) closed by
- fixed: Fixed in 34ac1a466d1ad9e1ba23bf9b7265c6b2b2376ad9
- 22:12 Ticket #1856 (Verify that theme names are well formed) created by
- 21:34 Ticket #1855 (Watermark code accepts redundant extensions) closed by
- fixed: Fixed in fd4296c70ffe9c274a1e4215191955a41c4e98e2
- 21:33 Ticket #1855 (Watermark code accepts redundant extensions) created by
-
Try to inject some sanity into watermark extensions.
05/09/12:
05/08/12:
- 06:22 Ticket #1821 (Cannot display big video because the whole file is loaded in memory before ...) reopened by
- You are correct, if you close the buffers, it doesn't load everything in memory, but you don't. Add this code just before the readfile: […] You'll see it fails loading (sorry, I didn't want to send the time to findout how to do proper logging). If you look at how Kohana::close_buffers works, it closes the buffers only down to a certain level (Kohana::$buffer_level). Which is setup in the Kohana::setup() function to the level set by php (to 1, I guess). So you don't close the main php buffer. I guess, then the fix would be to add ob_end_flush just before calling readfile: […] I tested on my machine and it does indeed work.
- 04:43 Ticket #1790 (Organize is broken in IE9; can't rearrange or select from the tree) closed by
- fixed: Fixed in 67f689646b9e12db300d34017f2dbf97676978f4
- 04:43 Ticket #1776 (Organize Module: Attempt to rearrange items causing error) closed by
- duplicate: dupe of #1790.
- 04:41 Ticket #1828 (missing_movie.png copied as jpg in graphics.php) closed by
- fixed: Fixed in a563dcdfb32d34d4cd22c5c75fa7f02f7b7b08d9
- 04:27 Ticket #1815 (Server add hard codes file extensions) closed by
- fixed: Fixed in 1ea6210303357b6c50379d2b929853a3c6a0566c
- 04:19 Ticket #1780 (Error in gallery_graphics.php:composite function) closed by
- fixed: Fixed in 2a4903c0e724adadf0a7f1cf97c147595914bf51
05/07/12:
- 20:46 Ticket #1854 (Changing comments settings throws an exception) closed by
- fixed: Fixed in 5400c4be26a809be8b0571f1291aa528ef39b743
- 20:31 Ticket #1798 (RSS feed not valiDATEing) closed by
- fixed: Fixed in 6effd5f75ee6a0972b0fbad5a15c6b7e8bf5ce8e
- 20:00 Ticket #1854 (Changing comments settings throws an exception) created by
-
Steps to repro:
1) Log in as admin
2) Add a photo
3) Add a comment
4) Admin > Settings > Comments
5) Hit [save]
2012-05-07 12:59:09 -07:00 --- error: ErrorException? [ 0 ]: Trying to get property of non-object
/home/bharat/public_html/gallery3/modules/comment/controllers/admin_comments.php [ 36 ]
#0 /home/bharat/public_html/gallery3/modules/comment/controllers/admin_comments.php(36): gallery_error_Core::error_handler(8, 'Trying to get p...', '/home/bharat/pu...', 36, Array)
#1 [internal function]: Admin_Comments_Controller->save()
#2 /home/bharat/public_html/gallery3/modules/gallery/controllers/admin.php(62): call_user_func_array(Array, Array)
#3 [internal function]: Admin_Controller->call('comments', Array)
#4 /home/bharat/public_html/gallery3/system/core/Kohana.php(331): ReflectionMethod?->invokeArgs(Object(Admin_Controller), Array)
#5 [internal function]: Kohana_Core::instance(NULL)
#6 /home/bharat/public_html/gallery3/system/core/Event.php(208): call_user_func_array(Array, Array)
#7 /home/bharat/public_html/gallery3/application/Bootstrap.php(67): Event_Core::run('system.execute')
#8 /home/bharat/public_html/gallery3/index.php(108): require('/home/bharat/pu...')
#9 {main}
- 19:34 Ticket #1849 (Improve efficiency of regexes in Kohana Input code) closed by
- fixed: Fixed in 41962c0916edb5a1f18e95e9fd0d836f4cd2e142
- 19:34 Ticket #1834 ([Patch] Fixes for IdentityProvider and LDAP) closed by
- fixed
- 19:31 Ticket #1825 (Error in Gallery 3: Open new album) closed by
- worksforme: I cannot reproduce this.
- 19:30 Ticket #1803 (Permissions htaccess verification fails due to filename mismatch) closed by
- invalid: /verify is separate from /success - this is working as intended. If you change the lats /verify to /success you're actually bypassing the check that verifies that your security is working properly. The duplication here is also acceptable - that code is designed for max readability by me and I want to be able to eyeball everything at once with minimal indirection.
- 19:24 Ticket #1821 (Cannot display big video because the whole file is loaded in memory before ...) closed by
- invalid: Please cite your source - http://php.net/manual/en/function.readfile.php says that this is not the case. We close all buffers before calling readfile - it should be efficient.
- 19:22 Ticket #1804 (access check for hidden item) closed by
- worksforme: IIUC, this is by design of the hide module.
- 19:20 Ticket #1801 (Watermarks also for full size images) closed by
- wontfix: Can't do this. If we watermark the full size then any further image operations (thumbnail, resize) will be on the watermarked original. Only way around that is to have two copies (original, watermarked original) which we deemed as too much complexity.
- 19:19 Ticket #1784 (G3 Performance - concatenate CSS and JS) closed by
- worksforme
- 19:16 Ticket #1795 (Can't escape the display_context code) closed by
- fixed
- 19:16 Ticket #1777 (Error from the log related to latest change) closed by
- fixed
- 18:50 Ticket #1837 (Database error on a page with search results) closed by
- fixed: Awesome - your fix resolves it. Fixed in 11ee6d50acf8849347c2c37dc15697830ff854d0
- 18:39 Ticket #1853 (Improperly configured PHP 5.4 crashes in I18n code because of lack of ...) closed by
- fixed: Fill in missing date.timezone in index.php, then log it 25% of the time. Fixed in e722e5d5d4fbd8a70cc67c4d545390120ed00608
- 18:37 Ticket #1853 (Improperly configured PHP 5.4 crashes in I18n code because of lack of ...) created by
-
PHP 5.4 dropped support for processing the TZ environment variable. As a reslt, if you don't set date.timezone in php.ini, it'll generate a loggable error when processing modules/gallery/config/locale.php and then will subsequently crash when trying to localize the stack trace message.
05/06/12:
- 17:04 Ticket #1852 (installer bundle is out of date) closed by
- fixed: Fixed in 02de0bdc280d8aec841353d87cb6af4bcacea8bd
- 17:03 Ticket #1852 (installer bundle is out of date) created by
-
We shipped 3.0.3 with an out of date install.sql - the comment module didn't get updated.
- 16:45 Ticket #1851 (Use html::anchor consistently) closed by
- fixed: Fixed in 3fe3c09ec31b46b1ed57f4d92074dbf3caa4b294
- 16:44 Ticket #1851 (Use html::anchor consistently) created by
-
We have a few different uses of it - try to be more consistent.
- 04:25 Ticket #1850 (We should add X-Frame-Options) closed by
- fixed: Fixed in b839be36bf2b43643b156cb26aa29d0ade80bdd3
- 04:24 Ticket #1850 (We should add X-Frame-Options) created by
-
Set it to SAMEORIGIN to minimize headaches.
- 03:53 Ticket #1849 (Improve efficiency of regexes in Kohana Input code) created by
- 02:55 Ticket #1848 (Poorly formatted urls break admin error message page) closed by
- fixed: Fixed in 916f5c7d3b6d3b57255e760949c78f0dbc2abf92
- 02:55 Ticket #1848 (Poorly formatted urls break admin error message page) created by
- 02:46 Ticket #1847 (Clean up title handling code in organize module) closed by
- fixed: 2d552787f98c234a63b0e022dcd7b909d7f71966 a16b46545115b1b5fd963282c487e078f7eb5eb0
- 02:38 Ticket #1847 (Clean up title handling code in organize module) created by
-
Make it consistent with the rest of the code.
- 02:35 Ticket #1845 (Thumbnails for files with non 3-letter extensions) closed by
- fixed: Fixed in ef4dbd18af218a3c68a776122108af4b0d0191a4
- 02:19 Ticket #1844 (ffmpeg parsing regular expression yields incorrect movie sizes) closed by
- fixed
- 02:13 Ticket #1846 (Clean up illegal data file extension code) closed by
- fixed: Fixed in 801c9a98e438a9c6a072630c3a051435986f6cf0
- 01:52 Ticket #1846 (Clean up illegal data file extension code) created by
-
The code in Item_Model is a little messy and hard to follow.
05/01/12:
- 21:14 Ticket #1845 (Thumbnails for files with non 3-letter extensions) created by
-
Gallery can configured to allow arbitrary file extension but assumes the standard length of three characters in several occasions.
Specifically, the line
return preg_replace("/...$/", "jpg", $base);in
modules/gallery/helpers/graphics.php line 159,
modules/gallery/models/item.php lines 191 and 216,
modules/videos/models/item.php: lines 191 and 217
just replaces the last three letters when determining the filename of the thumbnail of an item. This doesn't work if the item has a four letter file extension like "mpeg" or "m2ts" and the thumbnail is then not displayed (and cannot be accessed).
A fix would be to replace the above line with:
$replace = '/' . pathinfo($base, PATHINFO_EXTENSION) . "$/"; return preg_replace( $replace, "jpg", $base);
- 02:31 Ticket #1844 (ffmpeg parsing regular expression yields incorrect movie sizes) created by
-
movie.php parses ffmpeg output with this regular expression:
/Stream.*?Video:.*?(\d+)x(\d+)/
Unfortunately, my ffmpeg produces output like this:
Stream #0:1(eng): Video: h264 (High) (avc1 / 0x31637661), yuv420p, 1280x720, 10047 kb/s, 29.90 fps, 30 tbr, 1k tbn, 2k tbc
which causes the the dimensions to be returned as "0" x "31637661". I believe this is the cause of several problem reports on the forums. Changing the regular expression to something like this:
/Stream.*?Video:.*?, (\d+)x(\d+)/
causes the correct parsing on my system at least
04/30/12:
- 22:24 Ticket #1843 (Guard organize against bad id's in reparent/rearrange) closed by
- fixed: Fixed in 608d8f663672f7b273177efb49844df532f43408
- 22:03 Ticket #1843 (Guard organize against bad id's in reparent/rearrange) created by
-
If you stuff the source_ids param with bad ids it'll generate a weird error because we call parent() before we call access::required. It won't cause a security problem, we just don't handle it gracefully.
04/29/12:
- 04:21 Ticket #1842 (open_basedir issues with Graphics toolkit activation) created by
-
I created a topic http://gallery.menalto.com/node/106249 for reference:
platform: FreeBSD 8.2, PHP 5.4.1, Apache 2.2.22
Basically, I'm serving Gallery 2.3.2 and Gallery 3.0.3 (git clone, build 194) over the same public_html, <VirtualHost?> and <Directory> containers. php_admin_value open_basedir /usr/local/bin/ present. Gallery2 is able to detect both ffmpeg and ImageMagick? binaries (output of Test Settings verify that)
Gallery3 installer works fine, no issues there. But it gives me these notices:
--
ImageMagick? is installed, but PHP's open_basedir restriction prevents Gallery from using it.
GraphicsMagick? is installed, but PHP's open_basedir restriction prevents Gallery from using it.
--
why is it complaining that it can't use neither of the toolkits if it can read the "presence" of the binaries (like Gallery2 is able to do and execute them)?
in G3 > Advance Settings only provides an override for the ffmpeg binary, not ImageMagick? or GraphicsMagick??
another issue: Edit Permissions render this notice:
--
Oh no! Your server needs a configuration change in order for you to hide photos! Ask your server administrator to enable mod_rewrite and set AllowOverride? FileInfo? Options to fix this.
--
mod_rewrite is already enabled (rewrite module in G2 works fine) and AllowOverride? FileInfo? Options is already declared within the <Directory /home/steve/public_html/gallery3/> container?
any ideas why G3 doesn't detect those settings?
Please advise, thank you!
04/28/12:
- 01:57 Ticket #1841 (G2 Import wiki page incorrect for rewrite) created by
-
The upgrading/importing summary section (http://codex.gallery2.org/Gallery3:Modules:g2_import#Upgrading.2Fimporting_summary) seems to have incorrect steps. If you rename the g3 directory to the name of your old g2 directory as indicated (gallery3 to gallery), the rewrite rules no longer work.
I ended up leaving g3 in the gallery3 directory, and keeping a gallery directory that only contains the .htaccess file with the rewrite commands defined in g2 import.
04/25/12:
- 16:08 Ticket #1840 (Hidden items management optimization) created by
-
this is visible when hidden items are fetched via DB stats
while normally albums are traversed using just one SQL statement, hidden items do use individual calls to nnn_hidden_items table
[code]
SELECT nnn_hidden_items.* FROM nnn_hidden_items WHERE nnn_hidden_items.item_id = '000' ORDER BY nnn_hidden_items.item_id asc LIMIT 1
/code
Perhaps some optimization could be done there which would improve overall performance
04/24/12:
- 03:36 Ticket #1839 (output buffering incompatibilities with 5.4.x) closed by
- fixed: Fixed in 6b306cddc1f25ecfe054b0a1c9d0dc3536da51f6
- 03:30 Ticket #1839 (output buffering incompatibilities with 5.4.x) created by
-
Turns out that calling ob_end_clean() in Kohana::close_buffers() throws out all the output. Not sure why.
ref: http://www.christopher-kunz.de/archives/276-Upgrade-woes-I-Gallery3-and-PHP-5.4.0.html
