Timeline
02/09/10: Today
- 04:49 Ticket #764 (Malformed cookies or query string triggers security code ("Disallowed key ...) closed by
- fixed: Fixed in 6dfab72922bf20104d6032eb292d59c6bd6578ba. PCRE_UNICODE_PROPERTIES went away in Kohana 2.4 so I left that out of the patch. If you see a better way to do this, please let me know. Thanks a ton for the research and the patch, djnz!
02/08/10: Yesterday
- 15:43 Ticket #1008 (Usability: After reentering admin password, taken to dashboard) closed by
- fixed
- 15:42 Ticket #1008 (Usability: After reentering admin password, taken to dashboard) reopened by
- 08:33 Ticket #1008 (Usability: After reentering admin password, taken to dashboard) closed by
- fixed: Not sure about the task context you mention, but I've added a fix which should take of such cases. Fixed in http://github.com/gallery/gallery3/commit/f9d00aa7429599f46e09b23e8313932ac5e186c3.
- 05:44 Ticket #1008 (Usability: After reentering admin password, taken to dashboard) created by
-
If the administrator clicks on an admin task, and the admin session has timed out, the administrator is taken to a page to reenter the password. Once the password has been confirmed, the admin is taken to the dashboard page. This is really a pain. The administrator should be redirected to the admin page that they were originally targeting
- 04:41 Ticket #1007 (Should not require old password to change password & email right after ...) created by
-
We don't expect users to be able to remember the newly generated password right after the install, so we should let them change the password and set the email address for the admin user *without* knowing the generated password.
02/07/10:
- 23:42 Ticket #585 (Password / email change doesn't require current password) closed by
- fixed: Implemented in http://github.com/gallery/gallery3/commit/0c5402fe0a288335f1662552026da5ffb756b13b. I left C) out of this CL. I think we can do without.
- 23:14 Ticket #939 (RTL issue in ordering when organize contents) closed by
- fixed: http://github.com/gallery/gallery3/commit/2337fa93e6f5da3dd89454235d76a61b9181f0ab
- 04:11 Ticket #930 (Video Thumbnail Generation) closed by
- fixed: Fixed in http://github.com/gallery/gallery3/commit/2c3c126aafaa4d7ed86075927887636042117a1c.
02/06/10:
- 22:22 Ticket #939 (RTL issue in ordering when organize contents) reopened by
- 22:20 Ticket #1006 (Reevaluate the use of module::is_active()) created by
-
The use of module::is_active() implies a tight coupling between the calling module and the module that is being checked. We should re-evaluate the use of this pattern and replace it with a method that insures loose coupling.
- 21:07 Ticket #1004 (Replace split() with explode()) closed by
- fixed: Thanks for the reminder. We should know better (see G2's code base), and Rasmus reminded us recently as well. Fixed in http://github.com/gallery/gallery3/commit/7099fc71f11ef8d3dd613d96a04a4824a827c714.
- 20:41 Ticket #1005 (Can't add or edit user or create new users) closed by
- fixed
- 20:24 Ticket #892 (Translation bar in Hebrew shows gibberish text) closed by
- fixed: Fixed in http://github.com/gallery/gallery3/commit/5c0c33782d7dd3556adecb9593f25f2cff06401a
- 15:07 Ticket #1005 (Can't add or edit user or create new users) created by
-
At least in FF 3.6, under Admin > Users/Groups clicking on the "Add a new user" or "Edit" buttons doesn't do anything.
It appears it's looking for /modules/user/views/user_form.html.php which was removed here:
http://github.com/gallery/gallery3/commit/6e1b761b12e13566875804c33efe2ae130ffa32e
- 12:48 Ticket #1004 (Replace split() with explode()) created by
-
I know this is a minor deal, but split() should (almost?) never be used. split() is slower than explode() because it takes a regex instead of a delimiter. However, if a regex is needed, preg_split should be used instead.
I am attaching a patch that replaces all split()'s in the module dir with explode()'s.
Reference:
http://blog.brianhartsock.com/2007/06/11/php-explode-vs-split/
- 07:40 Ticket #970 (organize module - unable to organize more than 25 albums) closed by
- fixed: Manually added the .selectee class on subsequent downloads. Commit: http://bit.ly/cFqNwL
02/05/10:
- 23:44 Ticket #939 (RTL issue in ordering when organize contents) closed by
- fixed: I've fixed it, now i just have to figure why github doesn't know about it
- 22:25 Ticket #939 (RTL issue in ordering when organize contents) reopened by
- Two issues happened I tried to clarify them in the following attachment.
- 18:30 Ticket #1003 (With the latest changes to organize it breaks when trying to drag in IE) created by
-
Gawd, i hate IE, need i say more.
Seems to get a missing object in the CSS selector code.
- 18:28 Ticket #795 (Organise sort order miss aligned in IE) closed by
- fixed: Correct alignment in IE7. Commit: http://bit.ly/9SUKuL
- 17:03 Ticket #939 (RTL issue in ordering when organize contents) closed by
- fixed: If the locale is rtl then change 'after' to 'before' or vice-versa. Commit: http://bit.ly/bsisf9
- 17:02 Ticket #959 (When organizing, do not jump to target folder after dragging) closed by
- fixed: Don't change the current album when items are dragged to a different album in the album tree. Commit: http://bit.ly/aYgswk
- 17:01 Ticket #848 (Organize Menu g-organize-controls is cut-off due to ...) closed by
- fixed: Use CSS to layout the thmbnail grid to the full dialog size. Commit: http://bit.ly/ckhjxN
- 04:44 Ticket #974 (G3 Protected Videos do not play the first time the page is visited) closed by
- worksforme: I tried a variety of ways, but I've been unable to reproduce this problem. Can you provide a more detailed series of steps? I tried this: 1. Log in as admin 2. Create album "test" 3. Deny "view" permission to "Everybody" group from "test" album 4. Verify that var/albums/test has a .htaccess file 5. Upload a FLV file 6. Create Chrome Incognito window 7. Log in as an existing user ("bob") 8. Go directly to the containing album --> I see the thumbnail 9. Click on the thumbnail --> I see the movie, it starts properly I'm going to close this as "worksforme". Please reopen if you can provide me with a set of steps to reproduce it! Thanks!
02/04/10:
- 05:14 Ticket #902 (Duplicated check marks in 'Maintenance' page) closed by
- fixed: Fixed in 61c3dcacd1fb628bd4c5984a887a2b47f89c2a79
02/03/10:
- 18:02 Ticket #1002 (Comment module) created by
-
Is there any way to the possibility of making comments only to registered users. It also requires that the line of email comments must be required. Now is not only the name. How to control the moderation of comments.
It also requires that the line of email comments must be required.
02/02/10:
- 21:32 Ticket #921 (uploading images hangs) closed by
- worksforme: I've tested this with Linux Firefox, Linux Chrome, Windows Firefox, Windows IE 6, Windows Chrome. Can't get it to fail. I'm going to close this as "worksforme". If you can provide me with info to reproduce this I'll be more than happy to dig, but I can't find a problem.
- 21:24 Ticket #998 ('Unable to process this file' results in file with admin-only permissions) closed by
- worksforme: Depending on where the error happens, it's possible that we're failing before permissions are set up correctly so you'll be in a "default deny" state for security. Do you have a snippet from your var/logs log files relevant to this failure? If we can find the underlying error and fix it, this problem will go away. I'm going to close this as "worksforme" for now .. please reopen it with more info if you can find something in your logs.
- 20:31 Ticket #912 (Translations bar shows all CAPS with Internet Explorer 8 (IE8)) closed by
- fixed: Remove the test-transform:uppercase from the l10n css as it was causing problems with other text fields in IE and it violates our case standards. Commit: http://bit.ly/cP8cW0
- 19:45 Ticket #968 (notification module batch processing) reopened by
- Oops, somehow inadvertantly closed it.
- 19:43 Ticket #968 (notification module batch processing) closed by
- fixed
- 19:43 Ticket #987 (Can't change advanced settings that have no value) closed by
- fixed: Change the view to display 'empty' when the variable value is a null string(""). Commit: http://bit.ly/dea3VX
- 19:10 Ticket #1001 (In place edit causes the layout to shift with errors or long tags) created by
-
If a tag is very long (several words) or an error occurs, the layout changes (i.e. the save/cancel buttons wrap), ruining the slick look.
We should probably look at using a div overlay to display the in place edit form
- 19:01 Ticket #1000 (Error message on tag admin is not showing up.) closed by
- fixed: Display the error message for the in place edit. Also improve the double click guard. Commit: http://bit.ly/9Om43N
- 07:02 Ticket #1000 (Error message on tag admin is not showing up.) created by
-
The edit box gets the error border, but the message is not displayed.
- 07:00 Ticket #949 (Cut-and-paste bug on status bar in g2_import_task.php for highlights) closed by
- fixed: Corrected copy paste errors in g2_import task. Committed: http://bit.ly/9kA5LS
- 06:35 Ticket #999 (Double click inplace edit on Tags page causes issues) closed by
- fixed: Guard the gallery.in_place_edit::_show method so that if an attempt is made to show the inplace edit form multiple times, the form is only shown once. Commit: http://bit.ly/91lV9X
- 06:34 Ticket #990 (Scheduled tasks) reopened by
- 06:33 Ticket #990 (Scheduled tasks) closed by
- fixed: Guard the gallery.in_place_edit::_show method so that if an attempt is made to show the inplace edit form multiple times, the form is only shown once. Commit: http://bit.ly/91lV9X
- 06:06 Ticket #999 (Double click inplace edit on Tags page causes issues) created by
-
Double clicks seem cause the javascript to get lost and displays the results in an unformatted page
01/31/10:
- 14:11 Ticket #998 ('Unable to process this file' results in file with admin-only permissions) created by
-
I cannot give a specific photo that causes the following error:
Unable to process this file
but I can confirm that this error happens sometimes with no clear reasons. The error is not related to the file it-self, since I could re-uploaded the same photos correctly in all my tests. (Note that I tried that with many fresh installations of Gallery.)
The point here is that when this error happens with a photo, that photo is added to the album with admin-only permissions. If you were logging-in by admin user, you will see the photo inside the album as a blank photo, and you will be able to rebuild it from the Maintenance page. Otherwise, with non-admin user, you will not see that photo although it's really there, and what happens is that if you open the photos beside that photo (before/after it) and go to that rebuilt photo by Next/Previous button, a dang page appears.
Steps to (almost) reproduce:
(1) Login by admin user.
(2) (This step is not easily reproducible, but it really happens when the user trying to upload many photos. You need to try to upload more than 10 or 20 photos at once, until that error appears.)
(3) Go to the Maintenance page and rebuild that photo. Go back to the album, and you will see that photo appears correctly in the album now.
(4) Logout and re-login with a non-admin user. You will not see that photo in the album.
(5) Open the photo next to that photo, then click on 'previous' button:
A dang page will be shown.
- 05:18 Ticket #587 (var/uploads open for unauthorized access) closed by
- fixed: Fixed in c2a7a6a4e7b492c649462c1bb4e60c033819803e cb92e58d40bfa866c07b10fe189bd653074a9917
- 04:51 Ticket #586 (Arbitrary URL Redirection / Phishing Vulnerability) closed by
- fixed: Logout controller requires CSRF now, so it's protected from phishing attempts. Closing.
- 04:44 Ticket #995 (Password set to blank if you edit your account settings) closed by
- fixed: Fixed in 79a1365991557d64776110b0a3a99ea42b1a70fe
- 04:02 Ticket #971 (Debug mode does not work) closed by
- fixed: Fixed in 43cb6d9b56f802a5952d16b8412f8407dd8cf3c4
- 03:50 Ticket #589 (Prone to brute force login attacks) closed by
- fixed: Implemented in 2bfcec9620814a6f3d0163a174d7ba90efef369d
- 01:36 Ticket #965 (issue when uploading > 50 images) closed by
- worksforme: I just added 118 and 252 photos to an album in 2 separate attempts and it worked fine. Can't reproduce. Please reopen when you have enough info to help me reproduce.
- 00:21 Ticket #997 (No redirecting after non-admin user login) closed by
- fixed: Fixed in 69897b4c66e22607162ba8a1ae8c95c8f616f03a
- 00:12 Ticket #985 (RSS issue with Safari) closed by
- worksforme: Feed is fine and validates with Safari, Firefox and Chrome on Windows. The feed seems fine to me. Can't reproduce this issue. Please reopen this bug with a link to a feed that's defective in some way. Try running your feed through this validator: http://validator.w3.org/feed/
- 00:10 Ticket #986 (Unable to View Slideshow) closed by
- worksforme: Can't reproduce this. If you can reproduce it and can provide me with enough information to reproduce this, please reopen the bug.
- 00:06 Ticket #992 (Digibug pops up a blank page and doesn't allow printing) closed by
- fixed: Fixed in 10e208ea5c1a98d509a520a5bd2cbd407ae2268a
01/30/10:
- 18:01 Ticket #997 (No redirecting after non-admin user login) created by
-
Gallery doesn't redirect you to the main page after the authentication step of any non-admin Gallery user. The login process stops here with a dang page:
http://YourSite.com/YourGalleryPath/index.php/login/auth_html
So you have to manually back to the main Gallery URL:
http://YourSite.com/YourGalleryPath/index.php
01/29/10:
- 19:40 Ticket #996 (In-place tag edit fails in multiple ways) closed by
- fixed: Added <?= access::csrf_form_field ?> to the form template. Fixed on commit: http://bit.ly/bXIgPK
- 18:17 Ticket #996 (In-place tag edit fails in multiple ways) created by
-
The JSON response is delivered back in a separate page, instead of inlined on the page.
Steps to reproduce:
1) Create a tag
2) Go to Admin > Content > Tags
3) Double click on a tag
4) Change the value
5) Hit save
--> {"result":"success"} on a new page
Also, if you make a mistake (like reuse a tag name) the response is a form with errors, but that is also displayed directly. We need to replace the existing form with the form + error.
- 16:05 Ticket #995 (Password set to blank if you edit your account settings) created by
-
See this thread:
http://gallery.menalto.com/node/94127
If you go into your account settings and make a change, like your email address and don't modify your password, it gets set to blank.
- 04:44 Ticket #994 (Upgrader page pop-up in English) closed by
- worksforme: Works for me. In the translation mode, choose the "show all" option to show translations from all G3 files. You'll need to run a file scan before that. E.g. by clicking "update" on the language settings page.
01/28/10:
- 08:09 Ticket #994 (Upgrader page pop-up in English) created by
-
I wasn't ready to take a screen capture, but when I upgraded to a newer version, a popup saying something like:
Upgrade in progress
Don't refresh or leave this page
I tried to update the languages and find this text, but couldn't. Hard coded?
01/27/10:
- 20:09 Ticket #993 (LDAP Identity Provider should support TLS and non-anonymous search access) created by
-
The LDAP provider doesn't seem to support the use of a STARTTLS command and at this point, appears to need anonymous access to enumerate users and groups.
The LDAP provider should not assume that the LDAP directory is wide open to anonymous requests and needs to have the ability to configure a user/password for general access to the LDAP DIT.
- 15:13 Ticket #944 (Full-sized photo is not rotated until refreshing) reopened by
- Issues: (1) The full sized version is not rotated to scale. (See "original-resized rotated.jpg" and "full-sized rotated.jpg") (2) The full sized version will not be rotated again after one rotate, even if you rotated the resized photo.
- 07:15 Ticket #992 (Digibug pops up a blank page and doesn't allow printing) created by
-
If you try to print a photo with Digibug it just pops up a blank page and nothing appears to load.
Thread here:
http://gallery.menalto.com/node/93848
- 02:56 Ticket #833 (Video not playing with special characters in folder names) closed by
- fixed: Fixed: http://github.com/gallery/gallery3/commit/f5b9742e2bbce7f30519c9e0b5ce196863dc0707
01/26/10:
- 22:03 Ticket #991 (Uploading images fails using the SSO module) created by
-
I am able to successfully use the SSO module to authenticate users over and login via HTTP/HTTPS. However, when using authentication, I am not able to upload photos and I get a 401 error.
As soon as I remove SSO, I am able to upload photos again.
In addition, the sso module is "almost ready" to use Kerberos/mod_auth_kerb" if it gets the following to strip the "@DOMAIN.COM" from the username:
diff --git a/modules/sso/helpers/sso_event.php b/modules/sso/helpers/sso_event.php index 67d81a7..c086f91 100644 --- a/modules/sso/helpers/sso_event.php +++ b/modules/sso/helpers/sso_event.php @@ -19,6 +19,8 @@ class sso_event { static function gallery_ready() { $sso_username = Input::instance()->server("REMOTE_USER"); + $stripped = explode('@', $sso_username, -1); + $sso_username = $stripped[0]; $user = Session::instance()->get("user"); if (empty($user) || $user->name != $sso_username) { try {I did not use the Kerberos version while testing -- just Basic auth.
This is as of:
commit 68b290be514106d1b95e63db72caa14da3e02a67 Author: Tim Almdal <tnalmdal@shaw.ca> Date: Fri Jan 22 12:30:53 2010 -0800
- 15:06 Ticket #982 (Expire old log files from var/logs) closed by
- fixed: Add a maintenance task that will clear the expired files (older than 2 weeks) from var/logs and var/tmp. Commit: http://bit.ly/8IHpXO This patch just creates the maintenance task. Running it on a scheduled basis will be addressed by ticket #990.
01/25/10:
- 20:33 Ticket #990 (Scheduled tasks) created by
-
Provide the functionality to run tasks on a predetermined time interval.
- 06:25 Ticket #106 (Uploader can't deal with photos with multibyte character filenames) closed by
- worksforme: Same for me. It's probably fixed now. I can't reproduce this issue with the current git head version, on (Ubuntu) Linux / Chrome 4. If you can still reproduce this issue, please reopen the ticket and tell us exactly how to reproduce the issue (what operating system / version, browser / version, filename, steps to reproduce).
- 06:09 Ticket #989 (Dragging a user to a newly created group causes an error.) closed by
- fixed: Insure that if original() is called and no original has been created, then create it before returning. Commit: http://bit.ly/5ZUXM9
- 04:46 Ticket #889 (There's no user profile landing page) closed by
- fixed: Fixed as of commit: http://bit.ly/76q7UJ
- 04:28 Ticket #989 (Dragging a user to a newly created group causes an error.) created by
-
"clone method called on non-object"
user/models/group.php[45]
01/24/10:
- 08:01 Ticket #931 (User Edit Information not shown when Authentication is read only.) closed by
- fixed: Create a user profile page that is used as a landing page when referencing a user in messages or pages. If the identity provider is read only, this page an still display information about the user. Commit: http://bit.ly/8DBp9W
- 07:58 Ticket #958 (Popular tags = blank page when logged in as admin) closed by
- worksforme: I can't recreate with the latest version from github. I'm going to close it. If it still is an issue, with the most recent version that has been upgraded, please provide more detail information and reopen. The dump above looks like it has nothing to do with tags, as it trying to create the user_menu component of the page.
01/23/10:
- 02:13 Ticket #980 (Login page not displayed properly when invalid password entered) closed by
- fixed: If the userid/password combination, render the full page instead of just printing the form. Commit: http://bit.ly/7j2xTt
01/22/10:
- 22:39 Ticket #899 (No scrolling in translating interface) closed by
- fixed: Specify the height and overflow-y on l10n-client translation element. Commit: http://bit.ly/7FSuSy
- 22:17 Ticket #911 (Groups block is pushed right on Admin > Users/Groups) closed by
- fixed: Remove the g-right class on groups element on the manage user/groups page. Commit: http://bit.ly/7ripo7
- 21:46 Ticket #946 (Changing identity providers causes problems with similar group ids.) closed by
- fixed: Fixed as of http://bit.ly/5RI6jv The current identity provider is uninstalled entirely before the new provider is installed and enabled.
- 21:45 Ticket #988 (Identity Providers should be enabled via the admin modules) closed by
- fixed: Fixed as of http://bit.ly/5RI6jv Identity providers are enabled from the admin modules screen.
- 21:44 Ticket #937 (Identity Providers should have a chance to check the environment) closed by
- fixed: Fixed as of http://bit.ly/5RI6jv Identity Providers can check their environments and provide an indication that the environment meets their requirements. Makes use of the <module>_installer::can_activate method.
- 21:41 Ticket #988 (Identity Providers should be enabled via the admin modules) created by
- 20:21 Ticket #987 (Can't change advanced settings that have no value) created by
-
If a setting in the Advanced settings page has no value you can't click on anything to change the setting. The link is defined if you view the source, but there is no text, just a bunch of spaces.
In IE 7 and FF 3.6 this makes for nothing to click on. If you add a then in IE 7 you can click on something though you can't see it, in FF 3.6 you still can't click on it.
I don't have FF 3.5 handy to test and nor IE 6 or IE 8 at this moment.
- 06:23 Ticket #986 (Unable to View Slideshow) created by
-
commit 0da5d9e606fba5b6dc6137812df32cd1d0f5750f
tree c3fc6cf2a6d1e96ed385a6261e918a4e690ff0b8
parent ff2d81b7c3b75e548766fb8a0ae370cbb2e39bf5
Have pulled the latest gallery3 from git and notice that the 'View Slideshow' link does not function. It used to work a few updates ago ... have checked with Firefox and Opera.
Confirmed by a forum post at http://gallery.menalto.com/node/93973
01/21/10:
- 22:56 Ticket #869 (Issues in RTL mode) reopened by
- Sorry to reopen this now, but I noticed two more things: (1) 'Add a comment' button is shown on the right, overlapping 'Comments' label. (See "add comments button alignment.png".) (2) The above menus are not being aligned correctly with Opera, under Mac OS X. I don't know if this issue is browser-issue. I hope you can fix it. (See "opera menus alignment.png".) Thanks!
- 16:02 Ticket #945 (LDAP configuration is accessed inconsistently) closed by
- invalid: I'm going to close this as the problem arose, because of the inconsistent way Identity providers. The user had attempted to install an identity provider using the module admin page instead of the identity admin page.
- 07:49 Ticket #985 (RSS issue with Safari) created by
-
Although it works in Firefox and Opera, but it doesn't in Safari (All under Mac OS X.) There is no RSS contents at all, and all RSS feed pages are shown blank.
- 07:34 Ticket #984 (@todo TRANSLATIONS_FETCH_REQUEST_FAILED HTTP/1.0 400 Bad Request) closed by
- worksforme: I can't reproduce this issue in the current git HEAD version (= the latest development version fresh from git). Please download / upgrade to the git HEAD version and check if you can still reproduce the issue. Thanks.
01/20/10:
- 21:32 Ticket #984 (@todo TRANSLATIONS_FETCH_REQUEST_FAILED HTTP/1.0 400 Bad Request) created by
-
Hello! this in the error in Translations box: @todo TRANSLATIONS_FETCH_REQUEST_FAILED HTTP/1.0 400 Bad Request. Any results for fix that. All work ok but this error. I need Translations.
01/18/10:
- 19:13 Ticket #983 (Security: HTML in feed urls is reproduced in the output XML for possible ...) closed by
- fixed: Fixed in 0dc184e99f0ca607774a68257432a9a981f4d5b7
- 18:15 Ticket #983 (Security: HTML in feed urls is reproduced in the output XML for possible ...) created by
-
If you put HTML into the feed urls, like this:
That HTML shows up in the output XML.
Details here:
This is caused by url::merge() not doing any sanitization.
- 17:29 Ticket #982 (Expire old log files from var/logs) created by
-
In a production environment, you can wind up with lots of log files. Perhaps when we go to Admin > Dashboard we should expire any logs that are older than 2 weeks?
01/17/10:
- 20:46 Ticket #981 (Allow non-English characters in Gallery URLs) created by
-
Since Gallery doesn't allow Arabic characters in Internet Address field, the user have to manually write an Internet Address for any uploaded file with Arabic name.
First of all, is there any technical difficulty to work with URLs contain Arabic characters? I know a lot of scripts, such Wordpress, that generate URLs contain Arabic names, and work with no problems in all today's major browsers (Safari, IE, Firefox, Opera and Chrome). However, if you see any issues possibility, then it will be nice to make the uploader automatically generates random addresses if it couldn't use the original filename.
- 18:13 Ticket #980 (Login page not displayed properly when invalid password entered) created by
-
If set permissions such that the main album is not viewable by everybody, you are presented with a login page when you browse to the web site. Attempting to login and with an invalid password does not redisplay the screen properly. What is displayed is an unformatted version.
01/15/10:
- 19:23 Ticket #979 (translation problems) closed by
- fixed: Fix commited @ http://bit.ly/7Omh5r
- 17:00 Ticket #977 ([g3b3.284e14d] module - Register - settings not sticking) closed by
- fixed: In spite of your snippyness, "Your trouble shooting indicates a lack of understanding", I have pushed a fix: A further fix for 977. create the user immediately if the policy is visitor w/o a confirmation email. Commit: http://bit.ly/51Pwb1 Its also worth mentioning, that modules in -contrib are not officially supported by the core team. We try to keep them in sync with changes, but are more focused on the gallery3 functionality.
- 13:16 Ticket #977 ([g3b3.284e14d] module - Register - settings not sticking) reopened by
- Replying to tnalmdal: > I'm going to close this because it works fine for me. I just requested a registration, approved it by the administrator and then logged with the user and had a password generated. I was then given the opportunity to change the password. > > To make this work, you need to have a mail server setup on your server and the administrator needs to have a email address defined. Your trouble shooting indicates a lack of understanding. Please re-read what you did, and what I requested. "from gallery3/index.php/admin/register set options for "Visitors can create accounts and no administrator approval is required." and "Require e-mail verification when a visitor creates an account" "
- 04:25 Ticket #977 ([g3b3.284e14d] module - Register - settings not sticking) closed by
- worksforme: I'm going to close this because it works fine for me. I just requested a registration, approved it by the administrator and then logged with the user and had a password generated. I was then given the opportunity to change the password. To make this work, you need to have a mail server setup on your server and the administrator needs to have a email address defined.
01/13/10:
- 19:28 Ticket #978 (Notification send messages are using the new data not the original data) closed by
- fixed: Don't reset the original property as part of the save processing, because that will overwrite the original values with all the new values. The problem with the original approach is that when changed event handlers used $item->original(), it had already been reset as part of the save processing. Went back and forth on either leaving this alone and forcing callers to save the original prior to calling the save function, but there were a few event handlers that used $item->original(). This seemed the easier change. So to reset the original you need to call reload() or clear(). There is now an optional parameter on the reload to only reload the original. Commit: http://bit.ly/8jEX5L
01/12/10:
- 21:09 Ticket #979 (translation problems) created by
-
When trying to save a translation, I get window:
An HTTP error 500 occured (of empty response).
Quoting var/logs/2010-...php
2010-01-12 22:03:11 +01:00 --- error: Database_Exception [ 44 ]: #1064: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'B 'a' AND `r` O 'o' ORDER BY `g3_incoming_translations`.`id` asc LIMIT 1' at line 3 [ SELECT `g3_incoming_translations`.* FROM `g3_incoming_translations` WHERE 0 B 'a' AND `r` O 'o' ORDER BY `g3_incoming_translations`.`id` asc LIMIT 1 ] /var/www/felsengruppe.de/www/system/libraries/Database_Mysqli_Result.php [ 27 ] #0 /var/www/felsengruppe.de/www/system/libraries/Database_Mysqli.php(79): Database_Mysqli_Result_Core->__construct(false, 'SELECT `g3_inco...', Object(mysqli), true) #1 /var/www/felsengruppe.de/www/system/libraries/Database.php(272): Database_Mysqli_Core->query_execute('SELECT `g3_inco...') #2 /var/www/felsengruppe.de/www/modules/gallery/libraries/MY_Database.php(45): Database_Core->query('SELECT `g3_inco...') #3 /var/www/felsengruppe.de/www/system/libraries/Database_Builder.php(994): Database->query('SELECT `g3_inco...') #4 /var/www/felsengruppe.de/www/system/libraries/ORM.php(1528): Database_Builder_Core->execute(Object(Database_Mysqli)) #5 /var/www/felsengruppe.de/www/system/libraries/ORM.php(665): ORM_Core->load_result(false, false) #6 /var/www/felsengruppe.de/www/modules/gallery/controllers/l10n_client.php(34): ORM_Core->find() #7 [internal function]: L10n_Client_Controller->save() #8 /var/www/felsengruppe.de/www/system/core/Kohana.php(330): ReflectionMethod->invokeArgs(Object(L10n_Client_Controller), Array) #9 [internal function]: Kohana_Core::instance(NULL) #10 /var/www/felsengruppe.de/www/system/core/Event.php(208): call_user_func_array(Array, Array) #11 /var/www/felsengruppe.de/www/application/Bootstrap.php(67): Event_Core::run('system.execute') #12 /var/www/felsengruppe.de/www/index.php(90): require('/var/www/felsen...') #13 {main} - 19:43 Ticket #966 (notification module %title empty when creating album in root album) closed by
- fixed: Put quotes around the item titles in all the messages and more importantly actually display the original's title properly. Not that this is fixed we see the problem described in #978 Commit: http://bit.ly/6Ab5Oz
- 19:31 Ticket #978 (Notification send messages are using the new data not the original data) created by
-
In item::save we have the following code:
parent::save();
if (isset($send_event)) {
module::event("item_updated", $this->original(), $this);
}
At this point, both the model returned by $this->original() and $this are identical as MY_ORM::save() resets the original to clone $this;
- 18:17 Ticket #977 ([g3b3.284e14d] module - Register - settings not sticking) created by
-
Details: Fresh install of G3b3.284e14d, new db, new ./var
register module taken from contrib.60238dd
from gallery3/index.php/admin/register set options for "Visitors can create
accounts and no administrator approval is required." and "Require e-mail
verification when a visitor creates an account"
Tested register link, added username, name, e-mail address. Submitted and
get "Your registration request is awaiting administrator approval" at top
of screen. No e-mail sent.
advanced shows the following:
registration default_group empty
registration email_verification
registration policy empty
System info:
System Linux apache 2.6.16.60-0.21-xenpae #1 SMP Tue May 6 12:41:02 UTC
2008 i686
Apache Version Apache/2.2.3 (Linux/SUSE)
mySQLClient API version 5.0.26
PHP Version 5.2.5
- 17:06 Ticket #967 (notification module error in translation) closed by
- invalid
- 17:05 Ticket #967 (notification module error in translation) reopened by
- 17:05 Ticket #969 (The translation text box is missing when an individual string is selected) closed by
- fixed
- 17:01 Ticket #967 (notification module error in translation) closed by
- wontfix: reiffert: you should be able to correct this yourself. The problem is that someone made a typo, in the translation. Now that the ticket #969 is fixed, you should be able to correct the typo.
01/11/10:
- 22:55 Ticket #976 (controllers/l10n_client/search is not implemented) closed by
- fixed: Remove the translation submit button from translation search form. Commit: http://bit.ly/5CEz9N
- 22:54 Ticket #975 (In translate mode, the search button and submit button are not displayed) closed by
- fixed: Previous comment actually applied to ticket #597. Fixed on commit http://bit.ly/8T0HNl Reformat the string list so that the search box does not get push off the end of the page.
- 22:52 Ticket #975 (In translate mode, the search button and submit button are not displayed) reopened by
- 21:27 Ticket #975 (In translate mode, the search button and submit button are not displayed) closed by
- fixed: Remove the translation submit button from translation search form. Commit: http://bit.ly/5CEz9N
- 20:48 Ticket #976 (controllers/l10n_client/search is not implemented) created by
-
Pressing the submit button attempts to send a request to controllers/l10n_client/save which is not implemented
- 20:39 Ticket #975 (In translate mode, the search button and submit button are not displayed) created by
-
The list of strings is too long and the search button disappears off the bottom of the page and you can't scroll to find it
- 18:46 Ticket #671 (resized images don't fully utilize bounding box specified in config) closed by
- fixed: In the graphics_rules table height and width set the maximum height and width values and should be equal. Initially, the height on the resize target rule was less than the height, which artificially constrained images in portrait mode. **Note"" this fix requires an upgrade to version 22. All the resizes will be flagged 10:45 Commit: http://bit.ly/51jDFf
01/10/10:
- 08:00 Ticket #972 (Missing graphics_rules after changing thumb_size and/or resize_size on ...) closed by
- fixed: In Kohana 2.4, ORM::delete_all ignores any where clauses and deletes all the entries in the table unless an array of id's are passed as the parameter. This fix used the Database_builder to specify any where conditions. Thanks psvo for find the first one. Commit http://bit.ly/6OoGwe
- 00:13 Ticket #974 (G3 Protected Videos do not play the first time the page is visited) created by
-
Using a recent G3 build from github (couple days old), I noticed an odd error in G3 when visiting any videos that were restricted to registered users. The Flowplayer would initialize but the video would never start. If you navigate away from the page and return or simply hit refresh, the video player would load as would the video and everything was fine.
Here are the steps to reproduce:
1. Upload an mp4 file to G3
2. Restrict access to the mp4 file
3. Login and attempt to watch the mp4
After running with firebug and turning debug on in Flowplayer, I noticed some strange error messages that suggested the clip duration was not loading. After a little debuging, I found that adding the Content-length header before sending the file via the proxy appears to fix this issue.
If someone else has this problem. you can add one extra line to modules/gallery/controllers/file_proxy.php:
header("Content-Length: " . filesize($file));
When streaming H264 mp4 video files, it makes sense that Flowplayer would want the Content-Length.
Of course, you do not see this problem if you have a public video because you do not go through the file proxy. In that case, Apache serves up the file to Flowplayer.
