1. Summary
  2. Files
  3. Support
  4. Report Spam
  5. Create account
  6. Log in

Ticket #987 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

Can't change advanced settings that have no value

Reported by: nivekiam Owned by: tnalmdal
Priority: minor Milestone: 3.0 RC 1
Version: GIT HEAD Keywords: ui
Cc:

Description

If a setting in the Advanced settings page has no value you can't click on anything to change the setting. The link is defined if you view the source, but there is no text, just a bunch of spaces.

In IE 7 and FF 3.6 this makes for nothing to click on. If you add a   then in IE 7 you can click on something though you can't see it, in FF 3.6 you still can't click on it.

I don't have FF 3.5 handy to test and nor IE 6 or IE 8 at this moment.

Attachments

g3_advanced_settings.jpg (41.2 KB) - added by nivekiam 2 years ago.

Change History

Changed 2 years ago by nivekiam

Changed 2 years ago by tnalmdal

  • owner set to tnalmdal
  • status changed from new to accepted

Changed 2 years ago by bharat

We have some code to deal with that in admin_advanced_settings.html.php:

    28              <? if (isset($var->value)): ?>
    29              <?= html::clean($var->value) ?>
    30              <? else: ?>
    31              <i> <?= t("empty") ?> </i>
    32              <? endif ?>

I wonder why it isn't working.

Changed 2 years ago by nivekiam

Did some digging into the DB with that info. They are not NULL in the DB, but just empty text strings.

I see a few advanced settings in my screen that are <i>empty</i> and others that are completely blank.

Changed 2 years ago by tnalmdal

  • status changed from accepted to closed
  • resolution set to fixed

Change the view to display 'empty' when the variable value is a null string("").
Commit: http://bit.ly/dea3VX

Note: See TracTickets for help on using tickets.