1. Summary
  2. Files
  3. Support
  4. Report Spam
  5. Create account
  6. Log in

Ticket #254 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

Double quotes not handled correctly in module.info parsing and l10n server

Reported by: andy_st Owned by: andy_st
Priority: major Milestone: 3.0 Beta 1
Version: Keywords: l10n
Cc:

Description

Double quotes of the following message are lost when stored in the outgoing_translations table by the l10n client.

Message from modules/akismet/module.info:
Filter comments through the <a href="http://akismet.com">Akismet web service</a>

andy_st is currently refactoring l10n_client code to pass plural forms around. This refactoring is probably taking care of this issue as well.

Change History

Changed 3 years ago by andy_st

  • keywords l10n added

Changed 3 years ago by andy_st

  • status changed from new to assigned

Changed 3 years ago by bharat

  • milestone changed from 3.0 Beta 1 to 3.0 Beta 2

Changed 3 years ago by andy_st

  • status changed from assigned to closed
  • resolution set to fixed
  • milestone changed from 3.0 Beta 2 to 3.0 Beta 1

That was an issue with module.info files and parse_ini_file().

Fixed with a workaround for now:
http://github.com/gallery/gallery3/commit/d0845aadc629cf10b8eee490a651c039750a1430

Changed 3 years ago by andy_st

  • status changed from closed to reopened
  • resolution fixed deleted

Reopening.

The problem is now on the l10n server side. HTML Purifier changes <a href='foo'> to <a href="foo">, i.e. normalizing all attribute delimiters to double-quotes.

That's a problem because we require an exact match between the HTML purified string and the submitted string. And the submitted string is the source message in this case.

I need to find a way to tell HTML purifier to omit this normalization step.

Changed 3 years ago by andy_st

  • summary changed from Double quotes not handled correctly in l10n client save to Double quotes not handled correctly in module.info parsing and l10n server

Changed 3 years ago by andy_st

  • status changed from reopened to closed
  • resolution set to fixed

Fixed in head.

Removed single-quote html attribute delimiters (akismet and recaptcha module descriptions).

News policy:
Enforce double quotes for all html attribute delimiters in l10n messages.

Note: See TracTickets for help on using tickets.