Can't apply aop to beans created by factory

[d1rtym0nk3y]

Not sure if this is a bug, or a limitation (of my understanding)

Given this config

<!-- transactions via aop -->
<aop:config>

<aop:advisor advice-ref="transactionAdvice" pointcut="@annotation(transaction)" />

</aop:config>
<bean id="transactionAdvice" class="coldspring.transaction.interceptor.TransactionInterceptor?" />

<bean id="EntityServiceFactory?" class="model.entity.service.ServiceFactory?" />
<!-- these beans are both instances of model.entity.service.UserService? -->
<bean id="UserServiceDirect?" class="model.entity.service.UserService?" />
<bean id="UserServiceViaFactory?" factory-bean="EntityServiceFactory?" factory-method="getUserService" />

method calls marked @transaction on UserServiceDirect? work as expected, but are not executed within a transaction in UserServiceViaFactory?.

Inspecting the services after they're injected i can see that UserServiceDirect? has been proxied but that UserServiceViaFactory? is an untouched instance of UserService?.

[markmandel]

This sounds like a valid bug, as the BeanPostProcessor? should pick up the factory created bean, I should have thought. I will look into it.

[markmandel]

So this is both a bug, and an interesting bit of theory as well.

So basically, the bean created from the factory-method doesn't get called, because the auto proxying happens in the postProcessBeforeInstantiation event in the InstantiationAwareBeanPostProcessor.

Since CS doesn't manage the bean getting created, there is no way that event can get fired.

Spring manages this by checking the bean coming through the postProcessAfterInitialization event to see if it was handled previously and also if it wasn't - check to see if it needs to be proxied, and if so, wrap it the bean coming through with a proxy and return that instead.

So let's do that.

[markmandel]

Just for future reference:
https://github.com/SpringSource/spring-framework/blob/master/spring-aop/src/main/java/org/springfraamework/aop/framework/autoproxy/AbstractAutoProxyCreator.java#L318

[markmandel]

Not sure why I didn't mark this as fixed. It was done ages ago.

[markmandel]

Found it - wasn't merged properly in both git repos:
https://github.com/markmandel/coldspring/commit/3a6aee85189ecc70b0c6bf3c30546ee4d96cd56f