1. Summary
  2. Files
  3. Support
  4. Report Spam
  5. Create account
  6. Log in

ASSP 2.2.1 (12265) analyze report quoted printable newlines

Moderators: pdreissen, fribo

ASSP 2.2.1 (12265) analyze report quoted printable newlines

Postby jmat » Thu Oct 25, 2012 7:35 pm

Hey guys;

There's a small problem with 12265 in how it generates Quoted-Printable emails for the analyze report. It is only inserting a single NL (\012) for line breaks, which is incorrect -- it should be inserting \015\012, according to the RFC.

See rule #4: http://www.freesoft.org/CIE/RFC/1521/6.htm

The only reason I noticed this is Outlook 2007 had random "=" signs in the middle of HTML and text in analyze reports. Unfortunately, we're still stuck on Office 2007 at our office, so this was a problem and made analyze reports mostly useless.

Once I patched assp.pl to set newline to \015\012, the reports looked like they should.

Patch follows -- I tried to attach it as a file, but it wouldn't work for some reason...

Code: Select all
--- assp.pl.orig   2012-09-21 14:47:38.000000000 -0400
+++ assp.pl   2012-10-25 15:21:50.000000000 -0400
@@ -27581,7 +27581,10 @@
         $this->{mimehead} = $1;
         $this->{mimehead} =~ s/[\s\r\n]+$//o;
         ($charset) = $this->{mimehead} =~ /charset\s*=\s*["']?([^"'\s\r\n]+)["']?/io;
-        $encoding = 'QuotedPrint' if $this->{mimehead} =~ /quoted-printable/io;
+        if ($this->{mimehead} =~ /quoted-printable/io) {
+            $encoding = 'QuotedPrint';
+            $lineend = "\015\012";
+        }
         if ($this->{mimehead} =~ /base64/io) {
             $encoding = 'Base64';
              $lineend = "\015\012";
jmat
 
Posts: 1
Joined: Thu Oct 25, 2012 7:19 pm

Re: ASSP 2.2.1 (12265) analyze report quoted printable newlines

Postby thockar » Fri Oct 26, 2012 6:03 am

Thank you.

Thomas
thockar
Site Admin
 
Posts: 306
Joined: Mon Mar 09, 2009 7:05 pm


Return to Bug reports

Who is online

Users browsing this forum: No registered users and 1 guest

cron