1. Summary
  2. Files
  3. Support
  4. Report Spam
  5. Create account
  6. Log in

ASSP 2.1.1(11364) - add empty line in header

Moderators: pdreissen, fribo

ASSP 2.1.1(11364) - add empty line in header

Postby pparoulek » Tue Jan 10, 2012 2:55 pm

Hello.
I upgrade assp 1.9 to 2.1 and found problem in forwarded email, that assp adds new empty line at the bottom of header and this also corrupt the mail.
Recipient is unable to read the email message.

There is a header of forwarded and original message (IPs, server's names, addresses are anonymized) picked up from notspam folder.

FORWARDED:
Code: Select all
X-Assp-Version: 2.1.1(11364) on assp.zzzz.zz
X-Assp-ID: assp.zzzz.zz 02464-02434
Received: from smtp.zzzz.zz ([10.xxx.xxx.xxx] helo=smtp.zzzz.zz)
        by assp.zzzz.zz with ESMTP (2.1.1); 10 Jan 2012 14:34:24 +0100
Received: from MTA by smtp.zzzz.zz
        with Novell_GroupWise; Tue, 10 Jan 2012 14:34:23 +0100
Message-Id: <4F0C4C5F02000070000054DE@smtp.zzzz.zz>
X-Mailer: Novell GroupWise Internet Agent 7.0.4
Date: Tue, 10 Jan 2012 14:34:07 +0100
From: sms@zzzz.zz
Sender: Postmaster@zzzz.zz
Reply-To: sms@zzzz.zz
Errors-To: Postmaster@zzzz.zz
To: sms@yyyy.yy
Subject: FW:
Mime-Version: 1.0
Content-Type: message/rfc822

Return-path: <original.sender@xxxx.xx>
Received: from mail.zzzz.zz (obis-bno.zzzz.zz [10.xxx.xxx.xxx])
        by smtp.zzzz.zz with ESMTP; Tue, 10 Jan 2012 14:33:34 +0100
X-Spam-Status: No, hits=0.0 required=7.5
        tests=AWL: -0.898,BAYES_00: -1.665,HTML_MESSAGE: 0.001,
        MISSING_SUBJECT: 2.476,RDNS_NONE: 0,TOTAL_SCORE: -0.086,autolearn=no
X-Spam-Level:
Received: from assp.zzzz.zz ([10.xxx.xxx.xxx])
        by mail.zzzz.zz
        (using TLSv1/SSLv3 with cipher AES256-SHA (256 bits))
        for original.recipient@zzzz.zz;
        Tue, 10 Jan 2012 14:33:28 +0100
Received: from nx0.xxxx.xx ([193.xxx.xxx.xxx] helo=nx0.xxxx.xx) by
        assp.zzzz.zz with ESMTPS(AES256-SHA) (2.1.1); 10 Jan 2012 14:33:05 +0100
From: original.sender@xxxx.xx
Received: from AZLHMS22.ms.xxxx.xx ([169.xxx.xxx.xxx]) by AALHMS14.ms.xxxx.xx
([10.xxx.xxx.xxx]) with mapi id 14.01.0339.001; Tue, 10 Jan 2012 14:33:04 +0100
To: <original.recipient@zzzz.zz>
Subject:
Thread-Index: AczPnGBeuMulVAdORAmppb8Usrs8dg==
Date: Tue, 10 Jan 2012 13:33:03 +0000
Message-ID: <1B7EB6CF76C38348A14B9F2184E93EF19A73@AZLHMS22.ms.xxxx.xx>
Accept-Language: cs-CZ, en-US
Content-Language: cs-CZ
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-originating-ip: [10.xxx.xxx.xxx]
Content-Type: multipart/mixed;
        boundary="_004_1B7EB6CF76C38348A14B9F2184E93EF19A73AZLHMS22ms_"
MIME-Version: 1.0
X-Assp-Version: 2.1.1(11364) on assp.zzzz.zz
X-Assp-Client-TLS: yes
X-Assp-Server-TLS: yes
X-Assp-Message/IP-Score: -10 (SSL/TLS-connection-OK)
X-Assp-Delay: not delayed (whitelisted); 10 Jan 2012 14:33:28 +0100
X-Assp-Whitelisted: Yes
X-Assp-ID: assp.zzzz.zz 02403-03012


--_004_1B7EB6CF76C38348A14B9F2184E93EF19A73AZLHMS22ms_
Content-Type: multipart/alternative;
        boundary="_000_1B7EB6CF76C38348A14B9F2184E93EF19A73AZLHMS22ms_"

--_000_1B7EB6CF76C38348A14B9F2184E93EF19A73AZLHMS22ms_
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable

ORIGINAL:
Code: Select all
X-Assp-Version: 2.1.1(11364) on assp.zzzz.zz
X-Assp-Client-TLS: yes
X-Assp-Server-TLS: yes
X-Assp-Message/IP-Score: -10 (SSL/TLS-connection-OK)
X-Assp-Delay: not delayed (whitelisted); 10 Jan 2012 14:33:28 +0100
X-Assp-ID: assp.zzzz.zz 02403-03012
Received: from nx0.xxxx.xx ([193.xxx.xxx.xxx] helo=nx0.xxxx.xx) by
        assp.zzzz.zz with ESMTPS(AES256-SHA) (2.1.1); 10 Jan 2012 14:33:05 +0100
From: original.sender@xxxx.xx
Received: from AZLHMS22.ms.xxxx.xx ([169.xxx.xxx.xxx]) by AALHMS14.ms.xxxx.xx
([10.xxx.xxx.xxx]) with mapi id 14.01.0339.001; Tue, 10 Jan 2012 14:33:04 +0100
To: <original.recipient@zzzz.zz>
Subject:
Thread-Index: AczPnGBeuMulVAdORAmppb8Usrs8dg==
Date: Tue, 10 Jan 2012 13:33:03 +0000
Message-ID: <1B7EB6CF76C38348A14B9F2184E93EF19A73@AZLHMS22.ms.xxxx.xx>
Accept-Language: cs-CZ, en-US
Content-Language: cs-CZ
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-originating-ip: [10.xxx.xxx.xxx]
Content-Type: multipart/mixed;
        boundary="_004_1B7EB6CF76C38348A14B9F2184E93EF19A73AZLHMS22ms_"
MIME-Version: 1.0

--_004_1B7EB6CF76C38348A14B9F2184E93EF19A73AZLHMS22ms_
Content-Type: multipart/alternative;
        boundary="_000_1B7EB6CF76C38348A14B9F2184E93EF19A73AZLHMS22ms_"

--_000_1B7EB6CF76C38348A14B9F2184E93EF19A73AZLHMS22ms_
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable


There is the same message from final recipient's mail server (also with ASSP, but with old working version 1.9).
Code: Select all
X-Assp-Delay: not delayed (Whitelisted Domain: zzzz.zz); 10 Jan 2012
        14:37:11 +0100
X-Assp-Whitelisted: Yes (Whitelisted Domain: zzzz.zz)
X-Assp-Envelope-From: sms@zzzz.zz
X-Assp-Intended-For: sms@yyyy.yy
X-Assp-Passing: Whitelisted Domain: zzzz.zz
X-Assp-Version: 1.9.1.1(0.1.02) on assp.yyyy.yy
X-Assp-ID: assp.yyyy.yy 32620-01640
Received: from mailv6.zzzz.zz ([2a02:xxxx:xxxx:xxxx::xxxx] helo=mail.zzzz.zz)
        by assp.yyyy.yy with ESMTPS(AES256-SHA) (ASSP 1.9.1.1); 10 Jan 2012
        14:37:04 +0100
Received: from assp.zzzz.zz (localhost [IPv6:::1])
        by mail.zzzz.zz (Postfix) with ESMTP id 74F445001EC
        for <sms@yyyy.yy>; Tue, 10 Jan 2012 14:34:24 +0100 (CET)
Received: from smtp.zzzz.zz ([10.xxx.xxx.xxx] helo=smtp.zzzz.zz)
        by assp.zzzz.zz with ESMTP (2.1.1); 10 Jan 2012 14:34:24 +0100
Received: from MTA by smtp.zzzz.zz
        with Novell_GroupWise; Tue, 10 Jan 2012 14:34:23 +0100
Message-Id: <4F0C4C5F02000070000054DE@smtp.zzzz.zz>
X-Mailer: Novell GroupWise Internet Agent 7.0.4
Date: Tue, 10 Jan 2012 14:34:07 +0100
From: sms@zzzz.zz
Sender: Postmaster@zzzz.zz
Reply-To: sms@zzzz.zz
Errors-To: Postmaster@zzzz.zz
To: sms@yyyy.yy
Subject: FW:
Mime-Version: 1.0
Content-Type: message/rfc822
X-Assp-Version: 2.1.1(11364) on assp.zzzz.zz
X-Assp-ID: assp.zzzz.zz 02464-02434


Return-path: <original.sender@xxxx.xx>
Received: from mail.zzzz.zz (obis-bno.zzzz.zz [10.xxx.xxx.xxx])
        by smtp.zzzz.zz with ESMTP; Tue, 10 Jan 2012 14:33:34 +0100
X-Spam-Status: No, hits=0.0 required=7.5
        tests=AWL: -0.898,BAYES_00: -1.665,HTML_MESSAGE: 0.001,
        MISSING_SUBJECT: 2.476,RDNS_NONE: 0,TOTAL_SCORE: -0.086,autolearn=no
X-Spam-Level:
Received: from assp.zzzz.zz ([10.xxx.xxx.xxx])
        by mail.zzzz.zz
        (using TLSv1/SSLv3 with cipher AES256-SHA (256 bits))
        for original.recipient@zzzz.zz;
        Tue, 10 Jan 2012 14:33:28 +0100
Received: from nx0.xxxx.xx ([193.xxx.xxx.xxx] helo=nx0.xxxx.xx) by
        assp.zzzz.zz with ESMTPS(AES256-SHA) (2.1.1); 10 Jan 2012 14:33:05 +0100
From: original.sender@xxxx.xx
Received: from AZLHMS22.ms.xxxx.xx ([169.xxx.xxx.xxx]) by AALHMS14.ms.xxxx.xx
([10.xxx.xxx.xxx]) with mapi id 14.01.0339.001; Tue, 10 Jan 2012 14:33:04 +0100
To: <original.recipient@zzzz.zz>
Subject:
Thread-Index: AczPnGBeuMulVAdORAmppb8Usrs8dg==
Date: Tue, 10 Jan 2012 13:33:03 +0000
Message-ID: <1B7EB6CF76C38348A14B9F2184E93EF19A73@AZLHMS22.ms.xxxx.xx>
Accept-Language: cs-CZ, en-US
Content-Language: cs-CZ
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-originating-ip: [10.xxx.xxx.xxx]
Content-Type: multipart/mixed;
        boundary="_004_1B7EB6CF76C38348A14B9F2184E93EF19A73AZLHMS22ms_"
MIME-Version: 1.0
X-Assp-Version: 2.1.1(11364) on assp.zzzz.zz
X-Assp-Client-TLS: yes
X-Assp-Server-TLS: yes
X-Assp-Message/IP-Score: -10 (SSL/TLS-connection-OK)
X-Assp-Delay: not delayed (whitelisted); 10 Jan 2012 14:33:28 +0100
X-Assp-Whitelisted: Yes
X-Assp-ID: assp.zzzz.zz 02403-03012


--_004_1B7EB6CF76C38348A14B9F2184E93EF19A73AZLHMS22ms_
Content-Type: multipart/alternative;
        boundary="_000_1B7EB6CF76C38348A14B9F2184E93EF19A73AZLHMS22ms_"

--_000_1B7EB6CF76C38348A14B9F2184E93EF19A73AZLHMS22ms_
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
pparoulek
 
Posts: 62
Joined: Fri Aug 06, 2010 2:17 pm

Re: ASSP 2.1.1(11364) - add empty line in header

Postby pparoulek » Mon Jan 16, 2012 9:08 am

I think, that problem make when ASSP replace old-added X-Assp lines in email header.
New empty line is added after X-Assp-ID:
As you can see in third mail (received by forwarded recipient) there are two X-Assp-ID lines in header, and after booth are two empty lines instead of one.


Is there somebody who can solve it? First message is near to one week old and there is no answer...
pparoulek
 
Posts: 62
Joined: Fri Aug 06, 2010 2:17 pm

Re: ASSP 2.1.1(11364) - add empty line in header

Postby pparoulek » Fri Jan 20, 2012 2:03 pm

I'm disappointed. For 10 days have problem with corrupted emails - it's unreadable. Email corruption come with version 2.1.1, nothing else is changed.

There is still no reaction, but in other threads is...

I'm not Perl specialist to find and repair this problem in code, but can help with it by making some requried tests.
pparoulek
 
Posts: 62
Joined: Fri Aug 06, 2010 2:17 pm

Re: ASSP 2.1.1(11364) - add empty line in header

Postby pparoulek » Fri Jan 20, 2012 3:36 pm

I do some more tests and found, that empty line is added by ASSP every pass and doesn't matter if SSL/TLS is enabled or disabled. Also doesn't matter if message come over IPv4 or IPv6.
Old version 1.9.1.1(0.1.02) works fine, but have problems with TLS/SSL and IPv6.

Same problem has version 1.7. some time ago (06/2010) and was solved by Fritz.
pparoulek
 
Posts: 62
Joined: Fri Aug 06, 2010 2:17 pm

Re: ASSP 2.1.1(11364) - add empty line in header

Postby fribo » Fri Jan 20, 2012 5:49 pm

Old version 1.9.1.1(0.1.02) works fine, but have problems with TLS/SSL and IPv6.


Did you ever tested 1.9.2.6 with TLS/SSL and IPv6 ?
I did not get any bug report about that in 1.9.2.6
fribo
Site Admin
 
Posts: 2163
Joined: Sat Jan 24, 2009 12:31 pm
Location: "Borgstedt,Talkau" lat=53.5738070251, lon=10.5729692988

Re: ASSP 2.1.1(11364) - add empty line in header

Postby pparoulek » Fri Jan 20, 2012 6:28 pm

Hi Fritz, nice to "see" You again.

No, because... viewtopic.php?f=11&t=1376
...and You say me, to stay in working version. When reach about 600 IPs in noTLS, then I do a upgrade to version 2.x

Everything works except this new lines in email. I'm disease from today's morning and have more time to testing now.

I found, that bug is inside subroutine "addMyHeader", few minutes ago. I remark this in code (3 times) and assp seems to works fine. Of course i haven't any assp header in email, but x-Assp headers are stored in assp mail folders, otherwise there is no new empty line.
pparoulek
 
Posts: 62
Joined: Fri Aug 06, 2010 2:17 pm

Re: ASSP 2.1.1(11364) - add empty line in header

Postby pparoulek » Sun Jan 22, 2012 12:47 am

All is about time...
I found the bug in code at 01:30. There is an original subrutine addMyheader:
Code: Select all
sub addMyheader {
    my $fh = shift;
    my $this = $Con{$fh};
    d('addMyheader');
    return unless $this->{myheader};

    my $headlen = index($this->{header}, "\x0D\x0A\x0D\x0A");  # merge header
    $headlen = 0 if $headlen < 0;
    my $preheader = my $header = substr($this->{header},0,$headlen);
    if ($this->{preheaderlength}) {    # we have added our headers before - now find the end of the orig header
        $this->{preheaderlength} -= 2; # step back two bytes  ("\x0D\x0A")
        $this->{preheaderlength} = 0 if $this->{preheaderlength} < 0;   # min offset is 0
        $this->{preheaderlength} = index($this->{header}, "\x0D\x0A",$this->{preheaderlength});
        $this->{preheaderlength} = ( $this->{preheaderlength} < 0 ) ? 0 : $this->{preheaderlength} + 2;
        $preheader = substr($header,0,$this->{preheaderlength});
    }
    my $myheader = headerFormat($this->{myheader});
    $myheader =~ s/(?:\r|\n)+$/\r\n/o;
    $preheader =~ s/(?:\r|\n)+$//o;
    $preheader .= "\r\n" if $preheader;
    $this->{preheaderlength} = length $preheader;
    my $newheader = $preheader . $myheader ;
    $newheader .= "\r\n\r\n" unless $headlen;

    substr($this->{header},0,$headlen,$newheader);
    $this->{maillength} = length($this->{header});
}


This line set to variable headlen length of original header, but ony to the end of text WITHOUT ENTER at the end!
Code: Select all
my $headlen = index($this->{header}, "\x0D\x0A\x0D\x0A");  # merge header


This line put new header into mail header, but WITH ENTER at the end.
Code: Select all
substr($this->{header},0,$headlen,$newheader);


There is more than one way to solve this bug. I do it by $headlen incremet of 2.
In other way can add 2 in substr function or remove last enter from $newheader.
Code: Select all
my $headlen = index($this->{header}, "\x0D\x0A\x0D\x0A")+2;  # merge header with first enter at the end of header
pparoulek
 
Posts: 62
Joined: Fri Aug 06, 2010 2:17 pm

Re: ASSP 2.1.1(11364) - add empty line in header

Postby fribo » Wed Jan 25, 2012 9:10 pm

fixed in assp 2.1.2 build 12023:
fribo
Site Admin
 
Posts: 2163
Joined: Sat Jan 24, 2009 12:31 pm
Location: "Borgstedt,Talkau" lat=53.5738070251, lon=10.5729692988


Return to Bug reports

Who is online

Users browsing this forum: No registered users and 1 guest