|Anonymous | Login||2014-03-17 15:32 UTC|
|Main | My View | View Issues | Change Log | Roadmap | Docs | My Account|
|Viewing Issue Simple Details|
|ID||Category||Severity||Reproducibility||Date Submitted||Last Update|
|0000011||[ReMooD (C)] User Interface (Console, Menu, etc.)||feature||always||2009-08-28 23:46||2010-06-12 22:36|
|Summary||0000011: Gamma curve generator|
You are still using my old gamma table, and I am now using this new gamma table generator with 25 settings.
|Tags||No tags attached.|
gamma_curve.tar [^] (20,480 bytes) 2009-08-28 23:46
gamma_notes.txt [^] (4,262 bytes) 2009-10-01 20:51
gamma_plot.txt [^] (334 bytes) 2009-10-01 20:52
gamma_test.txt [^] (1,380 bytes) 2009-10-01 20:55
gamma_test6.diff [^] (18,109 bytes) 2009-10-01 20:56
gamma_test8.diff [^] (20,347 bytes) 2009-10-06 21:48
doomgamma [^] (4,758 bytes) 2009-10-06 22:05
doomgamma.txt [^] (209 bytes) 2009-10-06 22:08
w25_gamma.patch [^] (24,810 bytes) 2010-01-05 22:38
What does this gamma curve generator do and how does it work exactly?
Also, did you write the code yourself or was it taken from elsewhere?
Totally written by myself from scratch, for Legacy, and you can use it too.
The existing gamma control selects from 4 gamma tables. I added a 5th table to legacy, and I think you got that patch in ReMooD too.
My new patch (conditional) replaces all the tables with one table that is generated dynamically from two setpoints. One dark level setpoint is controlled by the F11 key that the previous gamma control used. The mid level setpoint is controlled from a slider on a setup page. Because of the added slider a new options page is created with two gamma sliders (dark level and mid level) (if I remember the names right). Each slider has 13 positions. The gamma table is created by linear interpolation from these setpoints and other fixed assumptions . The darkest is almost 0, the brighest is 255, and the curve must be continuous. I have been using this code for months now.
The dark slider has the most dramatic effect, and needs such fine control.
The mid slider does not appear to do much, but as monitors and video cards differ, I expect each user will find a different setting as best.
Working on alternative versions of gamma curve generator. Previous version
could use some smoothing at least. I attach work and alternative functions.
I also attach a diff file that gives a selection of curve generators, for testing purposes.
Use the console to select a gamma curve
choices are 0,1,2,3,4,5,6 10,11,12,13,14,15,16
where the set 10-16 have the setpoint moved to 24 and 128.
gamma -3 set the bright
gamma_bl -2 set the black level
|Please remove the other changes from the patch (menu changes and optionally move them to another patch. Also change add vid_ before gamma variables and allow gamma control for each channel (RGB). Thanks.|
edited on: 2009-10-06 22:12
Upload gamma_test8.diff, which gives you two more alternative gamma table generators. You can pick one and use it in ReMooD. I consider gammafunc 8 to be the best choice.
The new gammfunc 7 and gammafunc 8 can recreate the original gamma tables for certain gamma settings, which my original patch and most of the other gammafunc did not do. I am also considering changing the black level name from gamma_bl to black_level, or just black.
This is currently being worked on for an upcoming Legacy release, so the actual code we use will be further modified.
The menu is part of the patch because there is not enough room in the existing menus. I do not know how to solve that for you if you do not want another options page. I think you should just add the options page unconditionally.
Wouldn't just be easier to change the gamma variable names when you work this into ReMooD. This is not a patch against ReMooD, it is a patch against Legacy.
I do not know yet what you may have changed in ReMooD. Which gamma variables are using vid_ ??, the cv_ ones, or the console commands, or others ??
Adding individual gamma tables for RGB goes beyond the original intent, and is not trivial. The functions that use the tables would have to be modified.
Worse is that there would now be 6 new sliders to adjust colors, plus there should be overall gamma adjust. This is a whole new options page with many decisions to be made. What did you have in mind, and why ??
I have a copy of ReMooD, but have not done anything with it yet. I suppose I could work up a patch against ReMooD, but I would be guessing about some of the things you asked for. It would have to wait for a while because I am busy with Legacy.
Upload w25_gamma.patch, this is the latest gamma code that Legacy is using
This version has three gamma generators that the user can choose between.
One is simple one curve gamma.
Another has black level adjustment in addition to the gamma curve.
Another has linear segments, for strange display monitors like LCD's.
|Does not really apply to ReMooD.|
|2009-08-28 23:46||wesleyjohnson||New Issue|
|2009-08-28 23:46||wesleyjohnson||File Added: gamma_curve.tar|
|2009-08-28 23:46||wesleyjohnson||Big Endien?||=> off|
|2009-08-28 23:46||wesleyjohnson||Operating System||=> Linux|
|2009-08-28 23:46||wesleyjohnson||Processor||=> x86_64 (amd64)|
|2009-09-20 02:53||Ghostlydeath||Big Endien?||off =>|
|2009-09-20 02:53||Ghostlydeath||Severity||minor => feature|
|2009-09-20 02:53||Ghostlydeath||Status||new => assigned|
|2009-09-20 02:53||Ghostlydeath||Assigned To||=> Ghostlydeath|
|2009-09-20 02:55||Ghostlydeath||Note Added: 0000012|
|2009-09-21 21:30||wesleyjohnson||Note Added: 0000013|
|2009-10-01 20:50||unauthenticated||Note Added: 0000014|
|2009-10-01 20:51||unauthenticated||File Added: gamma_notes.txt|
|2009-10-01 20:52||unauthenticated||File Added: gamma_plot.txt|
|2009-10-01 20:54||wesleyjohnson||Note Added: 0000015|
|2009-10-01 20:55||wesleyjohnson||File Added: gamma_test.txt|
|2009-10-01 20:56||wesleyjohnson||File Added: gamma_test6.diff|
|2009-10-01 20:59||unauthenticated||Note Deleted: 0000014|
|2009-10-06 02:08||unauthenticated||Note Added: 0000024|
|2009-10-06 21:48||wesleyjohnson||File Added: gamma_test8.diff|
|2009-10-06 22:01||wesleyjohnson||Note Added: 0000025|
|2009-10-06 22:04||wesleyjohnson||Note Edited: 0000025|
|2009-10-06 22:05||wesleyjohnson||File Added: doomgamma|
|2009-10-06 22:08||wesleyjohnson||File Added: doomgamma.txt|
|2009-10-06 22:12||wesleyjohnson||Note Edited: 0000025|
|2010-01-05 22:37||wesleyjohnson||Note Added: 0000026|
|2010-01-05 22:38||wesleyjohnson||File Added: w25_gamma.patch|
|2010-06-12 22:36||Ghostlydeath||Note Added: 0000031|
|2010-06-12 22:36||Ghostlydeath||Status||assigned => closed|
|2010-06-12 22:36||Ghostlydeath||Resolution||open => won't fix|
|Mantis 1.1.8[^] Copyright © 2000 - 2009 Mantis Group|